From 42d4c81369e63867e6bb228092975272dcf77795 Mon Sep 17 00:00:00 2001 From: Noah <33094578+coolreader18@users.noreply.github.com> Date: Thu, 15 Apr 2021 17:22:21 -0500 Subject: [PATCH] Unskip tests --- Lib/test/test_asyncore.py | 2 -- Lib/test/test_fileio.py | 3 +-- Lib/test/test_genericpath.py | 2 -- Lib/test/test_pathlib.py | 28 ---------------------------- Lib/test/test_unicode_file.py | 2 -- Lib/test/test_zipimport.py | 2 -- 6 files changed, 1 insertion(+), 38 deletions(-) diff --git a/Lib/test/test_asyncore.py b/Lib/test/test_asyncore.py index 7fb97eb97..089eb18d4 100644 --- a/Lib/test/test_asyncore.py +++ b/Lib/test/test_asyncore.py @@ -425,8 +425,6 @@ class FileWrapperTest(unittest.TestCase): f = None support.gc_collect() - # TODO: RUSTPYTHON - @unittest.expectedFailure def test_close_twice(self): fd = os.open(support.TESTFN, os.O_RDONLY) f = asyncore.file_wrapper(fd) diff --git a/Lib/test/test_fileio.py b/Lib/test/test_fileio.py index 8495ac1ec..1f6b26ef5 100644 --- a/Lib/test/test_fileio.py +++ b/Lib/test/test_fileio.py @@ -277,8 +277,6 @@ class AutoFileTests: pass return wrapper - # TODO: RUSTPYTHON - @unittest.expectedFailure @ClosedFDRaises def testErrnoOnClose(self, f): f.close() @@ -633,6 +631,7 @@ class OtherFileTests: self.assertRaises(ValueError, self.FileIO, "/some/invalid/name", "rt") self.assertEqual(w.warnings, []) + @unittest.skip("TODO: RUSTPYTHON") def testUnclosedFDOnException(self): class MyException(Exception): pass class MyFileIO(self.FileIO): diff --git a/Lib/test/test_genericpath.py b/Lib/test/test_genericpath.py index 06234a2c2..123395ba4 100644 --- a/Lib/test/test_genericpath.py +++ b/Lib/test/test_genericpath.py @@ -353,8 +353,6 @@ class TestGenericTest(GenericTest, unittest.TestCase): def test_samestat_on_link(self): super().test_samestat_on_link() - # TODO: RUSTPYTHON - @unittest.expectedFailure def test_invalid_paths(self): for attr in GenericTest.common_attributes: # os.path.commonprefix doesn't raise ValueError diff --git a/Lib/test/test_pathlib.py b/Lib/test/test_pathlib.py index 14e1ac9a9..fcc5b3776 100644 --- a/Lib/test/test_pathlib.py +++ b/Lib/test/test_pathlib.py @@ -1331,8 +1331,6 @@ class _BasePathTest(object): p = P(P('').absolute().anchor) / '~' self.assertEqual(p.expanduser(), p) - # TODO: RUSTPYTHON - @unittest.expectedFailure def test_exists(self): P = self.cls p = P(BASE) @@ -1742,8 +1740,6 @@ class _BasePathTest(object): p.mkdir() self.assertEqual(cm.exception.errno, errno.EEXIST) - # TODO: RUSTPYTHON - @unittest.expectedFailure def test_mkdir_parents(self): # Creating a chain of directories. p = self.cls(BASE, 'newdirB', 'newdirC') @@ -1891,8 +1887,6 @@ class _BasePathTest(object): self.assertTrue(link.is_dir()) self.assertTrue(list(link.iterdir())) - # TODO: RUSTPYTHON - @unittest.expectedFailure def test_is_dir(self): P = self.cls(BASE) self.assertTrue((P / 'dirA').is_dir()) @@ -1906,8 +1900,6 @@ class _BasePathTest(object): self.assertIs((P / 'dirA\udfff').is_dir(), False) self.assertIs((P / 'dirA\x00').is_dir(), False) - # TODO: RUSTPYTHON - @unittest.expectedFailure def test_is_file(self): P = self.cls(BASE) self.assertTrue((P / 'fileA').is_file()) @@ -1922,8 +1914,6 @@ class _BasePathTest(object): self.assertIs((P / 'fileA\x00').is_file(), False) @only_posix - # TODO: RUSTPYTHON - @unittest.expectedFailure def test_is_mount(self): P = self.cls(BASE) R = self.cls('/') # TODO: Work out Windows. @@ -1937,8 +1927,6 @@ class _BasePathTest(object): self.assertIs(self.cls('/\udfff').is_mount(), False) self.assertIs(self.cls('/\x00').is_mount(), False) - # TODO: RUSTPYTHON - @unittest.expectedFailure def test_is_symlink(self): P = self.cls(BASE) self.assertFalse((P / 'fileA').is_symlink()) @@ -1955,8 +1943,6 @@ class _BasePathTest(object): self.assertIs((P / 'linkA\udfff').is_file(), False) self.assertIs((P / 'linkA\x00').is_file(), False) - # TODO: RUSTPYTHON - @unittest.expectedFailure def test_is_fifo_false(self): P = self.cls(BASE) self.assertFalse((P / 'fileA').is_fifo()) @@ -1967,8 +1953,6 @@ class _BasePathTest(object): self.assertIs((P / 'fileA\x00').is_fifo(), False) @unittest.skipUnless(hasattr(os, "mkfifo"), "os.mkfifo() required") - # TODO: RUSTPYTHON - @unittest.expectedFailure def test_is_fifo_true(self): P = self.cls(BASE, 'myfifo') try: @@ -1981,8 +1965,6 @@ class _BasePathTest(object): self.assertIs(self.cls(BASE, 'myfifo\udfff').is_fifo(), False) self.assertIs(self.cls(BASE, 'myfifo\x00').is_fifo(), False) - # TODO: RUSTPYTHON - @unittest.expectedFailure def test_is_socket_false(self): P = self.cls(BASE) self.assertFalse((P / 'fileA').is_socket()) @@ -1993,8 +1975,6 @@ class _BasePathTest(object): self.assertIs((P / 'fileA\x00').is_socket(), False) @unittest.skipUnless(hasattr(socket, "AF_UNIX"), "Unix sockets required") - # TODO: RUSTPYTHON - @unittest.expectedFailure def test_is_socket_true(self): P = self.cls(BASE, 'mysock') sock = socket.socket(socket.AF_UNIX, socket.SOCK_STREAM) @@ -2011,8 +1991,6 @@ class _BasePathTest(object): self.assertIs(self.cls(BASE, 'mysock\udfff').is_socket(), False) self.assertIs(self.cls(BASE, 'mysock\x00').is_socket(), False) - # TODO: RUSTPYTHON - @unittest.expectedFailure def test_is_block_device_false(self): P = self.cls(BASE) self.assertFalse((P / 'fileA').is_block_device()) @@ -2022,8 +2000,6 @@ class _BasePathTest(object): self.assertIs((P / 'fileA\udfff').is_block_device(), False) self.assertIs((P / 'fileA\x00').is_block_device(), False) - # TODO: RUSTPYTHON - @unittest.expectedFailure def test_is_char_device_false(self): P = self.cls(BASE) self.assertFalse((P / 'fileA').is_char_device()) @@ -2033,8 +2009,6 @@ class _BasePathTest(object): self.assertIs((P / 'fileA\udfff').is_char_device(), False) self.assertIs((P / 'fileA\x00').is_char_device(), False) - # TODO: RUSTPYTHON - @unittest.expectedFailure def test_is_char_device_true(self): # Under Unix, /dev/null should generally be a char device. P = self.cls('/dev/null') @@ -2159,8 +2133,6 @@ class PosixPathTest(_BasePathTest, unittest.TestCase): st = os.stat(join('other_new_file')) self.assertEqual(stat.S_IMODE(st.st_mode), 0o644) - # TODO: RUSTPYTHON - @unittest.expectedFailure def test_touch_mode(self): old_mask = os.umask(0) self.addCleanup(os.umask, old_mask) diff --git a/Lib/test/test_unicode_file.py b/Lib/test/test_unicode_file.py index dc72c723c..e8feb42c6 100644 --- a/Lib/test/test_unicode_file.py +++ b/Lib/test/test_unicode_file.py @@ -117,8 +117,6 @@ class TestUnicodeFiles(unittest.TestCase): # The 'test' functions are unittest entry points, and simply call our # _test functions with each of the filename combinations we wish to test - # TODO: RUSTPYTHON - @unittest.expectedFailure def test_single_files(self): self._test_single(TESTFN_UNICODE) if TESTFN_UNENCODABLE is not None: diff --git a/Lib/test/test_zipimport.py b/Lib/test/test_zipimport.py index 9958da407..231e6ab21 100644 --- a/Lib/test/test_zipimport.py +++ b/Lib/test/test_zipimport.py @@ -717,8 +717,6 @@ class BadFileZipImportTestCase(unittest.TestCase): support.create_empty_file(TESTMOD) self.assertZipFailure(TESTMOD) - # TODO: RUSTPYTHON - @unittest.expectedFailure def testFileUnreadable(self): support.unlink(TESTMOD) fd = os.open(TESTMOD, os.O_CREAT, 000)