From 407f251866f437987bb86419bbd672b9327db4ea Mon Sep 17 00:00:00 2001 From: Daniel Chiquito Date: Sat, 24 Feb 2024 13:33:17 -0500 Subject: [PATCH] Un-skip passing typing test I missed that the typing test I disabled was on a base test class. Moving the expected failure to the subclass allows the passing test to pass. --- Lib/test/test_typing.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Lib/test/test_typing.py b/Lib/test/test_typing.py index 3140ff902..95fd3748e 100644 --- a/Lib/test/test_typing.py +++ b/Lib/test/test_typing.py @@ -513,8 +513,6 @@ class BaseCallableTests: with self.assertRaises(TypeError): self.assertNotIsInstance(None, Callable[[], Any]) - # TODO: RUSTPYTHON update typing to 3.12 - @unittest.expectedFailure def test_repr(self): Callable = self.Callable fullname = f'{Callable.__module__}.Callable' @@ -707,6 +705,11 @@ class CollectionsCallableTests(BaseCallableTests, BaseTestCase): def test_concatenate(self): # TODO: RUSTPYTHON, remove when this passes super().test_concatenate() # TODO: RUSTPYTHON, remove when this passes + # TODO: RUSTPYTHON might be fixed by updating typing to 3.12 + @unittest.expectedFailure + def test_repr(self): # TODO: RUSTPYTHON, remove when this passes + super().test_repr() # TODO: RUSTPYTHON, remove when this passes + class LiteralTests(BaseTestCase): def test_basics(self):