From 1da239ac0809463bde41c0e18f24e4ef5528f953 Mon Sep 17 00:00:00 2001
From: Noa <33094578+coolreader18@users.noreply.github.com>
Date: Tue, 9 Nov 2021 15:44:02 -0600
Subject: [PATCH] Fix clippy

---
 common/src/atomic.rs      | 6 ++++++
 common/src/linked_list.rs | 2 +-
 vm/src/dictdatatype.rs    | 2 +-
 vm/src/pyobjectrc.rs      | 2 +-
 4 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/common/src/atomic.rs b/common/src/atomic.rs
index b27f2d3e5..afe4afb44 100644
--- a/common/src/atomic.rs
+++ b/common/src/atomic.rs
@@ -56,6 +56,12 @@ pub struct OncePtr<T> {
     inner: PyAtomic<*mut T>,
 }
 
+impl<T> Default for OncePtr<T> {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl<T> OncePtr<T> {
     #[inline]
     pub fn new() -> Self {
diff --git a/common/src/linked_list.rs b/common/src/linked_list.rs
index 0d508b94a..5834a1443 100644
--- a/common/src/linked_list.rs
+++ b/common/src/linked_list.rs
@@ -245,7 +245,7 @@ impl<L: Link> LinkedList<L, L::Target> {
 
     // === rustpython additions ===
 
-    pub fn iter<'a>(&'a self) -> impl Iterator<Item = &'a L::Target> {
+    pub fn iter(&self) -> impl Iterator<Item = &L::Target> {
         std::iter::successors(self.head, |node| unsafe {
             L::pointers(*node).as_ref().get_next()
         })
diff --git a/vm/src/dictdatatype.rs b/vm/src/dictdatatype.rs
index eed94e622..4fe19d014 100644
--- a/vm/src/dictdatatype.rs
+++ b/vm/src/dictdatatype.rs
@@ -605,7 +605,7 @@ impl<T: Clone> Dict<T> {
         };
         match slot {
             Some(entry) if entry.index == index_index => {
-                if pred(&entry.value)? == false {
+                if !pred(&entry.value)? {
                     return Ok(ControlFlow::Break(None));
                 }
             }
diff --git a/vm/src/pyobjectrc.rs b/vm/src/pyobjectrc.rs
index 5e844fad6..7a031de8a 100644
--- a/vm/src/pyobjectrc.rs
+++ b/vm/src/pyobjectrc.rs
@@ -265,7 +265,7 @@ impl WeakRefList {
 }
 
 impl WeakListInner {
-    fn iter<'a>(&'a self) -> impl Iterator<Item = &'a PyObjectView<PyWeak>> {
+    fn iter(&self) -> impl Iterator<Item = &PyObjectView<PyWeak>> {
         self.list.iter().filter(|wr| wr.0.refcount.get() > 0)
     }
 }