mirror of
https://github.com/THU-MAIC/OpenMAIC.git
synced 2026-10-28 16:35:27 +08:00
@openmaic/renderer@0.2.0
176
Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
|
|
b87e014423 |
fix(renderer): fit short Cartesian charts and preserve readable labels (#1973)
* fix(renderer): fit short Cartesian charts (#1968) ECharts default grid margins consume 145px and collapse short charts. Use relative margins with label containment and a scrollable legend in the app and SDK, leave room above line labels, and preserve explicit imported plot rectangles. Register ECharts 6 containment compatibility and cover real SVG layout, text bounds, and resize behavior. * fix(renderer): keep compact chart endpoint labels visible * fix(deps): sync renderer ECharts peer constraint in lockfile * fix(renderer): size chart text and legend margins in pixels Percentage text margins over-reserved space on normal-size charts: an 800x450 two-series line plot shrank from the 305px main baseline to 214px. Use 22px label headroom and a 26px legend row, and verify normal-size plot height and resizing in both builders. |
||
|
|
63f17991c3 |
feat(tts): configure provider-local voice lists and defaults in YAML (#1969)
TTS provider presets in YAML can now declare a provider-local voice list and options.defaultVoice. Config validation rejects voices on non-TTS presets and defaultVoice values outside the configured list; cloned voices are preserved. Documented in all doc locales. |
||
|
|
d111c4b04d |
fix(renderer): hide pending inline math sources (#1962)
Formulas deferred by the rendering budget stay hidden until they are typeset, so raw LaTeX no longer flashes on dense slides; sources that cannot be typeset are still shown as text. Budgets and scheduling are unchanged. Bumps @openmaic/renderer to 0.1.17. Related to #1869 Co-authored-by: YizukiAme <YizukiAme@users.noreply.github.com> |
||
|
|
c4a24031b8 |
feat: integrate material library into main (#1896)
Adds the owner-scoped material library ("Knowledge base" in the UI) from the integration branch, as tracked in #1736 (RFC: Discussion #1716).
- Library page from the left rail: one folder-and-file list with search, automatic parsing after upload, Parse again, in-place folder creation and renaming, drag-to-move, source and folder deletion with confirmation, usage and separately counted file storage.
- Composer `@` and toolbar picker over the whole library; failed materials cannot be attached from any entry point.
- Agent tools to list, organize and parse materials, with one-line summaries in tool rows; deletion stays page-only.
- Originals and extraction outputs live in the asset pool under generic `asset_root_refs`; extraction is reused across conversations.
- Every successful upload, from classic and Pro and including existing undeleted uploads, stays in the library until explicitly deleted (#1898). The 24-hour sweep only reclaims unfinished upload reservations.
- `@openmaic/storage` 0.38.0.
Release conditions (breaking): stop all old instances before this version accepts writes, do not roll back below this release, and enable `MATERIALS_POOL_BACKFILL=1` only after every old instance has stopped. See CHANGELOG for schema additions and `ASSET_COLLECTION_GRACE_MS`.
|
||
|
|
99e87f4e42 |
fix(generation): inject KaTeX into interactive scenes that reference it (#1966)
Inject the platform's KaTeX at the start of <head>, ahead of page scripts, guarded by a data-openmaic-katex marker instead of the word "katex", with no-op stand-ins when the CDN is unreachable, so pages that ship their own KaTeX no longer crash with a ReferenceError and init()-filled labels typeset on first paint. Adds an interactive-math prompt snippet and bumps @openmaic/generation to 0.3.23. Fixes #1538 |
||
|
|
6e20534fe0 |
fix(svg): validate malformed slide shapes and recover their text (#1915)
Add @openmaic/geometry, a browser-independent validator for SVG path syntax, finite view boxes and transforms and bounded resources, with structured errors and shared shape-to-text recovery. Generation, rendering, both editors and PPTX export use it: invalid shapes with a label render as text, unlabelled ones are omitted, stored records are not rewritten, and recovered shapes cannot be resized. Imported PPTX labels keep their own insets. Bumps generation 0.3.22, renderer 0.1.16, editor 0.0.12 and geometry 0.1.0. Closes #1851 Co-authored-by: cosarah <cosarah@users.noreply.github.com> |
||
|
|
86f38c3181 |
fix(renderer): bound inline math work without starving active slides (#1930)
Share a per-frame markup allowance (256k characters) across live prose roots, let thumbnails use only what the foreground leaves and finish in idle time, reuse deferred typesetting results, and keep snapshot rendering synchronous. Matrix-heavy slides no longer block the main thread in one long task; ordinary and dense slides still typeset before paint. Bumps @openmaic/renderer to 0.1.15. Fixes #1869 Co-authored-by: YizukiAme <YizukiAme@users.noreply.github.com> |
||
|
|
aaca61742c |
feat(editor): derive current course issues and thumbnail markers (#1903)
Phase 1 of Course issues (#1900): a pure collectCourseIssues in @openmaic/dsl 0.12.0 derives issues from the current course document (speech without audio, generated-media placeholders, dangling cues, action-content lint) with stable ids and structured evidence, and the editor thumbnails show warning markers that clear when the issue is fixed. Narration issues are skipped when the workspace cannot generate audio. Related to #1900 Co-authored-by: Oliveryfaso <Oliveryfaso@users.noreply.github.com> |
||
|
|
9c872bdde3 |
fix(agents): match generated agent voices to catalogue gender (#1908)
Pass catalogue voice gender to the agent-profile prompt, ask the model to keep voice, name and persona gender consistent, persist a language-independent voiceDesign.gender, and make the fallback voice pick prefer the agent's gender. Catalogues without male/female data keep the previous behavior. Closes #1084 Co-authored-by: Frank-zhu2000 <Frank-zhu2000@users.noreply.github.com> |
||
|
|
729c044b5b |
chore(models): remove the retired Veo 3.1 preview models (#1948)
Google shuts down veo-3.1-generate-preview, veo-3.1-fast-generate-preview and veo-3.1-lite-generate-preview on 2026-10-22. They were the last models of the built-in Veo video provider (Veo 3.0 and 2.0 went in #1939), and the Veo adapter does not speak the API of Google's replacement, gemini-omni-1.1-flash. A catalog entry that cannot generate is worse than an absent one, so the provider is removed as Sora was: its catalog entry, type-union member, adapter, UI name and icon, VIDEO_VEO_* mapping, docs rows and tests. OpenRouter Video keeps google/veo-3.1, which OpenRouter serves from Vertex AI and is not part of this shutdown. Configurations written for earlier versions keep working. RETIRED_PRESETS names the removed preset: an openmaic.yml provider with preset: veo no longer stops the server, the slots that named such a provider (in the file or in workspace settings) follow their parents again, and startup notices ask to remove the provider and any VIDEO_VEO_* variables. Referencing the provider directly fails with the reason instead of "unknown preset". Supporting gemini-omni-1.1-flash is tracked in #1940. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
+13 |
dc88fb5011 |
feat(web-search): add Firecrawl provider (#1834)
* feat(web-search): add Firecrawl provider
* fix(generation): require explicit state publication and initialize game state (#1795)
* fix(generation): require explicit state publication and initialization
* fix(generation): bump package version to 0.3.16
* test(generation): stop old worker before seeding recovery checkpoint
* refactor: deduplicate export menu items (#1693)
Co-authored-by: Tiyatrotist <179411334+Tiyatrotist@users.noreply.github.com>
* fix(server): client TTS URL refusal must not promise ALLOW_LOCAL_NETWORKS (#1798)
* fix(server): client TTS URL refusal must not promise ALLOW_LOCAL_NETWORKS
validatePublicUrlForSSRF now passes clientSupplied: true.
Opt-in-governed refusals on that call — loopback, localhost, .local,
private, link-local, and CGNAT literals, and a DNS answer set whose
disqualifying addresses are all in those ranges — use a new string
stating that ALLOW_LOCAL_NETWORKS does not apply and that the endpoint
must be an operator-managed provider in server-providers.yml.
validateUrlForSSRF still returns the existing flag guidance when the
flag is unset and still allows those targets when it is set.
Cloud-metadata targets keep their own message, and reserved, multicast,
and broadcast addresses, including a DNS answer set that contains one,
keep the generic local-network message.
Fixes #1771
* fix(server): point client TTS URL refusal at openmaic.yml
1.2.0 deprecates server-providers.yml; operator-managed provider
endpoints now live in openmaic.yml under providers:.
---------
Co-authored-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
Co-authored-by: wyuc <wang-yc24@mails.tsinghua.edu.cn>
* fix(render): isolate preview execution from video exports (#1830)
Co-authored-by: wyuc <wang-yc24@mails.tsinghua.edu.cn>
* fix(test): normalize Windows path separators and replace shell grep in test suite (#1642) (#1828)
* test: normalize Windows path separators and replace shell grep in test suite (#1642)
* ci: re-trigger checks
---------
Co-authored-by: cham <2577781125@qq.com>
Co-authored-by: wyuc <wang-yc24@mails.tsinghua.edu.cn>
* fix(export): drop non-woff2 font fallbacks instead of about:invalid (#1826)
* fix(export): drop non-woff2 font fallbacks instead of about:invalid
When an inlined stylesheet's @font-face offers a woff2, the inliner kept
only the woff2 and pointed the woff/ttf/otf/eot fallbacks at
url(about:invalid). Chromium and WebKit check every @font-face src URL
against the page's font-src CSP when the rule is parsed, whether or not
the face is ever used, so the standalone HTML export (font-src data:)
logged one CSP violation per fallback: about 40 for a page that loads the
KaTeX stylesheet. The woff2 fonts were inlined and render; the errors
were noise.
Remove those fallback entries from the src list instead, keeping local()
entries and format() hints, and remove a src declaration left empty.
@font-face rules without a woff2 are inlined as before, and a woff2 that
fails to fetch is still reported through the inline failure report.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(export): prune font fallbacks per src declaration
The woff2 check ran across the whole @font-face rule, so a later src
declaration without a woff2 (src:url(A.woff2);src:url(B.ttf)) was
removed and the earlier woff2 won the cascade instead of the authored
B.ttf. Judge each src declaration on its own: only a declaration that
offers a woff2 loses its woff/ttf/otf/eot entries, and declarations are
never removed.
Also treat an entry with a format("woff2") hint as woff2, so an
extensionless or mis-named woff2 URL counts and is never pruned.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(export): keep font fallbacks behind conditional woff2 sources
Only prune woff/ttf/otf/eot fallbacks that follow an unconditional woff2
source in the same src list: a single url() with a plain format("woff2")
or format(woff2) hint (or none, with a woff2 URL). A woff2 entry gated by
tech(), `supports` inside format(), a woff2-variations or multi-format
hint is skipped by browsers that lack the feature (WebKit does not support
tech(color-COLRv1)), so the fallbacks behind it are kept and inlined.
Entries before the first unconditional woff2 are kept as well, since a
browser would use them first.
Fallbacks after an unconditional woff2 are now also recognised by their
format() hint, so extensionless TTF/WOFF URLs are pruned too.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(export): treat malformed woff2 format() hints as conditional
parseFontSrcEntry skipped separator tokens inside format(), so the
malformed `format("woff2",)` read as a plain woff2 hint and the fallbacks
behind it were pruned. Browsers skip such an entry, which left the face
with no usable source and no reported asset failure.
format() now keeps every token (separators as themselves, nested
functions and unclosed strings as empty tokens), and an unclosed url() or
format() counts as an extra part, so only an exact single `woff2`
keyword or string qualifies as unconditional. Anything else keeps and
inlines the fallbacks.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(math): disable formula-defined macros in KaTeX and Temml rendering (#1827)
* fix(math): disable formula-defined macros in every KaTeX and Temml render
Add safeKatexOptions to @openmaic/dsl, the one package every renderer,
importer, editor and the app already depend on. It merges hardened
settings into each caller's options: macro-defining commands (\def,
\gdef, \edef, \xdef, \global, \long, \let, \futurelet, \newcommand,
\renewcommand, \providecommand) become inert macros that consume the
definition, trust is forced off, maxExpand is pinned, and a fresh
macros object is built per call so nothing persists between renders.
Caller options and caller-supplied macros are kept.
Route every render through it: whiteboard and slide latex elements,
quiz math, standalone HTML inline math, PPTX export via Temml, the
editor's latex dialog and inline math node, generated latex elements,
and the importer's formula paths. Keep the importer's node-globals
rollup plugin off the dsl build, whose old parser cannot read `??`.
Tests cover each render path with nested-definition inputs, a corpus of
legitimate formulas that must render byte-identically, \gdef isolation,
and a guard that fails if a new KaTeX/Temml call skips the helper.
Bump @openmaic/dsl 0.11.3, editor 0.0.10, generation 0.3.16,
importer 0.3.1.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(math): harden workbench chat math and newcommand parsing
Workbench chat Markdown rendered math through @streamdown/math, which
only forwards errorColor to rehype-katex. Add createSafeMathPlugin,
which keeps that plugin's remark side and rehype-katex instance but
replaces the rehype options with safeKatexOptions, and use it in the
chat text block.
Rework the inert \newcommand family: peek at unconsumed tokens so a
body written as {[} stays a body, accept the starred form, skip [n]
and [default] groups with brace-aware scanning, then consume exactly
one replacement body. Document that caller-supplied macros are trusted
code and must not be derived from content.
Replace the call-text coverage check with an import-aware guard built
on the TypeScript parser. It finds every runtime import of a math
engine (default, aliased, named, namespace, side-effect, import =
require, re-export, dynamic import, require) plus injected auto-render
script text, and requires each file to be on a reviewed allowlist.
Files that import KaTeX or Temml directly must use them only as render
calls with safeKatexOptions(...). The interactive post-processor is
allowlisted: its page already runs model-written scripts in a sandboxed
iframe. Fixtures cover each bypass shape.
Add KaTeX and Temml regression tests for the newcommand edge cases,
and the workbench chat path to the expansion-input suite.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(math): fresh macros per chat formula and stricter render guard
KaTeX writes built-in state into the macros object while rendering (an
align environment sets \@eqnsw), and rehype-katex spreads one options
object into every render. The workbench chat plugin shared one macros
object, so that state leaked between formulas and between messages.
Make macros an enumerable getter that returns a fresh hardened object
on every read, so each render and each error retry gets its own. Add
cross-formula and cross-message regression tests.
Tighten the guard for files that import KaTeX or Temml directly: any
engine reach other than a static default or namespace import (require,
dynamic import, re-export, import = require, side-effect import) is
rejected; the options argument is checked at each method's own
position with nothing after it; and it must be a call to
safeKatexOptions imported from @openmaic/dsl, not a local look-alike.
Document the guard's scope: module imports only; global access, engine
code inside other HTML strings and require.resolve need review.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(math): keep built-in equation numbering with macro definitions disabled
KaTeX and Temml implement \tag, \tag*, \nonumber and \notag as built-in
macros that expand to \gdef\df@tag{\text{...}} and \gdef\@eqnsw{0}.
Swallowing every \gdef therefore dropped equation tags and stopped
\nonumber / \notag from suppressing align/gather/equation numbers.
The inert \gdef now accepts exactly those two built-in shapes and stores
them the way the engines' own \gdef does; every other \gdef, and every
other definition command, stays inert. '@' is a letter in both lexers,
so formulas can name these macros directly; the allowed shapes add
nothing \tag* and \nonumber do not already provide:
- \@eqnsw may only be set to 0;
- \df@tag may only be one \text{...} group that never mentions \df@tag,
so the tag is expanded exactly once (a self-reference would recurse
until the call stack or the expansion budget runs out, as it does in
the stock engines on \tag{\df@tag}).
Tests: tagged and \notag/\nonumber formulas render identically to stock
KaTeX (html, mathml, htmlAndMathml) and Temml; the slide element, quiz,
editor dialog and Workbench chat renderers show tags and suppress
numbers; definitions inside tags, self-referencing tags, nested tags and
non-built-in \df@tag/\@eqnsw shapes stay inert.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(math): expand a tag in full only once per accepted definition
A formula can name \df@tag itself, so a long \tag*{...} (or an accepted
\gdef\df@tag{\text{...}}) followed by many \df@tag mentions re-expanded
the whole tag on every mention, up to the expansion budget: about 12 KB
of input produced several MB of output.
An accepted \df@tag is now stored as a macro that yields its body on the
first expansion and an empty \text{} afterwards. The engines expand
\df@tag once per formula, or once per align row before clearing it, so
tags render unchanged (stock-equality tests, including an align with a
tag on several rows, stay green in KaTeX and Temml). The empty \text{}
rather than nothing avoids a Temml TypeError on an empty tag.
Also document, and test through the PPTX export, that Temml throws a
TypeError on a script left bare by an inert definition (x^\notag); the
only Temml consumer catches it and returns null.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* chore(generation): bump to 0.3.17 after main took 0.3.16
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* feat(export): play the standalone HTML classroom with narration, effects and video (#1842)
* feat(export): keep playback actions and embed narration in standalone HTML
The standalone HTML manifest now keeps each scene's playback actions,
reduced to what an offline player can replay: speech text (plus its
audioRef when the bytes ship), spotlight/laser targets, play_video,
widget actions, and the discussion topic. Whiteboard actions, unknown
types, discussion prompts and agent bindings are left out.
With the new includeNarration option the snapshot collects narration
(stored and legacy audioUrl) and video bytes. Actions and video elements
name them by archive path, and the bytes travel as base64 data blocks
(script type="application/octet-stream") indexed by a media table, so
the browser keeps them as text until a clip plays. Payload collection is
format-neutral so a later folder variant can ship the same paths as
files. The export reports its byte size and missing narration; the CSP
is unchanged and the file still makes no network requests.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* feat(standalone-player): play the classroom with narration, effects and captions
A lightweight sequencer replays each scene's actions the way the
classroom's playback engine does, without its stores or IndexedDB audio
player (only the pure timing helpers are shared):
- speech waits for its embedded narration, or for the classroom's
reading-time estimate when there is none; its text is shown as a
caption that can be toggled;
- spotlight and laser drive SlideCanvas effects, fire without blocking
so they overlap the next speech, clear 5 s after the latest one and
on every scene change;
- play_video plays the embedded clip in place and waits for its end
(capped); a video without bytes keeps its poster;
- discussion shows a card with the topic and a link to the online
classroom, closing on its own after a few seconds;
- widget actions are posted to the sandboxed interactive iframe;
- whiteboard and unknown actions are skipped.
Playback starts only from the Play button (or Space), which primes the
shared narration element inside the gesture; a refused play() falls back
to the reading timer, and video to muted playback. Slide scenes advance
automatically; quiz, interactive and PBL scenes hold after their
narration, as the classroom's auto-play does, until the learner
continues. Navigating cancels the running scene cleanly and, while
playing, starts the new scene from its beginning.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* feat(export): choose narration in the HTML export menu and warn on large files
"Export as HTML" becomes a submenu, like the PPTX one: "With narration
and video" embeds narration audio and video clips, "Without narration"
keeps the file small (captions on the reading timer, poster frames for
videos). The option that fits the classroom is listed first. Narration
that could not be embedded counts as a partial export, and files above
100 MB get a size warning.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(export): label narration by the container its bytes are
Stored narration can carry the wrong format: a provider that answers
WAV without a usable Content-Type is recorded as mp3. Exports then
labelled the clip audio/mpeg and named it .mp3, and WebKit, trusting
the label, reported a WAV with a streaming placeholder data length as
about 44,700 s long.
The narration collectors shared by the classroom ZIP and the standalone
HTML export now sniff the container from the leading bytes (RIFF/WAVE,
ID3 or MPEG frame sync, OggS, fLaC, ftyp, WebM) and use it for the MIME
type and archive extension; unrecognized bytes keep the stored label.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(export): tighten standalone media policy and build large files as Blob parts
- A slide video whose src is a direct URL no stored asset backs is now
fetched (same timeout policy as images) and embedded; when it cannot
be fetched it is reported as unresolved media instead of silently
falling back to its poster.
- "Without narration" now means no audio or video payload anywhere:
interactive pages do not fetch their <video>/<audio> sources (new
skipMedia inline option) and already-embedded clips are stripped,
while their images, posters and other assets are still inlined.
- Slide audio elements, which the offline player never plays, are no
longer collected or counted as missing narration.
- The document is assembled as Blob parts (base64 in pieces, clips
encoded one at a time), so no single string approaches V8's length
limit. The size is estimated from the media byte counts before
anything is encoded; above 400 MB the export stops with a localized
explanation (StandaloneHtmlTooLargeError, the hook for a future
page-plus-media-folder fallback). The 100 MB warning stays.
- Media block comments now say when a block is decoded.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(standalone-player): stop videos at their cap and keep controls in step
- play_video now pauses the clip when its wait cap passes or the run is
cancelled, and clears the losing timer and listeners when the wait
settles, so a clip never plays on under the next narration.
- The video's own controls stay in step with playback: pausing the
awaited clip pauses playback and playing it resumes; starting any
other video pauses the narration, and resuming playback pauses that
video again.
- Space leaves a focused video or audio element to toggle itself, and
keeps scrolling quiz and PBL scenes when focus is inside the scene.
- A caption lasts as long as its speech, so nothing is left over a
held quiz or interactive scene.
- Play after the last scene finished starts over from the first scene.
- The start overlay shows on whichever scene the file opens on and goes
away on any navigation, a hash change included.
- Body text is antialiased like the classroom page.
- Tests for the media ports (pause racing play, refused and failing
clips, muted retry, cap, control sync, widget queue), the media
library, the overlay and Space rules, and holding for every held
scene type.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(export): exact size ceiling, thorough media stripping, ADTS behind ID3
- Resuming the awaited video through its own controls now pauses any
video started by hand, as resuming playback by any other path does.
- The size estimate counts the manifest as the escaped UTF-8 bytes the
document carries, and the assembled Blob is checked against the
ceiling too, so the 400 MB guard holds exactly (maxBytes is an option
for hosts and tests).
- Without narration, the src of <video>, <audio> and their <source>
elements is stripped for any data: URI whatever MIME it declares, and
stripping recurses into nested srcdoc documents (bounded depth; deeper
documents are dropped).
- Audio sniffing skips a leading ID3v2 tag (syncsafe size) and reads
the frame after it: MPEG audio stays mp3, AAC ADTS becomes aac, also
for untagged ADTS.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(standalone-player): toggle a focused video on Space in every browser
WebKit's native video controls ignore Space, so with the slide video
focused nothing happened while the video kept playing. The player now
handles Space on a focused video or audio element itself, in the
capture phase, toggling that element and stopping the press so
Chromium's native toggle does not fire as well; the element's play and
pause events keep playback in step exactly as its controls do.
Verified in Chromium, WebKit and Firefox.
The "Without narration" export description no longer promises a still
frame for videos (generated videos have none); it says videos are not
included, in all locales.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* feat(export): fall back to a ZIP of classroom.html and its media for large classrooms (#1845)
* feat(export): add a stored ZIP writer that references its entries' Blobs
The standalone export's media-folder variant ships already-compressed
narration and video. JSZip reads every input Blob into an ArrayBuffer and
concatenates its output into one ArrayBuffer, so a multi-hundred-megabyte
archive would sit in the tab several times over. This writer stores entries
uncompressed, reads each one a slice at a time only to compute its CRC-32,
and returns a Blob composed of the entries' own Blobs, so no media is
copied. Paths are checked to stay inside the extraction folder, and
archives plain ZIP cannot describe (4 GiB) are refused.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* feat(standalone-player): say so when media shipped next to the page is missing
A page whose media table names files by relative path (the ZIP variant of
the export) plays nothing when opened without them: straight from inside
the ZIP, or copied out alone. The media library now probes one linked file
as the player opens and records any linked clip that fails to load, and the
player shows a notice asking to extract the whole ZIP. Playback carries on
as before: failed narration falls back to the reading timer and a failed
video no longer holds the sequence.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* feat(export): fall back to a ZIP of classroom.html and its media folders
A classroom whose single HTML file would pass the 400 MB ceiling is now
exported as a ZIP instead of refused: classroom.html carries the player and
manifest, and its media table names each narration and video file by
relative path (audio/..., media/...) next to it, plus a README in the UI
locale and English. The ZIP needs no base64 and copies no media, so it is
built from the same snapshot without a second collection pass.
The page's CSP differs from the single file's only in media-src, which adds
'self' so <audio>/<video> elements may load the sibling files (Chromium and
WebKit match it against file: URLs when the page is opened from disk);
connect-src stays 'none', so the player never reads the bytes itself. The
single file is unchanged, byte for byte.
The fallback is automatic, at the same ceiling, because one file is the
better format wherever it works; the export menu keeps its two entries.
A toast explains why a ZIP was saved and that it must be extracted before
opening classroom.html.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(export): keep stored ZIP fields below the ZIP64 sentinels
0xFFFF entries and 32-bit sizes or offsets of 0xFFFFFFFF announce ZIP64
records, so a plain archive must stay below them: the writer now refuses
65,535 entries and any size, offset or archive length that would reach
0xFFFFFFFF, and limits entry names by their UTF-8 bytes (what the header
field holds) instead of UTF-16 units. The CRC slice size is injectable.
Tests now read the raw bytes: every local header is compared field by
field with its central directory entry and the end record, and the CRC
carry across slices, the boundaries and the DOS date clamp are covered.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(standalone-player): report every linked file that fails, and word the notice for both causes
WebKit and Firefox reject play() with NotSupportedError for a narration
file that is not there, before (or without) an error event, and the clip's
handler was gone by the time the event fired: a missing clip after a
successful startup probe played silently with no notice. The rejection
now reports linked clips, and the narration element keeps a standing error
listener for the clip it is loading.
When the media table links no file (an export without narration), the
startup probe loads a linked slide image instead.
A file in a codec the browser cannot play fails exactly like a missing one
on file:, so the notice now covers both: "Some images, narration or video
couldn't be loaded. If you opened classroom.html from inside the ZIP,
extract the whole ZIP first." Adds a SlideScene test for video errors.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(export): ship slide images as files in the ZIP and refuse an oversized page
The ZIP fallback kept slide images, backgrounds, patterns, chart point
images and video posters inline as data: URIs, so a classroom heavy in
images could produce a ZIP whose classroom.html alone passed the ceiling.
In the ZIP they are now files under images/, named by relative path, and
the page's CSP adds 'self' to img-src as well as media-src. Image bytes
are collected once and encoded as data: URIs only for the single file; the
single file's size is estimated from the linked manifest, exactly, without
encoding anything. The single file is unchanged.
Media inside interactive scenes stays inline: those pages run in sandboxed
opaque-origin frames, which Chromium and Firefox do not let load files
from disk (WebKit does). A ZIP whose page alone still passes the ceiling
is refused with its own message (StandaloneHtmlTooLargeError of kind
"page"), and the fallback toast and README name what the ZIP holds.
The CSP comment now spells out what 'self' allows when the folder is
served over HTTP: same-host GETs, with cookies, from image and media
elements (interactive frames included); nothing can be read back, since
connect-src stays 'none'.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(export): keep chart point images inline and ship inline slide images as files in the ZIP
Two gaps in the ZIP variant's image handling:
- Pictorial charts rendered blank: the chart renderer wraps each point
image in a data: SVG symbol, which cannot load a file, so a relative
path there drew nothing in any browser. Chart point images now stay
inline as data: URIs in the ZIP (a ref named only by a chart ships no
file).
- Images that were already data: URIs (images, backgrounds, shape
patterns, video posters) were never collected and stayed in the page,
so such a classroom could still be refused as too large. In the ZIP
they are now decoded into files under images/, one per distinct URI;
a MIME type no file extension conveys, or a malformed URI, stays
inline. The single-file estimate counts each one as the exact escaped
URI it replaces, and the single file keeps them as before.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(export): follow-ups from the standalone HTML playback review (#1848)
* fix(export): pause a first hand-started video when a second starts; keep captions off narrow scenes
Starting a second video by hand on one slide left both playing. The
registry now pauses the other hand-started videos (never the one the
sequencer awaits).
On narrow viewports the caption bar covered part of the scene (quiz
options). It now has its own strip below the scene; from the sm
breakpoint up it overlays the scene as before.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(export): accurate export messages and menu order; static fallback without JavaScript
- Size warnings only suggest exporting without narration when narration
was included.
- Missing narration clips get their own toast wording instead of being
counted as external assets that could not be bundled.
- The HTML export submenu prefers 'with narration and video' when the
classroom has narration audio or slide video.
- The file carries a static message for viewers that do not run scripts
(iOS Files preview, scripts disabled or blocked). It sits right before
the player script so it never paints while a large file parses, is
removed when the player mounts, switches to a generic "couldn't start"
message if the player fails, and has a <noscript> copy. Localized
through the player strings; the CSP is unchanged.
- Caption strip: fixed height, only while playback is active, scrolls long
lines, also used on short (landscape) screens.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(export): fallback message on the first screen; report failed linked images; skip ZIP-only decoding for single files
- The static fallback message sat below the empty full-height root, so it
started below the first screen. The empty root is now hidden until the
player mounts. The fallback is removed after the player's first commit
(not right after render()), so a first-render error still shows the
"couldn't start" message.
- The no-JavaScript hint no longer names a platform-specific sharing step.
- Slide images that fail to load from a linked relative path (a missing
images folder) now trigger the linked-files notice, also when the audio
and video probes load.
- Inline data: images are only decoded into files once the ZIP is going to
be built (about 0.6 s and +100 MB for 100 MB of images otherwise); the
single file and its size estimate are unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(storage): bound DocumentStore HTTP requests with a deadline (#1790)
* fix(storage): bound DocumentStore HTTP requests with a deadline
HttpDocumentStore issued every request without a deadline, so a request
whose peer never answers held its promise forever. The stage autosave
keeps at most one save in flight (startFlushRound's flushInFlight guard)
and starts the next one only once that promise settles, so a single
stalled save silently stranded every later save for the life of the page
— generation and the editor kept working from the in-memory store, and
the loss only surfaced on reload.
Bound the request round trip — sending the body and receiving the
response headers — with an AbortController deadline (requestTimeoutMs,
default 30s, <= 0 disables). A stalled request now rejects with
HttpDocumentStoreError(0, 'HTTP_REQUEST_TIMEOUT'), which the autosave's
existing backoff already retries. This mirrors the budget HttpAssetStore
applies via probeTimeoutMs / startBoundedOperation.
Reading the response body stays outside the bound: a large document on a
slow link is slow, not stalled.
Co-Authored-By: Claude Code <noreply@anthropic.com>
* docs(changelog): describe the request budget's fixed throughput and ceiling
The throughput and ceiling are module constants, not HttpDocumentStore
options; only requestTimeoutMs is configurable.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Code <noreply@anthropic.com>
Co-authored-by: wyuc <wang-yc24@mails.tsinghua.edu.cn>
* fix(export): hide the no-JavaScript fallback as soon as the standalone player starts (#1850)
The static fallback message is now hidden synchronously when the player
script runs (kept in the DOM), so a slow parse of a very large file can no
longer reveal it before the first commit. A start failure (sync or async
render error) un-hides it with the "couldn't start" text; it is still
removed after the first successful commit. Scripts that never run leave it
visible as before.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(generation): explain exhausted plan quotas (#1831)
* fix(generation): explain exhausted plan quotas
* test(generation): use nullable model metadata in quota fixture
* fix(generation): keep provider quota detection neutral and scene-scoped
Address the review of #1831:
- The shared classification no longer reads vendor codes. MiniMax TTS and
web search translate base_resp 1008/2056 into ProviderQuotaExhaustedError
(thrown, or as the cause of the rate-limit error an HTTP 429 keeps), and
isUpstreamQuotaExhausted checks only that marker and the
OpenAI-compatible wire codes.
- The built-in classification reports PROVIDER_QUOTA_EXHAUSTED, so a host
that meters its own QUOTA_EXHAUSTED can tell the two apart, and a host's
start refusal keeps the host's own message.
- The classroom passes the guidance only while the pending scene card is
the scene the run paused at; a scene the run went on past keeps the
generic failure text.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PyhoDKKJ3gVoPbvCT3T99K
* test(generation): cover quota guidance through the classroom hook
---------
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: wyuc <wang-yc24@mails.tsinghua.edu.cn>
* Preserve rotation for generated slide shapes (#1855)
* fix preserving generated shape rotation
* bump generation package version
* fix generation rotation check formatting
---------
Co-authored-by: wyuc <wang-yc24@mails.tsinghua.edu.cn>
* fix(storage): support path-style S3 addressing (AI-assisted) (#1849)
Adds an opt-in `AWS_S3_FORCE_PATH_STYLE` (`true` or `1`) that sets the AWS SDK v3 `forcePathStyle` client option for the S3 asset byte store, so S3-compatible stores such as MinIO and Ceph can be addressed as `endpoint/bucket/key`. Unset keeps the existing Amazon S3 behaviour. Bumps `@openmaic/storage` to 0.37.3.
Fixes #1686
Co-authored-by: weinaike <13814354+weinaike@users.noreply.github.com>
* fix(render): bound preview capacity through launch cleanup (#1836)
Co-authored-by: wyuc <wang-yc24@mails.tsinghua.edu.cn>
* fix(sanitize): store inline math as LaTeX source and typeset it in the client (#1829)
* fix(sanitize): keep inline math through the scene-content sanitizer
The prose policy flattened the editor's inline formulas on every
persistence read and write: it dropped data-inline-math, the MathML
annotation, the layout SVG and KaTeX positioning, so saved formulas
rendered broken and their LaTeX source was lost.
Move the lift / sanitize / re-render approach from the standalone HTML
export into lib/sanitize/inline-math.ts and apply it in
sanitizeProseHtml, so the persistence boundary and the export share one
implementation. It parses with parse5, so it needs no DOM and runs on
the server and in the browser alike. Each formula is replaced by an
empty source span before sanitizing, and every surviving source span is
replaced afterwards by a fresh KaTeX render (trust: false); authored
markup never bypasses the policy. Prose without a formula skips the
parse and is sanitized byte-for-byte as before. Renders are cached by
source, and pathological markup falls back to the plain policy instead
of failing the read or write.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(sanitize): bound inline math rendering and detect encoded KaTeX classes
KaTeX markup is 100-150x the size of its source and is regenerated
synchronously on every persistence read and write, so one large formula
could block the event loop for seconds and pin hundreds of MB in the
render cache.
- Render a formula only if its source is at most 2000 characters, and
within a per-call budget of 16000 source characters and 1000
formulas. Anything else stays a source span showing its LaTeX as text,
so nothing is lost and the editor still recovers it. Limits are counted
in document order, never time, so repeated passes stay stable.
- Bound the render cache by markup size (1 MB) and never cache renders
over 32 KB.
- Pre-check on `data-inline-math` or `annotation` instead of `katex`:
element and attribute names cannot be written as character references,
but a class value can, so an encoded `katex` class no longer skips the
lift and loses its source.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(sanitize): store inline math as source and typeset it in the client
Rendering formulas on the server made every persistence read and write
run KaTeX on authored input, which user macros and long sources can turn
into seconds of CPU per document. Store each inline formula as its LaTeX
source instead and let the clients that display slides typeset it.
- The prose sanitizer reduces each inline formula (span[data-inline-math],
else span.katex with a TeX annotation, entity-encoded class included)
to <span data-inline-math="SRC">SRC</span> and allows only that
attribute. The source doubles as text for consumers that do not render
math. A source over 2000 characters is kept as plain text. The pre-pass
uses htmlparser2, the parser sanitize-html uses, so it is linear and
sees the same element boundaries; prose without a formula marker is
sanitized exactly as before. The server never runs KaTeX, and the
parse5 lift, render cache and budgets are gone.
- @openmaic/renderer typesets span[data-inline-math] in text, shape and
table prose after injection (renderInlineMath / useInlineMath), with
trust disabled, macro definitions blocked and bounded expansion. It
also re-renders older content that still carries KaTeX markup. The
app's slide renderer components use the same hook. Bump the renderer
to 0.1.12.
- The standalone HTML export ships source-only formulas, which the
player's renderer typesets, and ships the math fonts when a slide has
an inline formula.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(slide-renderer): keep cell markup intact when formatting table text
formatText turned every space in a table cell into , including
the spaces inside tags, which broke any cell markup with attributes. An
inline formula in a cell was shown as its raw source instead of being
typeset. Only format the text between tags.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(renderer): allow 1000 macro expansions when typesetting inline math
A cap of 50 expansions rejects realistic long formulas: built-in
commands such as \neq, \iff, \, and \dots each count, and a formula with
a few dozen of them needs over 100. Macro definitions are blocked, so
expansion stays linear in the source and 1000 is only a backstop. This
matches the shared safe KaTeX options.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(sanitize): replace self-closing inline formulas in SVG and MathML once
Inside SVG or MathML the parser honours `/>` and reports the close as
implied while still on the opening token, so the replacement ended
before the formula started and the original span stayed next to the
stored one; the next pass then stored it again. End a formula no earlier
than its opening tag. Adds SVG and MathML cases and fuzzes the pass for
idempotency and formula shape.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(renderer): keep inline math typeset across re-renders
React can rewrite `dangerouslySetInnerHTML` markup on a re-render even
when the HTML string is unchanged, which put the stored source spans
back after a move or resize while the effect, keyed on the HTML, did not
run again. Typeset after every commit instead: formulas already typeset
are skipped, and typeset formulas are cached by source and cloned, so a
re-render costs a query and, at most, cheap clones. Typesetting never
updates React state.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(renderer): budget inline math typesetting per prose root
One slide packed with large formulas could block the page for hundreds of
milliseconds on every mount. Typeset at most 4000 characters of uncached
source or 100 uncached formulas per pass over a prose root before paint,
and the rest in idle time, a chunk of the same size per idle period. The
next commit, an unmount or new content cancels pending idle work. Past
50 000 characters or 1000 formulas per root, formulas are shown as their
LaTeX text. Slide snapshots typeset everything before capture. Covers
identical-content re-renders and A, B, A, A content sequences in both
renderers.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(renderer): keep inline math progress across commits and complete snapshots per root
- Give injected prose a stable dangerouslySetInnerHTML value per markup
string (text, shape label and each table cell, in both renderers), so
React leaves unchanged markup alone. Typeset formulas and pending idle
progress then survive re-renders; formulas too large to cache are no
longer typeset again on every commit. The every-commit pass stays as a
safety net.
- Mark each prose root and complete snapshots root by root, so each text
box keeps its own hard cap as on the live slide instead of sharing one
slide-wide count.
- Apply the hard cap from document order on every pass, whatever earlier
passes typeset, and let a formula shown as text by an earlier cap be
typeset once it falls within its root's cap.
- Note that the render cache bound counts serialized characters.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* chore(renderer): bump to 0.1.13 after rebase
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(renderer): typeset inline math through the shared safeKatexOptions
Replace the local stand-in options (inert macro-definition commands,
trust: false, maxExpand 1000) with safeKatexOptions from @openmaic/dsl,
keeping the inline-specific settings (displayMode: false, output: html,
throwOnError: false, strict: ignore). The shared helper's expansion budget
is the same 1000, and it also keeps the built-in \tag/\notag state and
makes \long inert.
The math engine guard now lists the renderer's inline-math module as a
render-calls site and drops the standalone HTML rich-text module, which no
longer renders KaTeX itself.
Tests: ordinary formulas typeset byte-for-byte as with the previous
options, and formula-defined macros stay inert within one formula and
across formulas in the same prose root.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(sanitize): keep over-long inline formulas as formulas; bound typesetting only
The 2000-character bound dropped the data-inline-math marker at save time,
so an over-long formula became plain text for good. The bound now applies
only where formulas are typeset: the slide renderer already shows an
over-long source as text, and the editor's inline_math node now does the same
instead of typesetting it, using the renderer's MAX_INLINE_MATH_SOURCE.
@openmaic/editor 0.0.11.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test(sanitize): a 100 KB formula is kept as a formula in the node-environment suite
Follows the sanitizer change: the length bound applies to typesetting only.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* feat(media): add GLM (Zhipu CogView) image generation provider [AI-assisted] (#1832)
Co-authored-by: cham <2577781125@qq.com>
* fix(generation): stop retrying explicit provider quota refusals (#1861)
* fix(generation): stop retrying explicit provider quota refusals
* fix(generation): review follow-ups for provider quota refusals
- Leave a quota refusal the host classifies to the host, as documented for
`classifyFailure`: the built-in rule (`isProviderQuotaRefusal`) applies only
to refusals it does not answer for, at every retry site.
- Name an exhausted quota in the fallback log line, from the failure that
fired the fallback rather than an earlier attempt's.
- Stop reporting a retry after the outline fallback returns empty output.
- Drop the PBL loop-fallback change: a provider failure with an HTTP status
already skips the loop, and no LLM adapter throws the native quota marker.
`@openmaic/generation` stays at 0.3.18.
- Document that an explicit quota refusal goes to the fallback at once
(configuration, all six languages) and how it meets `classifyFailure`.
- Test a 403 quota refusal falling back, a quota refusal the host classifies
as retryable, and the stream error shapes the classifier reads.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test(generation): persist quota refusal regression coverage
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: wyuc <wang-yc24@mails.tsinghua.edu.cn>
* fix(persistence): share one AsyncLocalStorage across owner-bound stores (#1871)
* fix(persistence): share one AsyncLocalStorage across owner-bound stores
createOwnerBoundDocumentStore() built a new AsyncLocalStorage on every
call, and servers build a store per request. Every AsyncLocalStorage that
has run stays registered with async_hooks for the life of the process, so
each new promise paid a context propagation for every store ever created.
The cost grew linearly with requests served: under sustained load the main
thread saturated in async_hooks propagation and GC, and the event loop
stalled long enough for health checks to time out.
Carry the pending operation in one module-level AsyncLocalStorage instead.
Each store gets a small OperationScope; running an operation pushes a frame
that names its scope and links to the enclosing frame, and a store reads the
nearest frame of its own. This keeps the previous semantics: a store never
sees another store's operation, an operation of another store started inside
it does not hide the outer one, and the innermost of a store's own nested
operations wins.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(persistence): keep only each store's current operation in a context
A context's operation frame linked to every frame that was current when it
started, including other stores' and finished ones, so fire-and-forget work
that kept re-entering stores retained every earlier operation for as long as
its newest callback lived. Hold an immutable map of each store's current
operation instead: a context now keeps at most one operation per store,
exactly as a storage per store did.
Mark OperationScope as exported for tests only, and export the operation
type so the test can name it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* chore(persistence): note the snapshot size and restore the gc flag in tests
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(security): enforce model authorization for server-managed providers (#1879)
Providers configured with server credentials only send model ids the deployment authorizes (explicit model list plus default/fallback/slot references for the capability); anything else gets the same HTTP 403 before the provider is contacted. Covers chat, verification, media, speech, transcription, model-based search, generation, agent, PBL, quiz grading and workspace assignments. Breaking change: credentialed providers without a model list accept only their default/fallback models.
Co-authored-by: I3ob0 <huzi0404@163.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* docs: note automated Codex PR review in CONTRIBUTING (#1882)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(media): stop serving legacy media of deleted courses (#1883)
The classroom media route now checks the course lifecycle before touching the filesystem: a tombstoned course gets the same 404 as a missing file, a lifecycle lookup failure fails closed, and live courses (including legacy media without a course row) are served as before. Successful responses use private, max-age=300, must-revalidate; 416 and errors use private, no-store.
Co-authored-by: duanjialing.777 <duanjialing.777@bytedance.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(render): bind render jobs to the requesting owner (#1884)
Each MP4 render job is bound to the immutable owner of the submitting request: the app proxy asserts the owner on submit, poll, cancel and download, and the render-service only finds jobs for that owner (foreign and unknown jobs get the same 404, with no cancellation or artifact lookup). Job operations live under a separate /owner-bound/render namespace, so an instance that predates owner binding answers 404 without running a job handler and mixed old/new pools fail closed; job responses must carry the owner-bound marker. Upgrade the render-service together with or before the app.
Co-authored-by: duanjialing.777 <duanjialing.777@bytedance.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* release: v1.2.0-rc.2 (#1885)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(workbench): refuse oversized material uploads before sending them (#1887)
* fix(workbench): refuse oversized material uploads before sending them
The workbench uploader posted every picked file to /api/materials and only
learned about the size cap from the server's 413. The route does refuse an
oversized declared content-length early, but a reverse proxy that buffers
request bodies (nginx's default) still makes the browser send the whole file
first, so a user picking a 200 MB file waits for the full upload before
being told it is too large. Without such a proxy, the early 413 tends to
surface as a generic network failure instead of the size message.
Read the caps the capabilities endpoint already advertises
(maxDocumentBytes / maxMediaBytes, derived from the upload route's own
limits) and refuse a file over its class cap before any bytes are sent,
with the existing "file too large (limit X)" copy. The caps stay
server-owned, so a deployment that raises them is not blocked by a browser
constant. Discovery is fetched once per page and shared; a failed, invalid
or slow (>5s) read fails open to the server's 413, and once a read has
timed out later uploads do not wait on it again until it answers.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(workbench): leave unsupported types to the server's 415
The upload route rejects an unsupported MIME (415) before it applies a size
cap. Only precheck the size of supported types, so an oversized unsupported
file still gets the format error instead of being told to shrink.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(import): preserve committed document on lost response (AI-assisted) (#1864)
* fix(import): preserve committed document on lost response (AI-assisted)
A rejected save response can arrive after the server has committed the imported aggregate. Do not compensate by deleting the stage, because that turns an unknown write outcome into permanent data loss. Keep disposable local-cache cleanup and cover the response-loss path with a stateful regression test.
* fix(import): verify rejected document saves
Read the new document back when saveDocument rejects. Treat a found document as committed, while confirmed absence and read failures keep the import on the error path without destructive cleanup. Cover all three outcomes in the stateful import test.
* ci: cover every app PostgreSQL contract suite (#1867)
Co-authored-by: wyuc <wang-yc24@mails.tsinghua.edu.cn>
* fix(chat): guard Pi classroom tool calling before inference (#1894)
* fix(chat): guard Pi classroom tool calling before inference
* fix(i18n): match Pi model guidance to settings labels
* fix(renderer): cancel idle typesetting with its own pair and keep release-gate tests stable (#1901)
* fix(renderer): cancel idle typesetting with the pair that scheduled it
whenIdle checked requestIdleCallback/cancelIdleCallback when scheduling but
read cancelIdleCallback again when cancelling. If the global was removed or
replaced in between (a test stub restored, a polyfill swapped in), unmounting
a text element with pending inline math threw "scope.cancelIdleCallback is not
a function", or handed the handle to an implementation that never issued it.
Capture the request/cancel pair, and setTimeout/clearTimeout for the fallback,
at schedule time and always cancel through the captured function.
Make the inline-math regression tests fast and deterministic on a loaded
runner without dropping what they pin:
- Budget tests use distinct formulas padded with trailing spaces to 1,900
source characters. The budget counts source characters, so they cross it
exactly like the old 1,357-character matrices, at a fraction of the
typesetting cost.
- The uncacheable-render test uses 40 radicals per formula: each render is
still over the 64,000-character cache entry limit (asserted), several times
cheaper than a large matrix.
- Idle-time work runs through a stubbed idle queue that the test flushes,
instead of polling wall-clock timers; a fake-timer test covers the
setTimeout fallback.
- The snapshot tests replace KaTeX with a trivial typesetter (real
typesetting is covered by the element tests), use the minimum fixture that
crosses the per-root cap (2 x 501 formulas), wait for the deferred unmount
before restoring stubs, and count formulas only within the tree being
measured.
The [600, 600, 600, 600] measurement in the failed release run was a cascade:
slideToPng timed out, kept running, and its off-screen tree was still in
document.body when the next test counted roots across the whole body. Its
deferred unmount then ran after the idle stubs were restored, which is what
raised the unhandled TypeError.
New tests cancel after cancelIdleCallback is removed or replaced, and after
clearTimeout is replaced; they fail on the previous implementation.
Bump @openmaic/renderer to 0.1.14 so the next publish run releases it
(0.1.13 never reached the registry).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test(packages): keep release-gate tests stable on a loaded runner
The publish workflow runs every package's tests concurrently on one runner.
Two more checks in that step failed when the suites were run under CPU
contention:
- The macro-safety tests in editor, generation and importer asserted that a
render takes under 100 ms. On a loaded runner a guarded render can exceed
that. Raise the ceiling to 1 s: the unguarded nestedDef expansion takes tens
of seconds, a guarded render a few milliseconds, and the output-size and
error checks that follow are what show the definitions were dropped.
- Editor tests never unmounted their trees, because Testing Library only
registers automatic cleanup when the runner exposes a global afterEach.
React work still queued at the end of a file then ran after jsdom was torn
down ("window is not defined"). Clean up after each test in the shared
setup.
Test-only changes; no package version bumps are required.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(tests): make the suite reliable on Windows and newer Node runtimes (#1890)
- tests/ci/publish-openmaic-skill.test.ts: resolve bash the way PATH
finds it on Windows (/bin/bash elsewhere) and join PATH with
path.delimiter. All 16 cases failed on Windows before this.
- tests/store/kv-persist.test.ts: dedupe standing-problem reports per
key; how many recovery attempts elapse inside flushTasks is
wall-clock, not code.
- tests/workbench/workspace-rail-session-rename.test.ts: wait for the
row/menu with vi.waitFor(..., { timeout: 30_000 }) and give the suite
its own 30s budget for the cold dynamic import of the rail.
- tests/lint-llm-entry-guard.test.ts: 120s suite timeout — every case
runs the real eslint over every guarded path.
The media-orchestrator part of the original change is dropped: upstream
rewrote that suite and removed the fragile microtask-hop waits it
targeted.
No production code, no global config changes, no assertion weakened.
Co-authored-by: wyuc <wang-yc24@mails.tsinghua.edu.cn>
* fix(generation): parse data URLs without regex and cap vision image size (#1902)
## Summary
Large or unsupported images attached to vision requests can crash prompt building or be rejected by the model provider, and a single bad image fails the whole generation step (retries fail the same way).
- **`@openmaic/generation` 0.3.19**: `buildVisionUserContent` no longer runs a regex over the whole data URL. A new exported `parseBase64DataUrl` splits header and payload with plain string ops, so multi-megabyte payloads are never scanned by the regex engine.
- **Vision image cap (app)**: new `prepareVisionImages` (`lib/server/generation/vision-images.ts`) runs right before every vision call — outline, scene content, scene actions, and the PBL evaluator (which receives uploaded submissions).
- Pass-through only for single-frame, 8-bit sRGB/grayscale png/jpeg/webp/gif whose **base64 payload** is within `MAX_VISION_IMAGE_BASE64_BYTES` (1 MiB — providers measure the encoded payload) and whose longest side is within `MAX_VISION_IMAGE_DIMENSION` (2048 px). Pixels are strictly decoded first so truncated data is caught. http(s) URLs are untouched.
- Everything else (oversized, animated, CMYK, 16-bit, unsupported formats) is decoded once with sharp (first frame, EXIF-rotated, resized inside 2048, flattened on white, sRGB) and encoded to JPEG, stepping quality down until under the cap.
- Images that still don't fit or can't be decoded are dropped with a warning; the step continues.
- Preparation runs where vision images are resolved (outline and scene-content pre-resolution), so the prompt's "[see attached]" placeholders and asset-id mappings only describe images that are actually attached. The PBL evaluator logs when an image submission is evaluated without its image.
- Processing is sequential to bound peak memory.
Non-goals: no change to material upload/extraction, prompts, or generation logic.
## Test plan
- [x] `pnpm check`, `pnpm lint`, `npx tsc --noEmit`
- [x] `@openmaic/generation` build + typecheck + tests (incl. an 8 MiB payload, malformed and non-base64 data URLs, http passthrough)
- [x] New `tests/generation/vision-images.test.ts` (small untouched, large downscaled under caps, unsupported format converted, undecodable dropped while others kept, http untouched); updated scene-content / retry-boundary / evaluator tests
- [x] Full `pnpm test` (Node 22)
- [x] `node scripts/check-package-version-bumps.mjs origin/main`
🤖 Generated with [Claude Code](https://claude.com/claude-code)
* fix: typeset inline math in render-service previews and export it cleanly to PPTX (#1904)
* fix(render-service): typeset inline math in slide previews
Slide prose now stores an inline formula as its LaTeX source
(<span data-inline-math="SRC">SRC</span>) and leaves typesetting to the
renderer. render-service pinned @openmaic/renderer 0.1.4, which predates
that, so a slide preview showed the raw source (for example
"\frac{a}{b}") instead of the formula.
- Bump @openmaic/renderer to 0.1.14 and @openmaic/dsl to 0.11.3. The
changes in between are additive for this service: SlideCanvas props are
unchanged, the new dsl exports are math hardening and chart style types,
and charts still render with the lazily loaded ECharts runtime.
- Call completeInlineMath after mounting the slide. The live renderer
typesets at most 100 formulas per pass before paint and leaves the rest
to idle time; a capture needs all of them.
- Ship KaTeX's stylesheet with slide previews. KaTeX HTML needs its CSS and
math fonts: without them, typeset formulas lose their layout (a/b reads
"ba"). The preview document is an about:blank page, so each font face is
inlined as its woff2 data URL. The CSS is read from the KaTeX copy the
renderer resolves, once per process. This also gives LaTeX elements that
carry a KaTeX HTML snapshot the styles they were missing.
Tests: the stylesheet inlines every face, and a real Chromium preview of
150 stored formulas, with idle callbacks disabled, typesets all of them in
KaTeX fonts before capture.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(export): write inline formulas to PPTX as their LaTeX source
A stored inline formula (<span data-inline-math="SRC">SRC</span>)
already exports as its source text, since the span's text is the source.
Prose that has not been saved yet still carries the editor's rendered
KaTeX tree, and the PPTX text walk wrote every text node in it: the
MathML text, the TeX annotation and each layout glyph as separate runs,
so E=mc^2 became "E=mc2E=mc^2E=mc2". KaTeX from a PPTX import (only a
TeX annotation, no attribute) came out the same way, and table cells
were written verbatim, tags and character references included.
- Treat an inline formula as one run holding its LaTeX source, with the
same parse rules as the editor: span[data-inline-math], else span.katex
with a TeX annotation. The run keeps the surrounding text style.
- Write table cell text as plain text: tags dropped, character
references decoded (stored cells hold "R&D"), breaks and paragraphs
as newlines, formulas as their source. Cells without markup are
unchanged.
Formulas stay LaTeX text, not native equations: inline OMML in a text
run needs PowerPoint's AlternateContent wrapper per text shape, which is
left for a separate change that can be checked in PowerPoint.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(export): keep table cell lines when converting cells for PPTX
The table cell conversion sent any cell containing `&` through the HTML
path, which dropped newlines: plain text "R&D\nSales" exported as one
paragraph "R&DSales" instead of two. It also dropped empty paragraphs, so
<p>A</p><p></p><p>B</p> lost its blank line.
- Only text with a tag or comment takes the HTML path. Plain text has its
character references decoded and keeps its lines.
- In markup, a newline in the text starts a new line, as the slide
renderer shows it (it turns cell newlines into line breaks), and so do
<br> and each paragraph. An empty paragraph is an empty line; a
paragraph that already ended on a break (a trailing <br>, a nested
block) adds no further line.
Tests read the paragraphs of each exported table cell from the slide XML.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test(slide-renderer): keep the uncacheable inline math test fast on a loaded runner
The app slide renderer's "formulas too large to cache" test typeset six
1,360-character matrices (about 170 KB of markup each) in two elements and
polled wall-clock timers for idle work. On a loaded CI runner it ran past
the 5 s test timeout. Apply the approach the renderer package's own tests
already use, keeping what the test pins:
- Each formula is 40 radicals padded with trailing spaces to 1,900 source
characters. Six still cross the 4,000-character per-pass budget, and
each render is still over the typeset cache's 64,000-character
per-entry limit, now asserted, so every re-typeset stays full price.
- Idle work runs through a stubbed idle queue that the test flushes,
instead of polling timers.
- The test now also asserts that the first pass leaves formulas for later.
The other tests in the file typeset one short formula each and are
unchanged. Under CPU load (12 busy loops plus 12 concurrent runs on 12
cores) the test takes about 2.0 s, down from about 4.1 s; unloaded,
0.32 s, down from 1.0 s.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* test(renderer): give heavy inline-math typesetting suites room on loaded runners (#1907)
## Summary
The package release gate (`publish-packages.yml` → "Validate release candidate") runs the `@openmaic/*` package suites concurrently. The suites that typeset ~1,000 KaTeX formulas (the inline-math hard-cap cases) take ~0.3–0.4 s each locally but exceed vitest's 5 s default on a loaded runner: the release run for
|
||
|
|
bf6fe34028 |
chore(models): remove retired models from the built-in registry (#1939)
* chore(models): remove retired models from the built-in registry Check every built-in model catalog against the vendors' current model lists and retirement notices, and remove the models that are already shut down (DeepSeek, Qwen, Kimi, SiliconFlow, xAI, Tencent, Xiaomi, Doubao/Seed, Google image and Veo, and the Ark Agent Plan). Retired defaults are replaced with the vendor's current recommendation (for example `deepseek-flash`), and the Ark Agent Plan gains the replacements its migration notice lists. Models that are deprecated but still served stay in the catalog; the CHANGELOG lists their shutdown dates, the IDs that vendors still route to a successor, and the Qwen voice-clone limitation. The supported-models tables in all six languages are realigned with the catalogs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(models): keep retired DeepSeek Flash IDs resolving to deepseek-flash Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(models): resolve other vendor-routed retired IDs to catalog successors Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore: restore the App Releases section dropped while rebasing Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
fd5e1d4367 |
feat(web-fetch): add Firecrawl provider (#1931)
* feat(web-fetch): add Firecrawl provider * test(web-fetch): pin Firecrawl's post-redirect url as the final URL --------- Co-authored-by: wyuc <wang-yc24@mails.tsinghua.edu.cn> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
3d6fe7b6b3 |
feat(web-tools): add DeepSeek search and fetch providers (#1937)
* feat(web-tools): add DeepSeek search and fetch providers Add DeepSeek as a web search provider (POST /v1/tools/search) and a hosted web fetch provider (POST /v1/tools/fetch). Both reuse the `deepseek` chat credentials, following the existing Kimi wiring. - Search is opt-in: `WEB_SEARCH_DEEPSEEK_ENABLED=true`, an explicit `web-search.deepseek` entry, or an explicit `webSearch` slot in openmaic.yml. Adding DeepSeek for chat never assigns search. - Queries are truncated to 128 code points; `summary` is preferred over `snippet`. - Fetch keeps Kimi's timeouts and single transport-error retry; 403/404 surface as clear "cannot fetch" errors. - Official hosts normalize to /v1; a deployment-configured gateway base URL is preserved for both tools. - Docs (6 languages), .env.example, i18n provider names and tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(web-search): accept official workspace provider endpoints Reuse registry allowlists for workspace tool endpoint resolution, save validation, and model settings capabilities. Cover DeepSeek and Kimi official URLs with trailing slashes, reject custom endpoints, and preserve web fetch behavior. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
6760c2b764 |
refactor(chat): retire the legacy director-graph classroom chat (#1913)
* refactor(chat): move Pi's shared parser, action schemas and store-state type out of the legacy chat owners Pi classroom chat still imports three pieces from the legacy director-graph chat, which #1814 retires. Give each a Pi or neutral owner first, so the legacy files can later be deleted without touching Pi: - The structured-output parser (createParserState, parseStructuredChunk, finalizeParser, looksLikeStructuredFragment, ParseResult) moves verbatim from lib/orchestration/stateless-generate.ts to lib/chat/structured-output.ts. Only two comments change: they no longer name director-graph as the reader of the per-call ordered indices. This also stops the Pi route from loading director-graph and LangGraph through the parser's module. - lib/orchestration/tool-schemas.ts moves unchanged to lib/chat/pi/tool-schemas.ts. - AgentLoopStoreState moves unchanged from lib/chat/agent-loop.ts to lib/chat/store-state.ts; the Pi request path in use-chat-sessions uses it. The remaining legacy consumers import from the new locations until they are removed. No behavior change. Refs #1814 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(chat): cover classroom model precedence on /api/chat/pi with the real resolver The user-route, lock and body precedence for classroom interaction is covered with the real resolveModel only through the legacy /api/chat route, which #1814 removes. Route-level Pi tests mock resolveModel. Add the same four cases against /api/chat/pi, asserting the model handed to the Pi runtime: - a chat-adapter user route wins over the body model; - a locked classroom slot wins over the user route; - with no matching route, the body model is used; - a locked classroom slot is kept despite unlisted body and route models. Refs #1814 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(eval): run the whiteboard layout eval against Pi classroom chat The whiteboard eval drove the legacy /api/chat through runAgentLoop. Point it at /api/chat/pi, which #1814 keeps as the only classroom chat: - one Pi request per scripted user turn, with whiteboard tools enabled as the app does for in-class requests; - text and actions grouped by each agent's messageId and sealed into their own history message at agent_end, since one Pi request can hand the turn to several agents; - the previous turn's done.directorState carried into the next request within a scenario run, as the app does within a session; - an error event, a non-200 response, or a stream without done fails the scenario through the existing error path, which skips its remaining turns (previously an error event was swallowed and the turn still captured); - a native whiteboard event fails the run, because the harness cannot see the native child's server-side board. Not seeing one does not prove the server uses the legacy child; run the eval on a server configured for it. Scores are a new baseline and are not comparable with runs of the legacy runner. Scenarios, capture, scoring and reporting are unchanged. Refs #1814 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(eval): settle queued actions and cancel the request when a whiteboard turn fails Review of the Pi whiteboard runner (#1913) found two lifecycle gaps on the failure paths it added: - A turn that failed (an SSE error, a native whiteboard event, or EOF without done) returned and disposed the scenario without waiting for its queued actions. The state manager drives shared store singletons, so a pending action could finish inside the next scenario and land in its screenshot. Every turn exit now settles the action queue first. A queued rejection is handled while the stream is still open and is logged at settle time, as on the success path, without replacing the turn's own error. - Stopping early only released the reader lock, so the request kept running. Each turn's request now has its own AbortController, aborted on exit, and an unfinished response body is cancelled before the lock is released. runScenario is exported with its CLI settings passed in, and main() runs only when the file is the entry point, so an offline Vitest suite can exercise the real function: failed turns settle before returning, the native early exit aborts and cancels, a concurrent action rejection is not unhandled, and the success path keeps one Pi request per turn, messageId grouping, directorState carry-over and score:null on scorer failure. Refs #1814 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(eval): run the answering and answer-content evals on Pi; retire premature-end Both evals drove the legacy single-step director prompt and agent prompt, which #1814 retires. Run them on the real Pi director in process instead (eval/orchestration/pi-harness.ts): the Pi config helpers supply agent configs and budgets, whiteboard tools are on as for classroom requests, thinking is off, and the legacy child runtime is pinned. The harness skips the HTTP route, so route authorization and tool-capability checks are not exercised. - answering classifies by the first recorded call_agent attempt in the director tool trace: TEACHER, OTHER_AGENT (another or a non-existent agent), NO_DISPATCH (none recorded; wrong, kept in the denominator), or ERROR (a failed run, excluded as before). A later recorded attempt never rescues the first. - answer-content judges the full reply of the first recorded teacher attempt. A failed run, no recorded teacher attempt, or a first one that is skipped, marked isError or empty scores 0. The judge, opening window, threshold and all-samples denominator are unchanged. Pi's short teacher replies make the two metrics nearly coincide, and the score includes routing. - Both score only what the trace records. A schema-rejected attempt is not recorded, so a later one can score, and a legacy child's partial text after a provider failure is judged. Scores can be overstated. Real-chain tests (real Pi loop and agent SDK, scripted StreamFn) pin both limits. - The old prompt A/B variants are removed; results are a Pi baseline. - premature-end is retired: its single END decision has no Pi counterpart, and the close gate does not show a question was answered. - The three remaining eval scripts load with tsx --conditions=import, so ESM-only dependencies resolve. Refs #1814 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * refactor(chat): always run classroom chat on Pi and fail builds that still opt out The classroom chat hook, the /api/chat/pi route and PlaybackChromeRoot no longer read NEXT_PUBLIC_PI_CHAT_ENABLED. The hook sends every turn through the existing Pi single-request path; the frontend no longer calls the legacy /api/chat loop (fetchStatelessChat and the runAgentLoop tail are removed). The Pi branch itself is unchanged apart from indentation. isPiChatEnabled and its readDefaultOnBoolean helper are removed. The independent courseware-reference gate stays default-off. next.config.ts now exports a phase function. In the production-build phase it fails when NEXT_PUBLIC_PI_CHAT_ENABLED is set to anything other than '', 'true' or '1' (exact match), which covers every value that used to select the legacy runtime. The error names the value and points to the Classroom model setting, the google native preset for Gemini, and the administrator for managed configurations. Other phases do not check the flag. The fixed env pin for the flag is removed. This is an intermediate step of #1814 PR 3: the legacy route, director graph and agent loop are still present and are removed in a follow-up commit, and Docker/Compose wiring and docs still describe the old rollback. Refs #1814 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * refactor(chat): remove the legacy director-graph classroom chat backend The frontend has run every classroom turn on /api/chat/pi since the previous commit, so nothing reaches the legacy stack any more. Remove it: - app/api/chat/route.ts (no stub, redirect or 410; /api/chat/pi stays) - lib/orchestration/{stateless-generate,director-graph,ai-sdk-adapter, director-prompt,prompt-builder}.ts and lib/chat/agent-loop.ts - summarizers/{conversation-summary,message-converter}.ts - the director, agent-system and agent-system-wb-* templates, the speech-guidelines and whiteboard-reference snippets, and their prompt and snippet IDs Pi's default legacy child, the shared structured-output parser, the Pi tool schemas, the shared summarizers, the registry and the protocol types are unchanged. Dependency declarations are left for a follow-up commit. Tests: - Drop the legacy chat route from the model-authorization tests and the coverage matrix. The mixed compatibility cases keep their six and eight stage assertions, and the exhaustive resolver call-site scan is unchanged. The locked-classroom case now goes through /api/chat/pi. - Retire chat-route-user-routes (its precedence cases are rebuilt on the Pi route in route-model-precedence), the agent-loop async-state test, and the conversation-summary test. - Keep the #511 intent as a history input contract on Pi: toHistoryMessages keeps the human challenge as a user turn in order, and buildUserPrompt still reports it after a later agent reply. - Move the role, peer-context and language-directive prompt checks onto Pi's buildChildPrompt. Keep the PBL and placeholder-lint template tests and the getActionDescriptions LaTeX guard. - Add middleware cases for POST /api/chat (401 without access, pass-through otherwise) and a Playwright spec that expects a plain 404 from the running app. Refs #1814 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * build(deps): drop the unused @langchain/langgraph dependency The legacy director graph was its only consumer and was removed in the previous commit. Remove the root declaration and let pnpm update the lockfile: @langchain/langgraph and @langchain/langgraph-checkpoint are no longer installed. @langchain/langgraph-sdk stays (an optional CopilotKit peer and a direct dependency of @ag-ui/langgraph). @langchain/core is kept: CopilotKit requires it as a peer and pnpm would install it anyway. partial-json and jsonrepair are kept for the Pi parser. The re-resolution also moved vite 8.0.0's postcss from 8.5.15 to 8.5.23 (both were already in the lockfile; Next's postcss is unchanged) and shortened four eslint-import snapshot keys without changing versions. Refs #1814 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * build(docker): keep the Pi chat flag only as an input to the build check NEXT_PUBLIC_PI_CHAT_ENABLED no longer selects a chat runtime; next.config.ts only reads it to fail a production build that still opts out of Pi. Keep the builder ARG and the Compose build-arg forwarding so an explicit false still reaches that check, and drop the ENV line: build args are already visible to the builder's RUN steps, and the value has nothing to configure in the image. Remove the legacy-chat rollback comment and command from docker-compose.yml and replace the rollback section of .env.example with a short note that the legacy runtime is gone and which values now fail the build. Refs #1814 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs: describe classroom chat after the legacy runtime removal - Configuration docs (all six locales): drop the Pi rollback example, the advice to rebuild with the flag set to false and the Compose rollback command. Say instead that classroom chat always runs on Pi and needs a tool-calling Classroom model (google preset for Gemini), that the flag should be removed, which exact values a production build still accepts, and that the Compose service env_file supplies runtime values only. - READMEs: drop the LangGraph badge and describe lib/orchestration and the Pi director loop as they now are. - CHANGELOG: add the breaking change (model requirement, the flag, POST /api/chat answering 404 after the access gate) and the dependency removal. - lib/prompts/README.md: point the role and length guidelines at lib/chat/pi/prompts.ts, correct which tests check placeholders, use a missing snippet in the error example, and start the whiteboard eval server with the native child runtime off. - Remove the two comments that told CI and Playwright to leave the flag unset. Refs #1814 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(chat): pin the server key on a user-route model; document answering eval limits - route-model-precedence: when the user route switches the classroom model to another provider without a key of its own, assert that the model is built with the server key rather than the body's key. - answering eval: state in the header comment and the generated report that a run which throws, is aborted or ends without done is ERROR even after it dispatched an agent, that ERROR samples stay out of the correct-rate denominator, and what the rate therefore does and does not measure. The scoring rules are unchanged. Refs #1814 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: wyuc <wang-yc24@mails.tsinghua.edu.cn> |
||
|
|
d128ef67c9 |
fix(chat): save chats without Web Locks on insecure origins (#1929)
* fix(chat): save chats without Web Locks on insecure origins On plain HTTP at a non-localhost address (a LAN IP, a Tailscale IP or MagicDNS name) the page is not a secure context and navigator.locks is undefined. The chat partition lock still required it for the default store, so loading chats failed silently and every stage flush threw ChatStorageLockUnavailableError, retrying with backoff and re-uploading the document each time. The rule dates from when the default path also migrated and cleared a browser database shared across tabs. That migration is gone, and the isolated write mode already used without a shared mutex gives the same per-chat last-writer-wins result as the locked path. When Web Locks are missing, use it and log a one-time notice. Also include the error name and message when a WebKit stack lists only frames, and document the HTTP limitation in the deployment guide. Fixes #1800. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(logger): check for the Name: message header, not a substring A frame-only stack can contain the message by coincidence (a function named like it) and every stack contains an empty message. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(deployment): note that deletes win over concurrent edits without Web Locks Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
797d501367 |
feat(token-plan): let plans declare web fetch; Kimi Coding Plan takes over web fetch (#1927)
* feat(token-plan): support declared web fetch capabilities * fix(token-plan): take over implicit builtin fetch defaults * docs(token-plan): include web fetch in modality descriptions |
||
|
|
e003bd304b |
fix(generation): reject invalid shape rotations (#1891)
* fix(generation): reject invalid shape rotations Signed-off-by: jianghh <3232826884@qq.com> * fix(generation): report non-finite shape rotations * test(generation): format rotation regression * fix(generation): skip null generated elements --------- Signed-off-by: jianghh <3232826884@qq.com> Co-authored-by: wyuc <wang-yc24@mails.tsinghua.edu.cn> |
||
|
|
f86e1949dd |
feat(web-fetch): add webFetch capability slot with a provider registry (builtin, Kimi) (#1912)
* feat(web-fetch): add provider registry and capability slot * fix(web-fetch): protect defaults and unify capability execution * fix(web-fetch): preserve workspace credentials and reuse proxy agents * fix(web-fetch): retry transient Kimi transport failures * feat(settings): show web fetch inside the research station Draw the web fetch slot as a third line (fetch) of the research station instead of an unconnected station of its own, and describe it as the agent's page reader, since course generation itself only searches. - Offer the implicit built-in reader as the slot's server default, so the picker shows the same server-default row as with a configured provider. - Anchor slot pickers to their station card so an open picker never covers the card it belongs to. - Localize the picker's provider group label in zh-CN and zh-TW. * test(config): verify shared Kimi search and fetch capabilities |
||
|
|
941f68816d |
feat(web-search): add Kimi search with shared chat credentials (opt-in) (#1911)
* feat(web-search): add Kimi search with shared chat credentials * fix(web-search): require explicit Kimi search opt-in * fix(web-search): preserve search defaults after Kimi opt-in * fix(web-search): warn when Kimi opt-in needs a slot assignment |
||
|
|
4c0809b6b5 |
docs: v1.2.0 news, classroom export guide and complete upgrade notes (#1916)
* docs: announce v1.2.0 and add a classroom export guide - README / README-zh: replace the rc.1 news entry with the 1.2.0 GA entry (server-first is stable, classroom export), describe the new export formats in the highlights and the export table, point to the model authorization docs, and note the render-service upgrade order. - Getting started (all locales): new "Export a classroom" section covering PPTX with placeholder slides or slides only, the Resource Pack, offline HTML with or without narration, the ZIP used above 400 MB, the classroom ZIP, and opening an exported file on a phone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs: complete the 1.2.0 upgrade notes in every locale - Deployment (all locales): before the first start, list the models of providers with server-managed credentials, upgrade the render-service together with or before the app, and check the Pi classroom model (tool calling, native Gemini preset). The Vercel section no longer mentions a README Deploy button that no longer exists; the MP4 section notes the render-service upgrade order. - Configuration (all locales): document the tool_calling_required refusal of Pi classroom chat; translate the model authorization section, which was still in English in every localized page; add the GLM Image provider example missing from ja, zh-tw, ru and ar; fix a broken bold span in ja. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs: move the 1.2.0 date to 2026-10-16 and scope two statements - README / README-zh: the v1.2.0 news entry is dated 2026-10-16; the model list row applies to providers that select an upstream model. - Getting started (all locales): offline HTML keeps only the briefing of a project-based learning scene; continuing the project needs the online classroom and a network connection. - Deployment (all locales): the model list step applies to providers that send a selected model upstream; services without model selection, such as Tavily or a document parser, need no list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs: note unbundled assets in the offline HTML export Getting started (all locales): if the export reports assets it could not bundle, those parts of interactive scenes still load from the network, as the README already describes for classroom exports. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs: correct the unbundled asset note for offline HTML The standalone HTML's content security policy blocks remote URLs even when the device is online, so assets the export could not bundle do not show in the offline file; they remain available in the online classroom. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
d063ce6efd |
docs(generation): document shape rotation semantics [AI-assisted] (#1872)
* docs(generation): document shape rotation semantics * fix(generation): clarify optional shape rotation examples --------- Co-authored-by: wyuc <wang-yc24@mails.tsinghua.edu.cn> |
||
|
|
b5c83842d3 |
fix(pi): require Google native for official Gemini compatible route (#1897)
Co-authored-by: wyuc <wang-yc24@mails.tsinghua.edu.cn> |
||
|
|
ec176e84d4 |
test(renderer): give heavy inline-math typesetting suites room on loaded runners (#1907)
## Summary
The package release gate (`publish-packages.yml` → "Validate release candidate") runs the `@openmaic/*` package suites concurrently. The suites that typeset ~1,000 KaTeX formulas (the inline-math hard-cap cases) take ~0.3–0.4 s each locally but exceed vitest's 5 s default on a loaded runner: the release run for
|
||
|
|
fccbf82c24 |
fix(generation): parse data URLs without regex and cap vision image size (#1902)
## Summary Large or unsupported images attached to vision requests can crash prompt building or be rejected by the model provider, and a single bad image fails the whole generation step (retries fail the same way). - **`@openmaic/generation` 0.3.19**: `buildVisionUserContent` no longer runs a regex over the whole data URL. A new exported `parseBase64DataUrl` splits header and payload with plain string ops, so multi-megabyte payloads are never scanned by the regex engine. - **Vision image cap (app)**: new `prepareVisionImages` (`lib/server/generation/vision-images.ts`) runs right before every vision call — outline, scene content, scene actions, and the PBL evaluator (which receives uploaded submissions). - Pass-through only for single-frame, 8-bit sRGB/grayscale png/jpeg/webp/gif whose **base64 payload** is within `MAX_VISION_IMAGE_BASE64_BYTES` (1 MiB — providers measure the encoded payload) and whose longest side is within `MAX_VISION_IMAGE_DIMENSION` (2048 px). Pixels are strictly decoded first so truncated data is caught. http(s) URLs are untouched. - Everything else (oversized, animated, CMYK, 16-bit, unsupported formats) is decoded once with sharp (first frame, EXIF-rotated, resized inside 2048, flattened on white, sRGB) and encoded to JPEG, stepping quality down until under the cap. - Images that still don't fit or can't be decoded are dropped with a warning; the step continues. - Preparation runs where vision images are resolved (outline and scene-content pre-resolution), so the prompt's "[see attached]" placeholders and asset-id mappings only describe images that are actually attached. The PBL evaluator logs when an image submission is evaluated without its image. - Processing is sequential to bound peak memory. Non-goals: no change to material upload/extraction, prompts, or generation logic. ## Test plan - [x] `pnpm check`, `pnpm lint`, `npx tsc --noEmit` - [x] `@openmaic/generation` build + typecheck + tests (incl. an 8 MiB payload, malformed and non-base64 data URLs, http passthrough) - [x] New `tests/generation/vision-images.test.ts` (small untouched, large downscaled under caps, unsupported format converted, undecodable dropped while others kept, http untouched); updated scene-content / retry-boundary / evaluator tests - [x] Full `pnpm test` (Node 22) - [x] `node scripts/check-package-version-bumps.mjs origin/main` 🤖 Generated with [Claude Code](https://claude.com/claude-code) |
||
|
|
3c5c02f994 |
fix(renderer): cancel idle typesetting with its own pair and keep release-gate tests stable (#1901)
* fix(renderer): cancel idle typesetting with the pair that scheduled it whenIdle checked requestIdleCallback/cancelIdleCallback when scheduling but read cancelIdleCallback again when cancelling. If the global was removed or replaced in between (a test stub restored, a polyfill swapped in), unmounting a text element with pending inline math threw "scope.cancelIdleCallback is not a function", or handed the handle to an implementation that never issued it. Capture the request/cancel pair, and setTimeout/clearTimeout for the fallback, at schedule time and always cancel through the captured function. Make the inline-math regression tests fast and deterministic on a loaded runner without dropping what they pin: - Budget tests use distinct formulas padded with trailing spaces to 1,900 source characters. The budget counts source characters, so they cross it exactly like the old 1,357-character matrices, at a fraction of the typesetting cost. - The uncacheable-render test uses 40 radicals per formula: each render is still over the 64,000-character cache entry limit (asserted), several times cheaper than a large matrix. - Idle-time work runs through a stubbed idle queue that the test flushes, instead of polling wall-clock timers; a fake-timer test covers the setTimeout fallback. - The snapshot tests replace KaTeX with a trivial typesetter (real typesetting is covered by the element tests), use the minimum fixture that crosses the per-root cap (2 x 501 formulas), wait for the deferred unmount before restoring stubs, and count formulas only within the tree being measured. The [600, 600, 600, 600] measurement in the failed release run was a cascade: slideToPng timed out, kept running, and its off-screen tree was still in document.body when the next test counted roots across the whole body. Its deferred unmount then ran after the idle stubs were restored, which is what raised the unhandled TypeError. New tests cancel after cancelIdleCallback is removed or replaced, and after clearTimeout is replaced; they fail on the previous implementation. Bump @openmaic/renderer to 0.1.14 so the next publish run releases it (0.1.13 never reached the registry). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(packages): keep release-gate tests stable on a loaded runner The publish workflow runs every package's tests concurrently on one runner. Two more checks in that step failed when the suites were run under CPU contention: - The macro-safety tests in editor, generation and importer asserted that a render takes under 100 ms. On a loaded runner a guarded render can exceed that. Raise the ceiling to 1 s: the unguarded nestedDef expansion takes tens of seconds, a guarded render a few milliseconds, and the output-size and error checks that follow are what show the definitions were dropped. - Editor tests never unmounted their trees, because Testing Library only registers automatic cleanup when the runner exposes a global afterEach. React work still queued at the end of a file then ran after jsdom was torn down ("window is not defined"). Clean up after each test in the shared setup. Test-only changes; no package version bumps are required. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
90b2d90bca |
fix(security): enforce model authorization for server-managed providers (#1879)
Providers configured with server credentials only send model ids the deployment authorizes (explicit model list plus default/fallback/slot references for the capability); anything else gets the same HTTP 403 before the provider is contacted. Covers chat, verification, media, speech, transcription, model-based search, generation, agent, PBL, quiz grading and workspace assignments. Breaking change: credentialed providers without a model list accept only their default/fallback models. Co-authored-by: I3ob0 <huzi0404@163.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
adecc4847e |
fix(generation): stop retrying explicit provider quota refusals (#1861)
* fix(generation): stop retrying explicit provider quota refusals * fix(generation): review follow-ups for provider quota refusals - Leave a quota refusal the host classifies to the host, as documented for `classifyFailure`: the built-in rule (`isProviderQuotaRefusal`) applies only to refusals it does not answer for, at every retry site. - Name an exhausted quota in the fallback log line, from the failure that fired the fallback rather than an earlier attempt's. - Stop reporting a retry after the outline fallback returns empty output. - Drop the PBL loop-fallback change: a provider failure with an HTTP status already skips the loop, and no LLM adapter throws the native quota marker. `@openmaic/generation` stays at 0.3.18. - Document that an explicit quota refusal goes to the fallback at once (configuration, all six languages) and how it meets `classifyFailure`. - Test a 403 quota refusal falling back, a quota refusal the host classifies as retryable, and the stream error shapes the classifier reads. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(generation): persist quota refusal regression coverage --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: wyuc <wang-yc24@mails.tsinghua.edu.cn> |
||
|
|
8ad8a24e95 |
feat(media): add GLM (Zhipu CogView) image generation provider [AI-assisted] (#1832)
Co-authored-by: cham <2577781125@qq.com> |
||
|
|
e07e629261 |
fix(sanitize): store inline math as LaTeX source and typeset it in the client (#1829)
* fix(sanitize): keep inline math through the scene-content sanitizer The prose policy flattened the editor's inline formulas on every persistence read and write: it dropped data-inline-math, the MathML annotation, the layout SVG and KaTeX positioning, so saved formulas rendered broken and their LaTeX source was lost. Move the lift / sanitize / re-render approach from the standalone HTML export into lib/sanitize/inline-math.ts and apply it in sanitizeProseHtml, so the persistence boundary and the export share one implementation. It parses with parse5, so it needs no DOM and runs on the server and in the browser alike. Each formula is replaced by an empty source span before sanitizing, and every surviving source span is replaced afterwards by a fresh KaTeX render (trust: false); authored markup never bypasses the policy. Prose without a formula skips the parse and is sanitized byte-for-byte as before. Renders are cached by source, and pathological markup falls back to the plain policy instead of failing the read or write. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(sanitize): bound inline math rendering and detect encoded KaTeX classes KaTeX markup is 100-150x the size of its source and is regenerated synchronously on every persistence read and write, so one large formula could block the event loop for seconds and pin hundreds of MB in the render cache. - Render a formula only if its source is at most 2000 characters, and within a per-call budget of 16000 source characters and 1000 formulas. Anything else stays a source span showing its LaTeX as text, so nothing is lost and the editor still recovers it. Limits are counted in document order, never time, so repeated passes stay stable. - Bound the render cache by markup size (1 MB) and never cache renders over 32 KB. - Pre-check on `data-inline-math` or `annotation` instead of `katex`: element and attribute names cannot be written as character references, but a class value can, so an encoded `katex` class no longer skips the lift and loses its source. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(sanitize): store inline math as source and typeset it in the client Rendering formulas on the server made every persistence read and write run KaTeX on authored input, which user macros and long sources can turn into seconds of CPU per document. Store each inline formula as its LaTeX source instead and let the clients that display slides typeset it. - The prose sanitizer reduces each inline formula (span[data-inline-math], else span.katex with a TeX annotation, entity-encoded class included) to <span data-inline-math="SRC">SRC</span> and allows only that attribute. The source doubles as text for consumers that do not render math. A source over 2000 characters is kept as plain text. The pre-pass uses htmlparser2, the parser sanitize-html uses, so it is linear and sees the same element boundaries; prose without a formula marker is sanitized exactly as before. The server never runs KaTeX, and the parse5 lift, render cache and budgets are gone. - @openmaic/renderer typesets span[data-inline-math] in text, shape and table prose after injection (renderInlineMath / useInlineMath), with trust disabled, macro definitions blocked and bounded expansion. It also re-renders older content that still carries KaTeX markup. The app's slide renderer components use the same hook. Bump the renderer to 0.1.12. - The standalone HTML export ships source-only formulas, which the player's renderer typesets, and ships the math fonts when a slide has an inline formula. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(slide-renderer): keep cell markup intact when formatting table text formatText turned every space in a table cell into , including the spaces inside tags, which broke any cell markup with attributes. An inline formula in a cell was shown as its raw source instead of being typeset. Only format the text between tags. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(renderer): allow 1000 macro expansions when typesetting inline math A cap of 50 expansions rejects realistic long formulas: built-in commands such as \neq, \iff, \, and \dots each count, and a formula with a few dozen of them needs over 100. Macro definitions are blocked, so expansion stays linear in the source and 1000 is only a backstop. This matches the shared safe KaTeX options. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(sanitize): replace self-closing inline formulas in SVG and MathML once Inside SVG or MathML the parser honours `/>` and reports the close as implied while still on the opening token, so the replacement ended before the formula started and the original span stayed next to the stored one; the next pass then stored it again. End a formula no earlier than its opening tag. Adds SVG and MathML cases and fuzzes the pass for idempotency and formula shape. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(renderer): keep inline math typeset across re-renders React can rewrite `dangerouslySetInnerHTML` markup on a re-render even when the HTML string is unchanged, which put the stored source spans back after a move or resize while the effect, keyed on the HTML, did not run again. Typeset after every commit instead: formulas already typeset are skipped, and typeset formulas are cached by source and cloned, so a re-render costs a query and, at most, cheap clones. Typesetting never updates React state. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(renderer): budget inline math typesetting per prose root One slide packed with large formulas could block the page for hundreds of milliseconds on every mount. Typeset at most 4000 characters of uncached source or 100 uncached formulas per pass over a prose root before paint, and the rest in idle time, a chunk of the same size per idle period. The next commit, an unmount or new content cancels pending idle work. Past 50 000 characters or 1000 formulas per root, formulas are shown as their LaTeX text. Slide snapshots typeset everything before capture. Covers identical-content re-renders and A, B, A, A content sequences in both renderers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(renderer): keep inline math progress across commits and complete snapshots per root - Give injected prose a stable dangerouslySetInnerHTML value per markup string (text, shape label and each table cell, in both renderers), so React leaves unchanged markup alone. Typeset formulas and pending idle progress then survive re-renders; formulas too large to cache are no longer typeset again on every commit. The every-commit pass stays as a safety net. - Mark each prose root and complete snapshots root by root, so each text box keeps its own hard cap as on the live slide instead of sharing one slide-wide count. - Apply the hard cap from document order on every pass, whatever earlier passes typeset, and let a formula shown as text by an earlier cap be typeset once it falls within its root's cap. - Note that the render cache bound counts serialized characters. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(renderer): bump to 0.1.13 after rebase Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(renderer): typeset inline math through the shared safeKatexOptions Replace the local stand-in options (inert macro-definition commands, trust: false, maxExpand 1000) with safeKatexOptions from @openmaic/dsl, keeping the inline-specific settings (displayMode: false, output: html, throwOnError: false, strict: ignore). The shared helper's expansion budget is the same 1000, and it also keeps the built-in \tag/\notag state and makes \long inert. The math engine guard now lists the renderer's inline-math module as a render-calls site and drops the standalone HTML rich-text module, which no longer renders KaTeX itself. Tests: ordinary formulas typeset byte-for-byte as with the previous options, and formula-defined macros stay inert within one formula and across formulas in the same prose root. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(sanitize): keep over-long inline formulas as formulas; bound typesetting only The 2000-character bound dropped the data-inline-math marker at save time, so an over-long formula became plain text for good. The bound now applies only where formulas are typeset: the slide renderer already shows an over-long source as text, and the editor's inline_math node now does the same instead of typesetting it, using the renderer's MAX_INLINE_MATH_SOURCE. @openmaic/editor 0.0.11. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(sanitize): a 100 KB formula is kept as a formula in the node-environment suite Follows the sanitizer change: the length bound applies to typesetting only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
8c3a90d553 |
fix(storage): support path-style S3 addressing (AI-assisted) (#1849)
Adds an opt-in `AWS_S3_FORCE_PATH_STYLE` (`true` or `1`) that sets the AWS SDK v3 `forcePathStyle` client option for the S3 asset byte store, so S3-compatible stores such as MinIO and Ceph can be addressed as `endpoint/bucket/key`. Unset keeps the existing Amazon S3 behaviour. Bumps `@openmaic/storage` to 0.37.3. Fixes #1686 Co-authored-by: weinaike <13814354+weinaike@users.noreply.github.com> |
||
|
|
dbb0e3a286 |
Preserve rotation for generated slide shapes (#1855)
* fix preserving generated shape rotation * bump generation package version * fix generation rotation check formatting --------- Co-authored-by: wyuc <wang-yc24@mails.tsinghua.edu.cn> |
||
|
|
a922dea2de |
fix(storage): bound DocumentStore HTTP requests with a deadline (#1790)
* fix(storage): bound DocumentStore HTTP requests with a deadline HttpDocumentStore issued every request without a deadline, so a request whose peer never answers held its promise forever. The stage autosave keeps at most one save in flight (startFlushRound's flushInFlight guard) and starts the next one only once that promise settles, so a single stalled save silently stranded every later save for the life of the page — generation and the editor kept working from the in-memory store, and the loss only surfaced on reload. Bound the request round trip — sending the body and receiving the response headers — with an AbortController deadline (requestTimeoutMs, default 30s, <= 0 disables). A stalled request now rejects with HttpDocumentStoreError(0, 'HTTP_REQUEST_TIMEOUT'), which the autosave's existing backoff already retries. This mirrors the budget HttpAssetStore applies via probeTimeoutMs / startBoundedOperation. Reading the response body stays outside the bound: a large document on a slow link is slow, not stalled. Co-Authored-By: Claude Code <noreply@anthropic.com> * docs(changelog): describe the request budget's fixed throughput and ceiling The throughput and ceiling are module constants, not HttpDocumentStore options; only requestTimeoutMs is configurable. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Code <noreply@anthropic.com> Co-authored-by: wyuc <wang-yc24@mails.tsinghua.edu.cn> |
||
|
|
472b26d0d5 |
fix(math): disable formula-defined macros in KaTeX and Temml rendering (#1827)
* fix(math): disable formula-defined macros in every KaTeX and Temml render Add safeKatexOptions to @openmaic/dsl, the one package every renderer, importer, editor and the app already depend on. It merges hardened settings into each caller's options: macro-defining commands (\def, \gdef, \edef, \xdef, \global, \long, \let, \futurelet, \newcommand, \renewcommand, \providecommand) become inert macros that consume the definition, trust is forced off, maxExpand is pinned, and a fresh macros object is built per call so nothing persists between renders. Caller options and caller-supplied macros are kept. Route every render through it: whiteboard and slide latex elements, quiz math, standalone HTML inline math, PPTX export via Temml, the editor's latex dialog and inline math node, generated latex elements, and the importer's formula paths. Keep the importer's node-globals rollup plugin off the dsl build, whose old parser cannot read `??`. Tests cover each render path with nested-definition inputs, a corpus of legitimate formulas that must render byte-identically, \gdef isolation, and a guard that fails if a new KaTeX/Temml call skips the helper. Bump @openmaic/dsl 0.11.3, editor 0.0.10, generation 0.3.16, importer 0.3.1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(math): harden workbench chat math and newcommand parsing Workbench chat Markdown rendered math through @streamdown/math, which only forwards errorColor to rehype-katex. Add createSafeMathPlugin, which keeps that plugin's remark side and rehype-katex instance but replaces the rehype options with safeKatexOptions, and use it in the chat text block. Rework the inert \newcommand family: peek at unconsumed tokens so a body written as {[} stays a body, accept the starred form, skip [n] and [default] groups with brace-aware scanning, then consume exactly one replacement body. Document that caller-supplied macros are trusted code and must not be derived from content. Replace the call-text coverage check with an import-aware guard built on the TypeScript parser. It finds every runtime import of a math engine (default, aliased, named, namespace, side-effect, import = require, re-export, dynamic import, require) plus injected auto-render script text, and requires each file to be on a reviewed allowlist. Files that import KaTeX or Temml directly must use them only as render calls with safeKatexOptions(...). The interactive post-processor is allowlisted: its page already runs model-written scripts in a sandboxed iframe. Fixtures cover each bypass shape. Add KaTeX and Temml regression tests for the newcommand edge cases, and the workbench chat path to the expansion-input suite. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(math): fresh macros per chat formula and stricter render guard KaTeX writes built-in state into the macros object while rendering (an align environment sets \@eqnsw), and rehype-katex spreads one options object into every render. The workbench chat plugin shared one macros object, so that state leaked between formulas and between messages. Make macros an enumerable getter that returns a fresh hardened object on every read, so each render and each error retry gets its own. Add cross-formula and cross-message regression tests. Tighten the guard for files that import KaTeX or Temml directly: any engine reach other than a static default or namespace import (require, dynamic import, re-export, import = require, side-effect import) is rejected; the options argument is checked at each method's own position with nothing after it; and it must be a call to safeKatexOptions imported from @openmaic/dsl, not a local look-alike. Document the guard's scope: module imports only; global access, engine code inside other HTML strings and require.resolve need review. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(math): keep built-in equation numbering with macro definitions disabled KaTeX and Temml implement \tag, \tag*, \nonumber and \notag as built-in macros that expand to \gdef\df@tag{\text{...}} and \gdef\@eqnsw{0}. Swallowing every \gdef therefore dropped equation tags and stopped \nonumber / \notag from suppressing align/gather/equation numbers. The inert \gdef now accepts exactly those two built-in shapes and stores them the way the engines' own \gdef does; every other \gdef, and every other definition command, stays inert. '@' is a letter in both lexers, so formulas can name these macros directly; the allowed shapes add nothing \tag* and \nonumber do not already provide: - \@eqnsw may only be set to 0; - \df@tag may only be one \text{...} group that never mentions \df@tag, so the tag is expanded exactly once (a self-reference would recurse until the call stack or the expansion budget runs out, as it does in the stock engines on \tag{\df@tag}). Tests: tagged and \notag/\nonumber formulas render identically to stock KaTeX (html, mathml, htmlAndMathml) and Temml; the slide element, quiz, editor dialog and Workbench chat renderers show tags and suppress numbers; definitions inside tags, self-referencing tags, nested tags and non-built-in \df@tag/\@eqnsw shapes stay inert. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(math): expand a tag in full only once per accepted definition A formula can name \df@tag itself, so a long \tag*{...} (or an accepted \gdef\df@tag{\text{...}}) followed by many \df@tag mentions re-expanded the whole tag on every mention, up to the expansion budget: about 12 KB of input produced several MB of output. An accepted \df@tag is now stored as a macro that yields its body on the first expansion and an empty \text{} afterwards. The engines expand \df@tag once per formula, or once per align row before clearing it, so tags render unchanged (stock-equality tests, including an align with a tag on several rows, stay green in KaTeX and Temml). The empty \text{} rather than nothing avoids a Temml TypeError on an empty tag. Also document, and test through the PPTX export, that Temml throws a TypeError on a script left bare by an inert definition (x^\notag); the only Temml consumer catches it and returns null. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(generation): bump to 0.3.17 after main took 0.3.16 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
32f592377b |
fix(test): normalize Windows path separators and replace shell grep in test suite (#1642) (#1828)
* test: normalize Windows path separators and replace shell grep in test suite (#1642) * ci: re-trigger checks --------- Co-authored-by: cham <2577781125@qq.com> Co-authored-by: wyuc <wang-yc24@mails.tsinghua.edu.cn> |
||
|
|
07299672c4 |
fix(generation): require explicit state publication and initialize game state (#1795)
* fix(generation): require explicit state publication and initialization * fix(generation): bump package version to 0.3.16 * test(generation): stop old worker before seeding recovery checkpoint |
||
|
|
8b451a33bf |
fix(renderer): repaint clipped chart series on WebKit (#1825)
ECharts reveals line series by growing an SVG clip path from a sliver to the full plot width. WebKit keeps painting the clipped group as it was on the first, nearly empty frame, so the points and labels show and the line does not. Writing the clip shape's attributes again, even with the same values, makes WebKit repaint the group. On WebKit the chart element now re-sets the attributes of the shapes inside its clip paths after every rendered frame. Animations stay on for every browser; Chromium, Firefox and charts without clip paths are left untouched. The standalone player keeps rendering charts without animation. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
a3c17b6116 |
feat(generation): host hooks for server-side generation runs (#1807)
* refactor(server): share the host hook registration checks Move the misspelled-hook detection, the "did you mean" hint and the bound-once hook reads out of the persistence hooks registry into lib/server/host-hook-registration.ts, so another host hook registry can validate its registrations the same way. No behavior change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * feat(generation): host hooks for server-side generation runs Add configureGenerationRunHooks, registered once from instrumentation.ts register() like the persistence hooks, for a host that meters usage, enforces a quota or keeps an audit trail around course generation: - authorizeStart: admits or refuses a start on POST /api/generation-runs and POST /api/generate-classroom, after every built-in check, inside the create transaction; a refusal answers with the host's status, code, message and headers, and no run is created. Attributes it returns are stored on the run (generation-runs migration 5, host_attributes JSONB). - wrapExecution: runs every claimed execution of a run (first claim, takeover, the claim after a Retry or an outline confirmation, media-only executions) and each background material extraction inside the host's context, with the run's stored attributes. A wrapper that refuses pauses the run at its step (Retry resumes it) or fails the extraction. - classifyFailure: maps a host error to a stable code and says whether an automatic retry is worthwhile; consulted before the step retries, the outline stream's retries, the model fallback, media failures and extraction failures. A non-retryable host failure pauses the run at the step; the AI SDK's own retries of a retryable provider status stop at it too (callLLM and streamLLM put every model they hand the SDK, v2 or v3, and any model a prepareStep picks, behind a gate that raises it again as not retryable; frozen models included), callLLM's own retries stop at it and throw it rather than an earlier invalid result, and an outline stream that fails with it is not accepted on its partial outlines. - onRunEvent: best-effort notifications after committed transitions (started, outline-ready, scene-appended, paused, completed, ended), in commit order within a process, each with the stored ownerId and the currentOwnerId the run was claimed into since (looked up for at most 5 s; at most 1000 notifications queue per process, newer ones dropped with a counted warning); never awaited, and a failing listener never affects the run. With nothing registered every path behaves as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
636fab0d7e |
release: OpenMAIC 1.2.0-rc.1 (server-first) (#1794)
* ci: run CI for the provider-config integration branch
Development of the provider configuration RFC (#1701) lands on
integration/provider-config; build it on push and run CI for pull
requests into it, as with earlier integration branches.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* feat(config): capability slot registry and stage-to-slot mapping (#1726)
* feat(config): capability slot registry and stage-to-slot mapping
First P0 step of the provider configuration RFC (#1701, tracked in
#1725): define the capability slot forest and map every LLM stage key
to exactly one slot. Pure data with no callers yet, so there is no
behavior change.
Requirements are checked on the slot that declares them and are not
passed down to child slots, so agent.title can use a model without
tool calling even though agent requires it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* test(config): pin every stage destination and the capability roots
Review found that the station and root assertions derived their
expectations from the module under test: re-pointing a single-stage
station or dropping a capability root still passed. The tests now
compare against an independently written stage table and root list,
and pin agent.title as config-only. Also document that browserless
outlines still run on the generate-classroom model.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* test(config): pin slotForStage and full slot lineages
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* feat(config): provider presets and the openmaic.yml schema (#1727)
* feat(config): provider presets and the openmaic.yml schema
Second P0 step of the provider configuration RFC (#1701, tracked in
#1725).
- lib/config/provider-presets.ts: one preset per built-in registry
entry, plus the token plans as multi-capability presets whose stage
recommendations become slot recommendations. Registry ids that
collide across capabilities get explicit preset ids.
- lib/server/model-config/openmaic-yml.ts: parse and validate the
operator's openmaic.yml (or the file named by OPENMAIC_CONFIG):
${VAR} interpolation, strict schema, and cross-checks that every
assignment names a declared provider whose preset offers the slot's
capability. Every problem is reported with its path.
- instrumentation.ts: an invalid file refuses to start. Without a file
nothing changes, and nothing resolves models through the file yet.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* fix(config): harden openmaic.yml validation after review
- Look providers up by own key only, so "constructor:m" is not taken
for a declared provider.
- Refuse non-mapping objects YAML produces (an unquoted timestamp
becomes a Date that the schema would accept as an empty object), and
refuse a YAML alias that refers back to itself instead of overflowing
the stack.
- Accept lowercase variable names; refuse a "${" with no closing
brace, checked on the text as written, never on substituted secrets.
- Cross-check the entries that are valid on their own even when the
schema rejects others, so every problem is reported at once without
duplicate errors for declared-but-invalid providers.
- Name the three valid assignment shapes when a value has none of them.
- Test the boot path: an invalid file exits with code 1 before any
schedule starts; a valid one boots.
- Ignore a root openmaic.yml in git.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* fix(config): keep secrets out of openmaic.yml diagnostics
Review round 2:
- Read only variables the environment itself has, as non-empty
strings: ${constructor} or an inherited value is not a variable.
- Never print a value that came from ${VAR}, and report YAML syntax
errors by reason and position without js-yaml's source excerpt,
which can quote a literal key.
- Keep the base URL requirement on presets: SearXNG from its registry
entry, and Azure OpenAI and self-hosted MinerU, which have no usable
default endpoint.
- Check slot names and valid model references even inside an entry
that fails the schema, and report a failed placeholder once rather
than again as an empty value.
- Boot test for the no-file case.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* refactor(config): validate openmaic.yml in two phases
Rounds 1-3 of review kept finding edge cases in one feature: running
the cross-checks on the half-valid parts of a file the schema had
rejected, so that every problem showed at once. It hid problems inside
a rejected entry, lost a __proto__ slot key, and built misleading
provider errors from failed placeholders. That feature is gone.
Validation now runs in two phases. Phase 1 is the document itself:
placeholders, key names (checked on the document as written, since the
schema drops a __proto__ key), and the schema. Any problem there stops
before phase 2, the references between entries, which therefore only
ever sees a fully valid file. Each phase reports all of its problems,
one per path.
YAML syntax errors now report only their position: js-yaml's reason
can quote source text too (an alias or tag name), not just its excerpt.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* feat(api)!: generate-classroom takes requirement + uploaded materials; capabilities follow server config (#1728)
Narrows POST /api/generate-classroom to { requirement, materialIds? }; capabilities follow server configuration; materials go through the owner material library (upload, reference by id, delete); new GET /api/generate-classroom/capabilities; skill docs updated.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* feat(config): resolve a slot through the configuration layers (#1729)
* feat(config): resolve a slot through the configuration layers
Third P0 step of the provider configuration RFC (#1701, tracked in
#1725). resolveSlot walks from a slot to its capability root and
returns the first assignment it meets, consulting the deployment layer
(openmaic.yml, locked) before the workspace layer at every node. An
explicit null disables the subtree; nothing assigned up to the root is
unassigned, with no fallback to any vendor. The result carries the
provider, preset, registry entry, effective base URL, key, model, call
options, fallback, where it was resolved and whether it is locked, and
the requested slot's own requirements checked against the model
catalogue (met, unmet or unknown).
Pure and uncalled for now, so there is no behavior change.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* fix(config): lock only written slots and trust the catalogue only where it applies
Review round 1:
- locked now means the requested slot itself is written in the
deployment layer. Inheriting a deployment value does not lock a slot,
since the workspace may still assign it (source and resolvedAt still
report where the value came from).
- A custom OpenAI-compatible endpoint borrows the OpenAI registry for
transport only, so its preset no longer trusts that model catalogue:
requirements there resolve to unknown.
- The fallback is checked against the slot's requirements too, and the
result exposes fallbackRequirements so retries can refuse it.
- A malformed reference fails with a path-qualified SlotResolutionError
that does not echo the value, which is often a misplaced key.
- Requirement tests use named catalogue models instead of picking one
from the catalogue at run time.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* fix(config): order layers deployment-first and keep references out of errors
Review round 2:
- resolveSlot no longer depends on the order its caller passes the
layers in: deployment layers always come first, for assignments and
provider lookup alike.
- Resolution errors name the path and the preset, never a value taken
from the reference, so a key pasted into the provider position does
not end up in a log.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* test(config): cover catalogue aliases and fallback capability errors
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* feat(classroom)!: save server-generated classrooms through server persistence (#1730)
Server-side classroom generation saves the finished course create-only into the request owner's library with media in the owner's asset pool; jobs move to PostgreSQL with owner-scoped polling; /api/classroom is removed; legacy data/classrooms files are imported once in the background. Adds @openmaic/storage 0.36.0 PgAssetStore.releasePending.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* feat(config): translate the legacy configuration into a deployment layer (#1731)
* feat(config): translate the legacy configuration into a deployment layer
Deployments without openmaic.yml keep working: provider variables,
server-providers.yml, DEFAULT_MODEL, MODEL_ROUTES and MODEL_FALLBACK are
translated into the openmaic.yml shape and serve as the deployment layer
for resolveSlot.
- Providers: each configured entry becomes a provider under its preset
id; force-disabled entries are left out; AliDocMind's key pair goes
into credentials.
- DEFAULT_MODEL goes on the llm root. Every other slot that serves stages
gets what those stages used before (their route, or else the default
model), written only where inheritance would give something else, so
an unrouted stage under a routed parent stays on the default model.
- Stages that now share a slot but had different routes, models whose
provider has no server configuration, and stages that used the
browser's model but would now inherit a server one become startup
notices, never failures.
- MODEL_FALLBACK attaches to every chat assignment without its own.
- When openmaic.yml exists it wins, with a notice if legacy variables
are also set.
Nothing reads the layer yet; routes switch over in P1 (#1725).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* fix(config): follow the agent driver's rules and keep notices value-free
Review round 1:
- The agent never used DEFAULT_MODEL: it needs a valid maic-agent-driver
route and is off otherwise, so the translation writes agent: null where
it would inherit a server model (and a notice for a route that does
not work today). Unrouted conversation titles reuse the driver's model
with thinking off, as the title generator does.
- Notices name registry ids only; a credential pasted into a model
variable is never repeated.
- Provider entries and route options are checked against the new schema
and left out with a notice (field names only) instead of producing a
file that would not parse; driver-only options are dropped elsewhere.
- A route with its own fallback never falls back to MODEL_FALLBACK, even
when that fallback cannot carry over; the retry model is part of the
comparison with the inherited value.
- Force-off switches without a configured entry are reported, a legacy
configuration made only of them is detected, and translating one adds
a deprecation notice.
- loadDeploymentLayer reads the process environment and working
directory like the legacy loaders, instead of taking parameters it
could only partly honor.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* fix(config): compare routes by behavior, validate references, name only known ids
Review round 2:
- Stages sharing a slot are compared by what the route changes for them
(model, thinking, fallback), with bare ids read as openai models and a
route to DEFAULT_MODEL counted as no route; api and contextWindow are
inert outside the driver.
- A model reference carries over only when it names a provider from the
providers section and forms a valid reference.
- Section keys and force-off ids are named in notices only when they are
registry ids with a preset.
- Retries now follow the slot; where a call site picked its retry model
by another label (scene types under scene-content, browserless
generation), the change is reported.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* fix(config): chat references need a chat entry; one notice for retries
Review round 3:
- A model reference carries over only when its provider was translated
from the providers section, not merely declared by another section
under the same id.
- Routes are compared by the retry model that takes effect, so leaving
out a fallback equals repeating MODEL_FALLBACK.
- The per-call-site retry notices kept missing cases (streaming and
calls outside server-managed routing never retry today). They are
replaced by one notice, given whenever a retry model is configured,
that retries now follow the slot.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* refactor(config)!: translate only providers and the default model (#1732)
* refactor(config)!: translate only providers and the default model
MODEL_ROUTES does not map one to one onto slots: several stages share a
slot, the agent driver and conversation titles have rules of their own,
and retries are picked by call-site labels. Emulating that took most of
the translation and still ended in notices that are easy to miss.
The translation now carries over only the unambiguous part: providers,
DEFAULT_MODEL as the llm root and MODEL_FALLBACK as its fallback (the
agent stays null, as it never used DEFAULT_MODEL). A deployment that
sets MODEL_ROUTES without openmaic.yml gets LegacyRoutesError asking it
to write the per-stage models as slots. loadDeploymentLayer is not wired
into startup yet; that happens when routes switch to resolveSlot (P1).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* fix(config): say what a dropped MODEL_FALLBACK loses
Without DEFAULT_MODEL there is no assignment to hold MODEL_FALLBACK, and
calls that retried on it (server providers picked in the browser) stop
retrying; the notice says so. thinkingSchema is module-private again.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* feat(persistence): workspace model configuration with keys encrypted at rest (#1733)
* feat(persistence): workspace model configuration with keys encrypted at rest
The store behind the web settings of RFC #1701 (#1725, P1): one row per
workspace (owner) in workspace_model_config, the same shape as
openmaic.yml without policy.
- Provider secrets (apiKey, credentials) are sealed per provider with
AES-256-GCM under OPENMAIC_SECRET_KEY, bound to the provider id, and
never stored in the config column. Without the variable, a secret is
created once in data/instance-secret.key (the Docker volume).
- A secret sealed under another instance secret is reported as
unreadable ("enter again"), and a save that brings no new secret for
that provider keeps it, so a misconfigured secret cannot destroy keys.
- Saves replace the document with a compare-and-swap on the revision,
after the owner's identity lock; two concurrent first saves cannot
both land (PostgreSQL contract test).
- A claim moves the anonymous configuration to the account unless the
account has its own (core participant, order 900).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* fix(persistence): publish the instance secret atomically; force the races in tests
Review round 1:
- The generated secret is written and flushed under a private name,
then published with an exclusive link, so no process can read it half
written and exactly one of two starting processes creates it. A file
that is not a complete generated secret (empty, truncated) is refused
instead of deriving a key anyone could compute.
- The PostgreSQL test holds both first saves at their insert until both
have read the missing row, and holds the row lock for the update case
until both saves queue behind it (checked by backend pid, not by any
lock waiter in the database).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* fix(persistence): verify the written secret; require full GCM tags
Review round 2:
- The generated secret is written in full, read back and checked before
it is published; the temporary file is removed on any failure.
- Sealed values open only with a 12-byte IV and a full 16-byte tag
(authTagLength), so a shortened tag cannot weaken authentication.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* feat(config): resolve slots at request time over deployment, workspace and defaults (#1734)
* feat(config): resolve slots at request time over deployment, workspace and defaults
The runtime half of RFC #1701 resolution (#1725, P1):
- deploymentConfig(): the deployment layer, loaded once per process.
The legacy translation now splits into the deployment's providers and
a separate default layer (DEFAULT_MODEL, MODEL_FALLBACK) that locks
nothing and ranks below the workspace, as DEFAULT_MODEL ranked below
the model a user picked.
- workspaceLayer(owner) reads the web settings; requestWorkspaceId(req)
names the request's owner (none for an owner minted by the request).
- lookupSlot walks deployment and workspace over the whole tree first;
the defaults are a second walk, so a default on a child never outranks
a workspace choice higher up.
- resolveStageModel builds the language model: the configured slot, else
what the request still names the old way (deprecated), else the
defaults, else a loud error; a slot turned off fails whatever the
request names. A workspace provider's endpoint is checked like a
caller-supplied one and gets the transport that refuses redirects.
- resolveSlot gains the default source, and reports which layer declared
the provider, its proxy and credentials.
Nothing calls it yet; call sites switch next.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* fix(config): keep request identity and workspace endpoints inside their bounds
Review round 1:
- A refused owner credential throws InvalidOwnerCredentialError (401)
instead of resolving with the deployment's models and keys.
- A retired request owner gets no workspace: canonicalizing it would
hand an old anonymous cookie the claiming account's settings. Only
background work, which names a stored owner, is forwarded.
- A workspace provider may not be Amazon Bedrock (which falls back to
the server's AWS credential chain) or set a proxy (which routes around
the checked, redirect-refusing transport); the deployment still may.
- Test seams for the deployment config and the workspace loader, and
tests for identity, forwarding and caching.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* fix(config): read only the named owner's settings; refuse unmet requirements
Review round 2:
- workspaceLayer reads exactly the owner it is given. Forwarding through
a claim let a request whose owner was claimed between its check and the
read see the account's settings; background work passes the owner it
works for now instead.
- A model the catalogue says does not meet the slot's requirement is
refused before anything is built (SlotRequirementError), without
consulting the request.
- Tests: a database failure fails the call without falling back, a
workspace provider without a key never gets the deployment's, and the
transport each provider source gets.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* test(identity): exempt the model settings lookup from cookie forwarding
requestWorkspaceId resolves the owner only to pick whose model settings a
generation call uses, and returns no response of its own, like the
vision prompt helper already listed.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* feat(config)!: resolve every LLM call through its capability slot (#1735)
* feat(config)!: resolve every LLM call through its capability slot
The LLM call sites of RFC #1701 switch to slot resolution (#1725, P1):
- resolveModel resolves a stage through its slot for the request's or
job's workspace: the deployment and workspace configuration first; the
model and key a request names (x-model, x-model-routes, body fields)
only for a slot left unassigned, deprecated; then the defaults an
older deployment set with DEFAULT_MODEL. Routes that read headers get
this through resolveModelFromRequest; the chat routes pass their
workspace; background work (agent runs, titles, generation jobs)
passes the owner it works for now.
- Retries follow the slot: a slot-resolved model carries its slot's
fallback (lib/ai/model-fallbacks.ts), which callLLM and the outline
stream use; only a model from the request path still retries on
MODEL_FALLBACK. A fallback that cannot meet the slot is not used.
- The agent driver resolves the agent slot: tool calling required,
api defaults to openai-completions, thinking.effort still refused.
Conversation titles resolve agent.title with thinking off unless the
title slot sets it.
- /api/generate-classroom resolves each step through its slot for the
job's owner, its outline through course.outline.
- MODEL_ROUTES is gone: loadDeploymentLayer runs at startup and a server
that still sets it without openmaic.yml refuses to start. The
pbl-chat and maic-agent stage keys, which nothing resolved, are removed.
BREAKING CHANGE: MODEL_ROUTES is no longer read; write per-stage models
as slots in openmaic.yml.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* fix(config): a slot fallback needs no serverManaged stamp; follow claims per stage
Review round 1:
- callLLM arms a model's attached slot fallback whether or not the caller
passes serverManaged (the PBL agents pass none); the stamp still gates
MODEL_FALLBACK on the request path.
- /api/generate-classroom resolves the owner the job works for now at each
stage, so stages after a claim follow the moved settings.
Streaming calls (agent driver, classroom chat, PBL streams) still do not
retry on a fallback model, as before this change; that is the #1725 item
on retries at every call site.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* feat(config): resolve media and tool capabilities through their slots (#1737)
* feat(config): a provider-only reference names the provider's default model
Search and document providers mostly have no model to pick, so a slot
may name just the provider (`webSearch: tavily`); the target then has no
modelId and the adapter uses its default. Chat slots still need
providerId:modelId, checked in openmaic.yml and at resolution.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* feat(config): resolve media and tool capabilities through their slots
The capability routes and server paths of RFC #1701 (#1725, P1): text
to speech, speech recognition, images, video, web search and document
extraction resolve through their slots, like language models.
- lib/server/model-config/media.ts: the configured slot (deployment,
then workspace); else the provider a request names the old way
(deprecated); else the legacy defaults; else a loud error. A slot turned
off fails whatever the request names, and while the legacy
<CAP>_<VENDOR>_ENABLED=false switches are in effect a switched-off
provider stays off whoever assigns it. A workspace endpoint is checked
like a caller-supplied one and may not use a proxy.
- The legacy translation assigns the media roots the provider the server
picked when a request named none (first configured; web search by its
old priority; DEFAULT_IMAGE_PROVIDER for images), with the first pinned
model.
- Routes: /api/generate/{image,video,tts,voice}, /api/transcription,
/api/web-search, /api/parse-pdf and /api/extract-document. A TTS voice
applies only to the provider it was chosen for; voices register on the
tts slot's provider.
- Server paths: agent image and video generation, scene narration, the
voice catalog and registration, web search and fetch_url, material
extraction (the document slot's service, the asr slot for local
transcription), browserless classroom media, and the generation
capabilities reported by /api/health and the classroom capabilities
endpoint.
- A provider-only reference (`webSearch: tavily`) names the provider's
default model; chat slots still need providerId:modelId.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* fix(config): keep slots authoritative on every media path
- Workspace providers reach media, search and document services only at
their preset's endpoints; a custom endpoint or proxy is deployment-only
(403 INVALID_URL).
- A configured or turned-off document slot decides the extraction service:
deprecated request fields may only pick a self-contained extractor, and
legacy operator credentials are no longer reached.
- Request paths resolve their own workspace without following a claim;
background extraction still does.
- A configured TTS slot keeps its own model; legacy pins apply only on the
deprecated and default paths.
- Local transcription and agent voice registration keep the connection's
network policy flags.
- The agent's web search forwards the whole resolved configuration.
- An unusable DEFAULT_IMAGE_PROVIDER leaves the image slot unassigned with a
notice instead of switching vendors.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* fix(config): public presets only for workspaces, plan default models
- A workspace preset whose default endpoint is on the server's own network
(self-hosted TTS, ASR, image) is deployment-only, and a workspace
provider's endpoint runs under the public-only policy.
- A provider-only reference to a token plan means the plan's own default
model for that capability.
- On the legacy default provider, the request's image, video and ASR model
still applies through its allowlist, and image/video without a model is
still MISSING_MODEL.
- An asr assignment a workspace may not use no longer blocks document
extraction, and a refused document service answers 403.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* fix(config): keep legacy search and voice choices on their old paths
- Classroom search honours the provider and key a request names while the
webSearch slot is unassigned; only /api/web-search prefers the operator's
configured backend, as before.
- A TTS request's voice applies unless the request chose it for another
provider.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* fix(config): legacy search model and capability discovery errors
- On the legacy default search provider, the request's search model still
applies through the server's pins.
- Capability discovery answers a refused credential (401) or a workspace
service it may not use (403) instead of 500.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* fix(config): classroom submission refuses a workspace service with 403
A classroom submission whose materials would go to a document or speech
service the workspace may not use answers 403 INVALID_URL instead of 500, and
its material check resolves the request's own workspace without following a
claim.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* fix(config): workspace image and video providers run public-only
A workspace-configured image or video provider now uses the strict public
transport for its requests and for the redirects its clip download follows,
whatever ALLOW_LOCAL_NETWORKS says; the operator's own providers and the
deprecated per-request path keep their policies.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* Revert "fix(config): workspace image and video providers run public-only"
This reverts commit
|
||
|
|
6bfdfa989e |
fix(quiz): reject duplicate option values during generation (#1713)
* fix: reject duplicate quiz option values * fix: guard quiz rendering against malformed content * fix(quiz): internationalize invalid content warning * test(quiz): cover malformed playback content * chore(generation): bump package version * fix(quiz): address maintainer review --------- Co-authored-by: wyuc <wang-yc24@mails.tsinghua.edu.cn> |
||
|
|
5312c2b4b4 |
feat(config): openmaic.yml, capability slots and server-side model configuration (RFC #1701) (#1765)
* ci: run CI for the provider-config integration branch
Development of the provider configuration RFC (#1701) lands on
integration/provider-config; build it on push and run CI for pull
requests into it, as with earlier integration branches.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* feat(config): capability slot registry and stage-to-slot mapping (#1726)
* feat(config): capability slot registry and stage-to-slot mapping
First P0 step of the provider configuration RFC (#1701, tracked in
#1725): define the capability slot forest and map every LLM stage key
to exactly one slot. Pure data with no callers yet, so there is no
behavior change.
Requirements are checked on the slot that declares them and are not
passed down to child slots, so agent.title can use a model without
tool calling even though agent requires it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* test(config): pin every stage destination and the capability roots
Review found that the station and root assertions derived their
expectations from the module under test: re-pointing a single-stage
station or dropping a capability root still passed. The tests now
compare against an independently written stage table and root list,
and pin agent.title as config-only. Also document that browserless
outlines still run on the generate-classroom model.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* test(config): pin slotForStage and full slot lineages
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* feat(config): provider presets and the openmaic.yml schema (#1727)
* feat(config): provider presets and the openmaic.yml schema
Second P0 step of the provider configuration RFC (#1701, tracked in
#1725).
- lib/config/provider-presets.ts: one preset per built-in registry
entry, plus the token plans as multi-capability presets whose stage
recommendations become slot recommendations. Registry ids that
collide across capabilities get explicit preset ids.
- lib/server/model-config/openmaic-yml.ts: parse and validate the
operator's openmaic.yml (or the file named by OPENMAIC_CONFIG):
${VAR} interpolation, strict schema, and cross-checks that every
assignment names a declared provider whose preset offers the slot's
capability. Every problem is reported with its path.
- instrumentation.ts: an invalid file refuses to start. Without a file
nothing changes, and nothing resolves models through the file yet.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* fix(config): harden openmaic.yml validation after review
- Look providers up by own key only, so "constructor:m" is not taken
for a declared provider.
- Refuse non-mapping objects YAML produces (an unquoted timestamp
becomes a Date that the schema would accept as an empty object), and
refuse a YAML alias that refers back to itself instead of overflowing
the stack.
- Accept lowercase variable names; refuse a "${" with no closing
brace, checked on the text as written, never on substituted secrets.
- Cross-check the entries that are valid on their own even when the
schema rejects others, so every problem is reported at once without
duplicate errors for declared-but-invalid providers.
- Name the three valid assignment shapes when a value has none of them.
- Test the boot path: an invalid file exits with code 1 before any
schedule starts; a valid one boots.
- Ignore a root openmaic.yml in git.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* fix(config): keep secrets out of openmaic.yml diagnostics
Review round 2:
- Read only variables the environment itself has, as non-empty
strings: ${constructor} or an inherited value is not a variable.
- Never print a value that came from ${VAR}, and report YAML syntax
errors by reason and position without js-yaml's source excerpt,
which can quote a literal key.
- Keep the base URL requirement on presets: SearXNG from its registry
entry, and Azure OpenAI and self-hosted MinerU, which have no usable
default endpoint.
- Check slot names and valid model references even inside an entry
that fails the schema, and report a failed placeholder once rather
than again as an empty value.
- Boot test for the no-file case.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* refactor(config): validate openmaic.yml in two phases
Rounds 1-3 of review kept finding edge cases in one feature: running
the cross-checks on the half-valid parts of a file the schema had
rejected, so that every problem showed at once. It hid problems inside
a rejected entry, lost a __proto__ slot key, and built misleading
provider errors from failed placeholders. That feature is gone.
Validation now runs in two phases. Phase 1 is the document itself:
placeholders, key names (checked on the document as written, since the
schema drops a __proto__ key), and the schema. Any problem there stops
before phase 2, the references between entries, which therefore only
ever sees a fully valid file. Each phase reports all of its problems,
one per path.
YAML syntax errors now report only their position: js-yaml's reason
can quote source text too (an alias or tag name), not just its excerpt.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* feat(api)!: generate-classroom takes requirement + uploaded materials; capabilities follow server config (#1728)
Narrows POST /api/generate-classroom to { requirement, materialIds? }; capabilities follow server configuration; materials go through the owner material library (upload, reference by id, delete); new GET /api/generate-classroom/capabilities; skill docs updated.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* feat(config): resolve a slot through the configuration layers (#1729)
* feat(config): resolve a slot through the configuration layers
Third P0 step of the provider configuration RFC (#1701, tracked in
#1725). resolveSlot walks from a slot to its capability root and
returns the first assignment it meets, consulting the deployment layer
(openmaic.yml, locked) before the workspace layer at every node. An
explicit null disables the subtree; nothing assigned up to the root is
unassigned, with no fallback to any vendor. The result carries the
provider, preset, registry entry, effective base URL, key, model, call
options, fallback, where it was resolved and whether it is locked, and
the requested slot's own requirements checked against the model
catalogue (met, unmet or unknown).
Pure and uncalled for now, so there is no behavior change.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* fix(config): lock only written slots and trust the catalogue only where it applies
Review round 1:
- locked now means the requested slot itself is written in the
deployment layer. Inheriting a deployment value does not lock a slot,
since the workspace may still assign it (source and resolvedAt still
report where the value came from).
- A custom OpenAI-compatible endpoint borrows the OpenAI registry for
transport only, so its preset no longer trusts that model catalogue:
requirements there resolve to unknown.
- The fallback is checked against the slot's requirements too, and the
result exposes fallbackRequirements so retries can refuse it.
- A malformed reference fails with a path-qualified SlotResolutionError
that does not echo the value, which is often a misplaced key.
- Requirement tests use named catalogue models instead of picking one
from the catalogue at run time.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* fix(config): order layers deployment-first and keep references out of errors
Review round 2:
- resolveSlot no longer depends on the order its caller passes the
layers in: deployment layers always come first, for assignments and
provider lookup alike.
- Resolution errors name the path and the preset, never a value taken
from the reference, so a key pasted into the provider position does
not end up in a log.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* test(config): cover catalogue aliases and fallback capability errors
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* feat(classroom)!: save server-generated classrooms through server persistence (#1730)
Server-side classroom generation saves the finished course create-only into the request owner's library with media in the owner's asset pool; jobs move to PostgreSQL with owner-scoped polling; /api/classroom is removed; legacy data/classrooms files are imported once in the background. Adds @openmaic/storage 0.36.0 PgAssetStore.releasePending.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* feat(config): translate the legacy configuration into a deployment layer (#1731)
* feat(config): translate the legacy configuration into a deployment layer
Deployments without openmaic.yml keep working: provider variables,
server-providers.yml, DEFAULT_MODEL, MODEL_ROUTES and MODEL_FALLBACK are
translated into the openmaic.yml shape and serve as the deployment layer
for resolveSlot.
- Providers: each configured entry becomes a provider under its preset
id; force-disabled entries are left out; AliDocMind's key pair goes
into credentials.
- DEFAULT_MODEL goes on the llm root. Every other slot that serves stages
gets what those stages used before (their route, or else the default
model), written only where inheritance would give something else, so
an unrouted stage under a routed parent stays on the default model.
- Stages that now share a slot but had different routes, models whose
provider has no server configuration, and stages that used the
browser's model but would now inherit a server one become startup
notices, never failures.
- MODEL_FALLBACK attaches to every chat assignment without its own.
- When openmaic.yml exists it wins, with a notice if legacy variables
are also set.
Nothing reads the layer yet; routes switch over in P1 (#1725).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* fix(config): follow the agent driver's rules and keep notices value-free
Review round 1:
- The agent never used DEFAULT_MODEL: it needs a valid maic-agent-driver
route and is off otherwise, so the translation writes agent: null where
it would inherit a server model (and a notice for a route that does
not work today). Unrouted conversation titles reuse the driver's model
with thinking off, as the title generator does.
- Notices name registry ids only; a credential pasted into a model
variable is never repeated.
- Provider entries and route options are checked against the new schema
and left out with a notice (field names only) instead of producing a
file that would not parse; driver-only options are dropped elsewhere.
- A route with its own fallback never falls back to MODEL_FALLBACK, even
when that fallback cannot carry over; the retry model is part of the
comparison with the inherited value.
- Force-off switches without a configured entry are reported, a legacy
configuration made only of them is detected, and translating one adds
a deprecation notice.
- loadDeploymentLayer reads the process environment and working
directory like the legacy loaders, instead of taking parameters it
could only partly honor.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* fix(config): compare routes by behavior, validate references, name only known ids
Review round 2:
- Stages sharing a slot are compared by what the route changes for them
(model, thinking, fallback), with bare ids read as openai models and a
route to DEFAULT_MODEL counted as no route; api and contextWindow are
inert outside the driver.
- A model reference carries over only when it names a provider from the
providers section and forms a valid reference.
- Section keys and force-off ids are named in notices only when they are
registry ids with a preset.
- Retries now follow the slot; where a call site picked its retry model
by another label (scene types under scene-content, browserless
generation), the change is reported.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* fix(config): chat references need a chat entry; one notice for retries
Review round 3:
- A model reference carries over only when its provider was translated
from the providers section, not merely declared by another section
under the same id.
- Routes are compared by the retry model that takes effect, so leaving
out a fallback equals repeating MODEL_FALLBACK.
- The per-call-site retry notices kept missing cases (streaming and
calls outside server-managed routing never retry today). They are
replaced by one notice, given whenever a retry model is configured,
that retries now follow the slot.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* refactor(config)!: translate only providers and the default model (#1732)
* refactor(config)!: translate only providers and the default model
MODEL_ROUTES does not map one to one onto slots: several stages share a
slot, the agent driver and conversation titles have rules of their own,
and retries are picked by call-site labels. Emulating that took most of
the translation and still ended in notices that are easy to miss.
The translation now carries over only the unambiguous part: providers,
DEFAULT_MODEL as the llm root and MODEL_FALLBACK as its fallback (the
agent stays null, as it never used DEFAULT_MODEL). A deployment that
sets MODEL_ROUTES without openmaic.yml gets LegacyRoutesError asking it
to write the per-stage models as slots. loadDeploymentLayer is not wired
into startup yet; that happens when routes switch to resolveSlot (P1).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* fix(config): say what a dropped MODEL_FALLBACK loses
Without DEFAULT_MODEL there is no assignment to hold MODEL_FALLBACK, and
calls that retried on it (server providers picked in the browser) stop
retrying; the notice says so. thinkingSchema is module-private again.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* feat(persistence): workspace model configuration with keys encrypted at rest (#1733)
* feat(persistence): workspace model configuration with keys encrypted at rest
The store behind the web settings of RFC #1701 (#1725, P1): one row per
workspace (owner) in workspace_model_config, the same shape as
openmaic.yml without policy.
- Provider secrets (apiKey, credentials) are sealed per provider with
AES-256-GCM under OPENMAIC_SECRET_KEY, bound to the provider id, and
never stored in the config column. Without the variable, a secret is
created once in data/instance-secret.key (the Docker volume).
- A secret sealed under another instance secret is reported as
unreadable ("enter again"), and a save that brings no new secret for
that provider keeps it, so a misconfigured secret cannot destroy keys.
- Saves replace the document with a compare-and-swap on the revision,
after the owner's identity lock; two concurrent first saves cannot
both land (PostgreSQL contract test).
- A claim moves the anonymous configuration to the account unless the
account has its own (core participant, order 900).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* fix(persistence): publish the instance secret atomically; force the races in tests
Review round 1:
- The generated secret is written and flushed under a private name,
then published with an exclusive link, so no process can read it half
written and exactly one of two starting processes creates it. A file
that is not a complete generated secret (empty, truncated) is refused
instead of deriving a key anyone could compute.
- The PostgreSQL test holds both first saves at their insert until both
have read the missing row, and holds the row lock for the update case
until both saves queue behind it (checked by backend pid, not by any
lock waiter in the database).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* fix(persistence): verify the written secret; require full GCM tags
Review round 2:
- The generated secret is written in full, read back and checked before
it is published; the temporary file is removed on any failure.
- Sealed values open only with a 12-byte IV and a full 16-byte tag
(authTagLength), so a shortened tag cannot weaken authentication.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* feat(config): resolve slots at request time over deployment, workspace and defaults (#1734)
* feat(config): resolve slots at request time over deployment, workspace and defaults
The runtime half of RFC #1701 resolution (#1725, P1):
- deploymentConfig(): the deployment layer, loaded once per process.
The legacy translation now splits into the deployment's providers and
a separate default layer (DEFAULT_MODEL, MODEL_FALLBACK) that locks
nothing and ranks below the workspace, as DEFAULT_MODEL ranked below
the model a user picked.
- workspaceLayer(owner) reads the web settings; requestWorkspaceId(req)
names the request's owner (none for an owner minted by the request).
- lookupSlot walks deployment and workspace over the whole tree first;
the defaults are a second walk, so a default on a child never outranks
a workspace choice higher up.
- resolveStageModel builds the language model: the configured slot, else
what the request still names the old way (deprecated), else the
defaults, else a loud error; a slot turned off fails whatever the
request names. A workspace provider's endpoint is checked like a
caller-supplied one and gets the transport that refuses redirects.
- resolveSlot gains the default source, and reports which layer declared
the provider, its proxy and credentials.
Nothing calls it yet; call sites switch next.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* fix(config): keep request identity and workspace endpoints inside their bounds
Review round 1:
- A refused owner credential throws InvalidOwnerCredentialError (401)
instead of resolving with the deployment's models and keys.
- A retired request owner gets no workspace: canonicalizing it would
hand an old anonymous cookie the claiming account's settings. Only
background work, which names a stored owner, is forwarded.
- A workspace provider may not be Amazon Bedrock (which falls back to
the server's AWS credential chain) or set a proxy (which routes around
the checked, redirect-refusing transport); the deployment still may.
- Test seams for the deployment config and the workspace loader, and
tests for identity, forwarding and caching.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* fix(config): read only the named owner's settings; refuse unmet requirements
Review round 2:
- workspaceLayer reads exactly the owner it is given. Forwarding through
a claim let a request whose owner was claimed between its check and the
read see the account's settings; background work passes the owner it
works for now instead.
- A model the catalogue says does not meet the slot's requirement is
refused before anything is built (SlotRequirementError), without
consulting the request.
- Tests: a database failure fails the call without falling back, a
workspace provider without a key never gets the deployment's, and the
transport each provider source gets.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* test(identity): exempt the model settings lookup from cookie forwarding
requestWorkspaceId resolves the owner only to pick whose model settings a
generation call uses, and returns no response of its own, like the
vision prompt helper already listed.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* feat(config)!: resolve every LLM call through its capability slot (#1735)
* feat(config)!: resolve every LLM call through its capability slot
The LLM call sites of RFC #1701 switch to slot resolution (#1725, P1):
- resolveModel resolves a stage through its slot for the request's or
job's workspace: the deployment and workspace configuration first; the
model and key a request names (x-model, x-model-routes, body fields)
only for a slot left unassigned, deprecated; then the defaults an
older deployment set with DEFAULT_MODEL. Routes that read headers get
this through resolveModelFromRequest; the chat routes pass their
workspace; background work (agent runs, titles, generation jobs)
passes the owner it works for now.
- Retries follow the slot: a slot-resolved model carries its slot's
fallback (lib/ai/model-fallbacks.ts), which callLLM and the outline
stream use; only a model from the request path still retries on
MODEL_FALLBACK. A fallback that cannot meet the slot is not used.
- The agent driver resolves the agent slot: tool calling required,
api defaults to openai-completions, thinking.effort still refused.
Conversation titles resolve agent.title with thinking off unless the
title slot sets it.
- /api/generate-classroom resolves each step through its slot for the
job's owner, its outline through course.outline.
- MODEL_ROUTES is gone: loadDeploymentLayer runs at startup and a server
that still sets it without openmaic.yml refuses to start. The
pbl-chat and maic-agent stage keys, which nothing resolved, are removed.
BREAKING CHANGE: MODEL_ROUTES is no longer read; write per-stage models
as slots in openmaic.yml.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* fix(config): a slot fallback needs no serverManaged stamp; follow claims per stage
Review round 1:
- callLLM arms a model's attached slot fallback whether or not the caller
passes serverManaged (the PBL agents pass none); the stamp still gates
MODEL_FALLBACK on the request path.
- /api/generate-classroom resolves the owner the job works for now at each
stage, so stages after a claim follow the moved settings.
Streaming calls (agent driver, classroom chat, PBL streams) still do not
retry on a fallback model, as before this change; that is the #1725 item
on retries at every call site.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* feat(config): resolve media and tool capabilities through their slots (#1737)
* feat(config): a provider-only reference names the provider's default model
Search and document providers mostly have no model to pick, so a slot
may name just the provider (`webSearch: tavily`); the target then has no
modelId and the adapter uses its default. Chat slots still need
providerId:modelId, checked in openmaic.yml and at resolution.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* feat(config): resolve media and tool capabilities through their slots
The capability routes and server paths of RFC #1701 (#1725, P1): text
to speech, speech recognition, images, video, web search and document
extraction resolve through their slots, like language models.
- lib/server/model-config/media.ts: the configured slot (deployment,
then workspace); else the provider a request names the old way
(deprecated); else the legacy defaults; else a loud error. A slot turned
off fails whatever the request names, and while the legacy
<CAP>_<VENDOR>_ENABLED=false switches are in effect a switched-off
provider stays off whoever assigns it. A workspace endpoint is checked
like a caller-supplied one and may not use a proxy.
- The legacy translation assigns the media roots the provider the server
picked when a request named none (first configured; web search by its
old priority; DEFAULT_IMAGE_PROVIDER for images), with the first pinned
model.
- Routes: /api/generate/{image,video,tts,voice}, /api/transcription,
/api/web-search, /api/parse-pdf and /api/extract-document. A TTS voice
applies only to the provider it was chosen for; voices register on the
tts slot's provider.
- Server paths: agent image and video generation, scene narration, the
voice catalog and registration, web search and fetch_url, material
extraction (the document slot's service, the asr slot for local
transcription), browserless classroom media, and the generation
capabilities reported by /api/health and the classroom capabilities
endpoint.
- A provider-only reference (`webSearch: tavily`) names the provider's
default model; chat slots still need providerId:modelId.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* fix(config): keep slots authoritative on every media path
- Workspace providers reach media, search and document services only at
their preset's endpoints; a custom endpoint or proxy is deployment-only
(403 INVALID_URL).
- A configured or turned-off document slot decides the extraction service:
deprecated request fields may only pick a self-contained extractor, and
legacy operator credentials are no longer reached.
- Request paths resolve their own workspace without following a claim;
background extraction still does.
- A configured TTS slot keeps its own model; legacy pins apply only on the
deprecated and default paths.
- Local transcription and agent voice registration keep the connection's
network policy flags.
- The agent's web search forwards the whole resolved configuration.
- An unusable DEFAULT_IMAGE_PROVIDER leaves the image slot unassigned with a
notice instead of switching vendors.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* fix(config): public presets only for workspaces, plan default models
- A workspace preset whose default endpoint is on the server's own network
(self-hosted TTS, ASR, image) is deployment-only, and a workspace
provider's endpoint runs under the public-only policy.
- A provider-only reference to a token plan means the plan's own default
model for that capability.
- On the legacy default provider, the request's image, video and ASR model
still applies through its allowlist, and image/video without a model is
still MISSING_MODEL.
- An asr assignment a workspace may not use no longer blocks document
extraction, and a refused document service answers 403.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* fix(config): keep legacy search and voice choices on their old paths
- Classroom search honours the provider and key a request names while the
webSearch slot is unassigned; only /api/web-search prefers the operator's
configured backend, as before.
- A TTS request's voice applies unless the request chose it for another
provider.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* fix(config): legacy search model and capability discovery errors
- On the legacy default search provider, the request's search model still
applies through the server's pins.
- Capability discovery answers a refused credential (401) or a workspace
service it may not use (403) instead of 500.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* fix(config): classroom submission refuses a workspace service with 403
A classroom submission whose materials would go to a document or speech
service the workspace may not use answers 403 INVALID_URL instead of 500, and
its material check resolves the request's own workspace without following a
claim.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* fix(config): workspace image and video providers run public-only
A workspace-configured image or video provider now uses the strict public
transport for its requests and for the redirects its clip download follows,
whatever ALLOW_LOCAL_NETWORKS says; the operator's own providers and the
deprecated per-request path keep their policies.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EF6G824rLqUXidRrqrMskR
* Revert "fix(config): workspace image and video providers run public-only"
This reverts commit
|
||
|
|
1635b16899 | docs: add multilingual vocational task engine guide (#1749) | ||
|
|
fa47efe1b3 |
feat(persistence)!: server-backed persistence only, with a one-way legacy browser import (#1710)
* ci: run CI for the persistence-default integration branch Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * feat(docker): start PostgreSQL by default and add a single-user owner * feat(docker): start PostgreSQL by default and add a single-user owner `docker compose up` now runs a server-backed app against a bundled PostgreSQL, started only once PostgreSQL is healthy and published on 127.0.0.1 only, with a new built-in singleUser owner auth method: every request resolves to one fixed owner that may publish, and no anonymous cookie is minted. Single-user mode (OWNER_SINGLE_USER=true, OWNER_SINGLE_USER_ID default "local") runs with or without ACCESS_CODE. Without one, the server logs one prominent startup warning that anyone who can reach it shares, edits and can delete the single library; it never inspects request peers or forwarding headers. It excludes PERSISTENCE_SHARED_OWNER_ID and follows the sharedTeam registration rules. Its principal gets a claim candidate, so a browser's earlier anonymous work is claimed into the single owner (OWNER_CLAIM_TRIGGER=auto in the Compose defaults). Compose defaults live in docker-compose.defaults.env, read before .env.local so they can be overridden. The app warns when its declared published address (OPENMAIC_PUBLISH_ADDRESS, passed by Compose) is not loopback while PostgreSQL uses the default password. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(docker): keep claims explicit and let .env.local set DATABASE_URL - Compose no longer defaults OWNER_CLAIM_TRIGGER to auto: an irreversible merge of every browser's anonymous library into the single owner must not happen on upgrade. The single-user principal still gets a claim candidate, so POST /api/identity/claim works; the docs explain it and warn about auto on a deployment several people used. - The bundled DATABASE_URL moves to docker-compose.defaults.env, read before .env.local, so an external database or a rotated password set there keeps working. The password is inserted unencoded, so it must be letters and digits (documented). - Upgrade docs no longer claim browser-stored courses are copied as they are opened: they stay in the browser, are not deleted, and are moved by the automatic browser-to-server migration shipped with this work. - Single-user mode without ACCESS_CODE now logs one warning instead of two; the docs note that the single owner id is permanent. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * feat(persistence)!: server-backed persistence is the only persistence (#1707) * feat(persistence)!: make server-backed persistence the only persistence Courses, folders and folder membership, chat history and learner runtime, and generated media are now always stored on the server through the embedded /api/persistence endpoint. The browser keeps no durable data of its own. - Remove the build-time NEXT_PUBLIC_PERSISTENCE switch: the client bootstrap always configures the HTTP document, runtime and asset seams, and the Dockerfile, docker-compose.yml, the Pi route and the whiteboard runtime no longer read it. Unconfigured seams refuse to resolve instead of falling back to IndexedDB, and the learner key is always the server-derived one. - Remove the browser write paths: the browser document, runtime and asset stores as backends, the browser-mode branches of stage, folder, chat, media, narration and import storage, the Dexie backup export/import and the whole-database clear. The library lists through /api/stages, folders through /api/folders, and membership now goes through /api/folders/members. Regeneration always forks to a fresh asset. - Device-local state moves to its own IndexedDB database (lib/device-storage, maic-device-cache): the local media and narration cache and refused-bytes retention, staged PDF images, undo history, browser voice profiles (carried over once from the old database) and the auto-voice cache. "Clear Local Cache" clears exactly that and no longer claims to delete classrooms or chat history. - Keep the pre-server data readable for the one-way importer: the Dexie schema and read-only accessors for its tables and for the browser document, runtime and asset databases live in lib/legacy-browser-storage, which nothing on the regular paths reads and which has no write path. - Require a database: the server exits at boot without DATABASE_URL, with a message naming `pnpm db:up` and `docker compose up`. `pnpm db:up` / `pnpm db:down` start and stop the Compose postgres service alone, published on 127.0.0.1 through docker-compose.db.yml; .env.example carries the matching local DATABASE_URL. - E2E specs seed their courses through the persistence endpoint, each under a fresh id, instead of writing IndexedDB. - Guard tests pin the boot requirement, the absence of any NEXT_PUBLIC_PERSISTENCE read, and the legacy-storage boundary. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * ci: run the E2E suite against PostgreSQL The app refuses to start without DATABASE_URL, so the E2E job gets a postgres:16 service and a job-level DATABASE_URL. The unit, storage and render-service jobs are unchanged and need no database. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs: document always-on server persistence and the database requirement README (English and Chinese), the deployment guide in every locale, the extension cookbook and the changelog now describe PostgreSQL as required: `pnpm db:up` for local development, `docker compose up` for a deployment, and an external database for Vercel and other serverless hosts (the Deploy button prompts for DATABASE_URL). They list what stays in the browser, drop the NEXT_PUBLIC_PERSISTENCE instructions, and say that courses an earlier browser-only build stored stay in the browser until the one-way importer moves them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(pbl): use the server-derived learner key for PBL v2 runtime PBL v2 synchronization, hydration and drain resolved the learner key from their default watermark KV store, which reads or mints a device key in localStorage instead of asking runtime configuration. The runtime store is the server one, which refuses any key but the owner's, so saving a course with a PBL v2 scene failed before the document write, and the minted key landed in the slot the one-way importer reads as the pre-server runtime partition. The learner key now comes from getLearnerKey(args.kv): the configured server-derived key, or an explicitly injected store. The default KV store still holds the drain watermarks and nothing else. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(persistence): pin that clearing the cache keeps legacy databases - Seed the four pre-server databases (MAIC-Database, maic-documents, maic-runtime, maic-asset-pool) with real rows, run Clear Local Cache, and assert every database and row survives; assert the device database name differs from every legacy name. - The legacy-module import rule now also catches relative static, side-effect, dynamic and require imports at any depth. - New rule: the runtime learner key is never read from a KV store the caller made up, only from configuration or an injected store. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * build(dev-db): run the development database as its own Compose project `pnpm db:up` / `db:down` shared the checkout's default Compose project with `docker compose up`, so they recreated or stopped a running stack's database. docker-compose.db.yml now declares its own project (`openmaic-dev-db`), which gives the development database its own container and data volume; it no longer touches the stack, and the two do not share data. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs: start the development database before `pnpm dev` CONTRIBUTING, the getting-started guide in every locale and the startup modes reference now run `pnpm db:up` and set DATABASE_URL before `pnpm dev`. README, the deployment guides, the cookbook and the changelog describe `pnpm db:up` as a separate development database. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(persistence): sharpen the legacy-storage and learner-key guards - The Clear Local Cache test closes its seeding connections to maic-documents and maic-runtime, so a regression deleting either fails on the assertion that names the database instead of by timeout. - The legacy-module and Dexie import rules accept comments inside import() / require(), so a webpackIgnore hint no longer hides one. - The learner-key rule also flags an injected-looking name that is bound to a default local store in the same file; its remaining limit is documented, with the behavioural PBL test as the guard. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * build(dev-db): pin the development database's Compose project `pnpm db:up` / `db:down` now pass `-p openmaic-dev-db`, which takes precedence over COMPOSE_PROJECT_NAME from the shell or a .env file; the file's `name:` alone could be overridden and point the scripts at a running stack's database. The compose test pins the flag. The docs (all locales) and the file header say the development database is shared by every checkout on the machine, and how to run a separate one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * feat(persistence): import legacy browser data into the server, once (#1708) * refactor(persistence): prepare the seams the legacy browser importer uses - Legacy module: read-only accessors for the auto-voice cache, the course ids the old media and narration tables name, the pre-server learner key, and asset bytes from the browser asset pool. - Narration adoption exports its row ownership rule so the importer applies the same one to rows of the old database. - The quiz legacy migration is split into a non-deleting core (importLegacyQuizSnapshot) and the regular path, which still deletes the keys it migrated. - The lazy document migration exports its snapshot canonicalizer. - Clear Local Cache keeps the importer's per-owner ledgers, as it keeps the pre-server learner key. - A library-changed window event lets an open library list courses that arrive in the background. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRME5T4oEaQ4EBUzrDXMKz * feat(persistence): import legacy browser data into the server, once On the first load after the upgrade, the client moves what earlier builds kept in this browser to the server, for the owner the server resolves: courses from the browser document store and the original tables (with chat, learner runtime, playback position, roster, folders and membership, pre-runtime quiz state), their media bytes through commitToPool and the existing write-back funnels, the bytes of server courses from earlier opt-in server builds that only the old tables hold, and device-only rows (failure records, refused bytes, auto-voice clips) into the device cache. It is automatic and silent, runs after the page is idle, never writes to a legacy store, and records every step in a per-owner ledger so it resumes after a crash and never imports twice. Runs are serialized across tabs with Web Locks. A course the owner already has stays authoritative; one whose id another owner holds is imported under a derived fresh id; one the owner deleted on the server stays deleted. Transient failures retry on a later load with backoff; permanent ones are recorded per item. The module is temporary and self-contained; its README lists the removal steps. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRME5T4oEaQ4EBUzrDXMKz * test(persistence): pin that each owner keeps its own import ledger Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRME5T4oEaQ4EBUzrDXMKz * test(persistence): run the legacy import against the app routes and a browser A PostgreSQL suite routes every request the importer and the app seams send to the real persistence, library and folder handlers, owner resolved from the anonymous cookie: a full import, a course another owner holds, a course the owner deleted, and an existing course whose media is filled in. An end-to-end spec seeds an old pre-server database in Chromium, loads the app, and checks that the course reaches the library with its narration uploaded, stays in the browser untouched, and is visible from a fresh browser context with the same owner cookie. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRME5T4oEaQ4EBUzrDXMKz * docs: describe the one-way import of legacy browser data The README (and its Chinese version), the deployment guide in every locale and the changelog now say what the importer does instead of announcing it: courses an earlier browser-only build kept in the browser move to the server automatically on the first load after the upgrade, and the browser copy stays untouched. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRME5T4oEaQ4EBUzrDXMKz * fix(persistence): probe server assets through the shared asset-URL owner The importer asked the pool directly whether an id exists, which the asset-URL ownership boundary forbids outside use-asset-url. It now uses assetRefExists, the existing metadata-only probe. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRME5T4oEaQ4EBUzrDXMKz * fix(persistence): guard the importer's pool probe like every other entry point Only a reference the pool could have issued is probed, as the lease guard requires; the importer is added to the list of guarded entry points. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRME5T4oEaQ4EBUzrDXMKz * fix(persistence): import legacy browser data once per browser Review round 1 of the legacy browser importer. - Once per browser, not once per owner: the data belongs to whoever used the browser before the upgrade, so the first owner the import runs for claims it and any other owner gets nothing. The ledger is one key, maic:legacy-import:v2, recording the owner only as a SHA-256 digest (an anonymous owner id is a bearer credential) and a random salt. - Handoff: when the claiming owner is retired (403 OWNER_RETIRED), or the current owner holds courses or folders the importer created (a claim moved them), the current owner continues the unfinished items; courses already done are never imported again, so a claim neither duplicates nor resurrects them, and a half-copied course keeps its runtime. - Fresh ids come from the salt and the legacy id through SHA-256, not from the owner: unlinkable, unpredictable, and the same in every tab. - 401 pauses with backoff instead of closing the import; 403 FORBIDDEN_LEARNER stops the run and leaves the item pending. - Without Web Locks: ledger writes merge with the stored copy, and the library is listed again right before a course is placed, so a second tab does not import a course the first one just created. - Media the server refuses for good gets the app's failed-media record instead of a dangling reference; the legacy bytes stay. - A legacy whiteboard or PBL session is not created when the server already has an active one of that kind. - A folder that is gone leaves the course unfiled instead of failed, and a membership naming a folder the old database lacks counts as unfiled. - Narration rows from before the course column are adopted when exactly one legacy course names their key; unconvertible chat rows are noted; an unreadable document-store copy falls back to the original tables; PBL v2 documents go through the save-path strip. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRME5T4oEaQ4EBUzrDXMKz * test(persistence): cover the importer's handoff, tabs, refusals and review gaps Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRME5T4oEaQ4EBUzrDXMKz * docs: say the legacy import runs once per browser The README (and its Chinese version), the deployment guide in every locale, the changelog and the module README now say that the first owner to load the upgraded app in a browser claims its legacy data, what the handoff to an account does, that the ledger holds no owner id, and how refused media and the new pause and skip cases behave. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRME5T4oEaQ4EBUzrDXMKz * fix(persistence): note runtime the importer cannot find without the old learner key Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRME5T4oEaQ4EBUzrDXMKz * feat(identity): let an owner confirm it absorbed a given owner through a claim GET /api/identity/merged-from?salt=<hex>&digest=<hex> answers whether a claim merged into the requesting owner an owner whose id hashes to SHA-256(salt, id). It reads only the requester's own owner_merges rows, never lists or names an owner, resolves the owner like every other owner-scoped route, and is uncacheable. The one-way import of pre-server browser data uses it to decide whether a different owner may continue an import the first owner started. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRME5T4oEaQ4EBUzrDXMKz * fix(persistence): hand the legacy import to another owner only on a confirmed claim Review round 2 of the legacy browser importer. - The only way the browser's legacy data moves from the owner that claimed it to a different owner is the server confirming, through GET /api/identity/merged-from, that the current owner absorbed that owner through a claim. The inferred signals (an owner that never wrote, a library listing that holds imported courses) and the retired flag are gone; a 403 OWNER_RETIRED only stops the run and leaves items pending. - The first owner is bound only once the run's first authenticated request of its own (the library listing) succeeded, so a run that dies before that leaves the ledger unclaimed. - The owner is recorded as SHA-256 of the per-browser salt and the owner id; the server computes the same value from the salt the browser sends. - A "not absorbed" answer is reused for an hour instead of asking on every load, and the claiming owner stored first survives another tab's save unless that tab handed the import over; completion survives too. - Run-level failures (401, OWNER_RETIRED, FORBIDDEN_LEARNER, OWNER_BUSY) from any call stop the run and leave the course pending, including the "is the id taken" read and the library re-list, which could previously mark the course failed and close the import. - Refused media without a generation request (the user's own) gets a new non-retryable ASSET_REFUSED code, so it shows as failed without a Retry that could only fail; a skipped singleton runtime session leaves a note. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRME5T4oEaQ4EBUzrDXMKz * test(persistence): pin the importer ledger's owner merge and the singleton-skip note Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRME5T4oEaQ4EBUzrDXMKz * docs: the legacy import moves to another owner only on a confirmed claim The README (and its Chinese version), the deployment guide in every locale, the changelog and the module README now say that the import runs once per browser and moves to another owner only when that owner claimed the original one, confirmed by GET /api/identity/merged-from; that the owner is recorded as a salted digest; and how refused user media shows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRME5T4oEaQ4EBUzrDXMKz * fix(persistence): never let a transient failure settle a legacy import item Review round 3 of the legacy browser importer. - A read of the old browser stores that fails in storage (an aborted IndexedDB transaction, a closed database) now pauses the run and leaves the course pending. Only a record that cannot be migrated, parsed or validated is skipped. This covers the course read (which no longer falls back to the older table copy on a storage failure), and the quiz-scene and speech indexes, which used to read a failure as "no scenes" or "no holder" and drop quiz state or narration for good. - After a session-id collision, a failed read of the session propagates and is retried; only a successful read that shows the id taken skips it. - Without Web Locks, two tabs of different owners can both find the ledger unbound. Every ledger write keeps the owner stored first, and the run now re-reads the stored ledger after binding, before folders, before each course and before each course document is created, and stops if another owner holds it. - The "not yours" answer is reused for ten minutes instead of an hour, a stored wait further ahead than the longest the importer sets (a clock that ran ahead) counts as passed, and expired answers are pruned. - Generated media refused without an error code keeps its Retry; only media nothing can regenerate gets ASSET_REFUSED. A poster that fails transiently leaves the video pending instead of being dropped. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRME5T4oEaQ4EBUzrDXMKz * test(persistence): cover transient reads, racing owners, the not-yours cache and the claim client Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRME5T4oEaQ4EBUzrDXMKz * docs(persistence): say what the ledger's salt protects, and the new pauses The salt defeats precomputed and cross-browser tables, not a targeted guess against one browser's ledger; the module README and the digest's comment now say so. The README also covers storage read failures, which pause instead of skipping, the two-owner race without Web Locks, and the ten-minute recheck. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRME5T4oEaQ4EBUzrDXMKz * feat(identity): bind a browser's legacy data to one owner on the server The one-way import of pre-server browser data now asks the server whose data it is, instead of deciding in the browser. - legacy_import_bindings (browser_id primary key, owner_id, timestamps), provisioned with owner_merges on fresh and upgraded databases. - POST /api/identity/legacy-import-binding {browserId}: one atomic insert (ON CONFLICT DO NOTHING) and a read-back; answers only whether the requesting owner holds the browser. Same-origin JSON, resolved and write-fenced like every owner write, 400 for a malformed id. - A claim participant re-keys the claimed owner's bindings to the account inside the claim transaction, so the account simply holds the browser. - Owner resolution refuses any request carrying X-OpenMAIC-Legacy-Import with 409 LEGACY_IMPORT_NOT_BOUND unless the owner it resolves to holds that browser: one central fence every owner-scoped route goes through. Requests without the header are unaffected. - GET /api/identity/merged-from is removed; the binding replaces it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRME5T4oEaQ4EBUzrDXMKz * fix(persistence): import through fenced clients bound by the server Review round 4 of the legacy browser importer. - The ledger holds a random browser id and no owner information; the owner digest, the "not yours" cache and the client-side handoff are gone. A run first asks the server to bind the browser and imports only when the requesting owner holds it. - Every importer request goes through its own clients that carry the browser id, so the server refuses any write under an owner that does not hold the browser: after a cookie switch in another tab, from a page whose memoized owner is stale, or from a tab that lost the binding race. The runtime learner key is asked for during each run, never taken from the page. 409 LEGACY_IMPORT_NOT_BOUND stops the run with items pending. - The write-back funnels, commitToPool and the PBL save-path strip take an optional store, put or runtime, so the importer passes its fenced ones. - A failed read of one legacy course holds up only what it could affect: the quiz-scene and speech indexes leave the course out as unindexed, and only quiz state or narration it could own waits. Read failures are counted per course; after five failing runs over at least a day, a course whose document-store copy cannot be read falls back to the table copy, or is skipped with the reason when there is none. - Runtime ids are rewritten by replacing only their course segment, so a short course id cannot corrupt the prefix or the learner segment. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRME5T4oEaQ4EBUzrDXMKz * test(persistence): cover the server binding, its fence, bounded reads and short ids Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRME5T4oEaQ4EBUzrDXMKz * docs: the server binds a browser's legacy data to its first owner The README (and its Chinese version), the deployment guide in every locale, the changelog and the module README now say: once per browser; the server binds the browser to the first owner; a claim carries the binding to the account; the importer's requests are refused for any other owner. They also describe the bounded pause for a course the old storage cannot read, and the removal steps for the server side. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRME5T4oEaQ4EBUzrDXMKz * fix(persistence): keep a dropped asset request pending in the legacy import The asset client reports a fetch that got no answer (a dropped request, an aborted upload, the existence probe's deadline) as status 0 with HTTP_REQUEST_FAILED, which the importer read as a final refusal: the media was marked failed and the course could complete without it. Read that code as transient, keep the client's local validation failures final, and treat a 2xx/3xx answer a client could not use as transient too. Unit tests drive every client the importer uses with a rejected fetch and a non-JSON answer. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRME5T4oEaQ4EBUzrDXMKz * fix(persistence): ask a refused binding again only every ten minutes A browser whose legacy data another owner holds sent the binding request (a write) on every page load. Record a ten-minute recheck in the ledger (clamped like every other deferral), so a claim that moves the binding is still picked up, and open the old databases only once the browser is bound. The read budget now counts consecutive failing runs (a run that reads the course resets it) and counts a first failure dated in the future from the next one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRME5T4oEaQ4EBUzrDXMKz * fix(identity): answer 503 with the cookie when the import fence cannot read The legacy import fence now reads the header name from the shared constant, and a database error while reading the binding answers the usual JSON error (503 PERSISTENCE_UNAVAILABLE) with the resolution's Set-Cookie values instead of escaping as a bare 500. Route tests cover that, a bind by an owner a claim retired (403 OWNER_RETIRED, no row), and one header name on both sides. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRME5T4oEaQ4EBUzrDXMKz * test(persistence): cover dropped asset requests, the recheck and the read budget With the real asset client's error for an upload and an existence probe, the media stays pending and a later run imports it. A non-holder's five loads send one binding request and never open the old databases, and a claim still hands the import to the account after the delay. The read budget's run count and time span each hold on their own, a clock that ran ahead does not hold a course open, and a good read resets the count. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRME5T4oEaQ4EBUzrDXMKz * docs(persistence): complete the legacy import removal steps List every file the removal touches (the claim scenarios test, the claim participant table and list, every doc), keep the bindings table for one release after the code goes because of rolling deploys and give the DROP statement for that release. Add the claim's eighth participant to the README lists, fix the fresh-id wording in the changelog, and describe the recheck delay, the transient status-0 asset failures and the consecutive read budget. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRME5T4oEaQ4EBUzrDXMKz --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * fix(persistence): keep legacy quiz state through Clear Local Cache until the import completes Pre-runtime quiz drafts, answers, results and attempt ids exist only in localStorage, and the one-way importer copies them to the server with their course. Clear Local Cache deleted them even while the import was still pending (it waits for an idle page and can stay pending after a failure), so that quiz progress was lost for good. Clear Local Cache now keeps the four quiz key families unless the importer's ledger records the import as complete, read through a new `legacyImportIsComplete` helper in the ledger module. The ledger key moves there too, so the two modules do not import each other. Once the import is complete, the keys are cleared as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRME5T4oEaQ4EBUzrDXMKz * docs: show DATABASE_URL set in the local development setup The getting-started guide showed the required DATABASE_URL line commented out, so copying the block left the server unable to start. Each locale now shows `pnpm db:up` and, separately, the `.env.local` line to set. The `.env.example` header said every variable is optional; it now says that provider variables are, and that DATABASE_URL is required except under docker-compose.yml. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRME5T4oEaQ4EBUzrDXMKz * docs(changelog): drop two upgrade notes the final code contradicts The Compose entry said its default DATABASE_URL overrides .env.local; the defaults file is read first, so a value in .env.local wins, as the same entry says further on. The runtime-session entry offered turning server persistence off as an upgrade path; that switch no longer exists. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRME5T4oEaQ4EBUzrDXMKz * docs(env): restore the ACCESS_CODE warning notes in .env.example A later change to the example file dropped the lines saying that an unset ACCESS_CODE fails open, that the server then logs a one-time startup warning and GET /api/health reports accessCodeConfigured: false. They are back, and say that single-user mode logs its own warning in place of the generic one, as the startup code does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRME5T4oEaQ4EBUzrDXMKz * ci: run every app PostgreSQL suite in the contract job The app-domain step named its suites one by one, and seven had been left off, among them the legacy importer's route suite. No other job gives the app suites a database, so they skipped everywhere. The step now lists every app `*.pg.test.ts`; all of them work in a schema or database of their own, or truncate only their own tables, and pass before and after the storage package suite in the same database. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRME5T4oEaQ4EBUzrDXMKz * fix(identity): establish the anonymous owner before the first API request (#1721) * fix(identity): establish the anonymous owner on the page response On a browser's first load the page sent several API requests without an owner cookie; each minted its own anonymous owner and set its own cookie, and the last answer to arrive won. Work done in between (the legacy import binding, a first course write) then belonged to an owner the browser no longer presented. The middleware now mints the anonymous cookie on document navigations that carry no valid one, with the route handlers' own value format and attributes (the cookie module is Edge-safe now: Web Crypto instead of node:crypto), and forwards it on the request so the page render resolves the same owner. API, RSC, prefetch and Server Action requests never mint there, and a valid cookie is never replaced. It mints only when neither OWNER_SINGLE_USER nor PERSISTENCE_SHARED_OWNER_ID is set; host registrations are invisible to an Edge middleware, so the README tells hosts where to skip it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRME5T4oEaQ4EBUzrDXMKz * fix(legacy-import): bind only an owner the browser already presents A binding request whose owner was minted by that very request answers 409 OWNER_NOT_ESTABLISHED with the minted cookie and binds nothing: other cookieless requests may still be minting owners of their own, and a binding to this one could be left with an owner nobody presents. The importer treats it as transient and retries on a later load. It also says plainly when a request after its own successful bind is refused as another owner (the owner cookie changed mid-run); items stay pending. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRME5T4oEaQ4EBUzrDXMKz * test(legacy-import): cover a first visit whose first answers arrive out of order Against the real routes and PostgreSQL: a browser without a cookie loads a page, sends two requests at once, and the first answer reaches it only after the importer bound the browser; the import completes under the one owner the page established. A second case binds nothing for an owner the bind itself minted and imports on the next run. The E2E drives the same ordering in Chromium by holding the first owner-scoped answer until the binding answered. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRME5T4oEaQ4EBUzrDXMKz * test(legacy-import): drop an unused initial assignment Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRME5T4oEaQ4EBUzrDXMKz * docs(changelog): note the page response now sets the anonymous owner cookie Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRME5T4oEaQ4EBUzrDXMKz * fix(identity): let hosts turn page-response minting off The middleware cannot see owner auth methods a host registers, so a host with anonymousFallback: false still got an anonymous cookie on a cookieless page load. Beside the host credential it is a claim candidate; with OWNER_CLAIM_TRIGGER=auto it is claimed and cleared on the next request, again after every such page load. OWNER_ANONYMOUS_PREMINT (default on; true/1/false/0, anything else fails startup) is read by the middleware before minting. At startup the server warns once when a registration turns the anonymous fallback off while pre-minting is still on. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRME5T4oEaQ4EBUzrDXMKz * docs(identity): document OWNER_ANONYMOUS_PREMINT Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRME5T4oEaQ4EBUzrDXMKz * fix(identity): keep the anonymous identity for 400 days and renew it in use The anonymous cookie had a fixed 30-day lifetime from its mint and was never renewed, so every anonymous visitor lost their whole library 30 days after the first visit however active they were; with persistence on the server only, that affects every anonymous deployment. It now lasts 400 days (the browser cap, one shared constant), and every route handler and Server Action response that resolves to a valid anonymous cookie re-sends the same value with a fresh Max-Age (best-effort where next/headers refuses writes). Page responses never renew, so pages stay cacheable, and a host principal never renews the anonymous cookie beside it. A response that clears the cookie (a claim, a retired owner) must not renew it, whatever order a route merged its headers in: withRequestOwner, and the owner-events retired answer, keep only the clearing value for a cookie a value clears. A renewal that lands after a claim cleared the cookie is pinned by a test: the next write with it, alone or beside the account, writes nothing, and its answer clears it again without renewing it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRME5T4oEaQ4EBUzrDXMKz * docs(identity): 400-day renewed anonymous cookie; when to turn pre-minting off Hosts set OWNER_ANONYMOUS_PREMINT=false only when their registration sets anonymousFallback: false; hosts that keep anonymous visitors need pre-minting and skip it per request in middleware for requests their methods authenticate. The CHANGELOG notes the new lifetime and renewal, and that a lost cookie means a new owner. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRME5T4oEaQ4EBUzrDXMKz * fix(identity): forward owner cookies from routes that resolve the owner directly The Pi chat and whiteboard-visibility routes and asset-id document extraction resolved the owner themselves and never sent its Set-Cookie values back, so an anonymous identity used only through them was never renewed (and a minted one never stored). attachOwnerCookies attaches a resolution's cookies to a response a route built itself, with the clear-wins rule, before a stream's body starts. Both Pi routes answer through it, success and error alike; resolveServerAsset hands the cookies back with every answer and the extraction route attaches them. A guard test scans for every module outside the identity seam that calls the owner resolution (or the asset helper) directly and requires it to forward the cookies; the two callers that cannot are listed with the reason. Behaviour tests cover the three paths. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRME5T4oEaQ4EBUzrDXMKz --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: wyuc <dhq1204@yahoo.com> |
||
|
|
877bf792d7 | fix(generation): preserve template literals in interactive HTML (#1706) | ||
|
|
a686481e73 |
feat(auth): owner identity seam — composable auth methods, owner-keyed persistence, host hooks, claims
* ci: run CI for the owner identity seam integration branch Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * feat(auth): owner identity seam, phase 1 — pluggable authenticator with today's behavior * feat(auth): add the owner identity seam with built-in authenticators Introduce lib/server/identity/: an OwnerAuthenticator contract (SubjectKind, OwnerPrincipal, AuthOutcome), a single-shot, boot-validated configureOwnerAuthenticator() registry, and the anonymousCookie and sharedTeam built-ins that reproduce today's owner resolution exactly (same anonymous_id cookie, owner id strings, statuses and env semantics). Every owner-scoped route handler and the workspace Server Action now resolve their owner through one memoized per-request resolution instead of the three previous copies (agent-runtime/owner.ts, with-owner.ts and the Server Action re-implementation). Publish and unpublish decide from the principal's course:publish role instead of an anon: id prefix. An invalid credential from an authenticator is answered with 401 on every surface and never falls back to an anonymous owner. A source scan keeps the anonymous owner cookie and anon: prefix checks out of code outside the identity module. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(auth): describe the owner identity seam and host registration Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(auth): tighten the identity boundary guard and Server Action cookies - Scan workspace package sources too, flag imports of the concrete built-in authenticators outside lib/server/identity, and police the slice/substring/indexOf/includes spellings of an anon: id-shape check. Stop re-exporting the built-ins from the host-facing index. - Refuse setCookies returned by authenticateFromContext, as the authenticate() fallback already did, and document that it must write cookies itself through next/headers. - Let the route-test owner stub carry explicit kind/roles, and cover the 403 forbidden branch of publish and unpublish for a signed-in owner without course:publish. - README: registration conflicts fail the boot; an invalid principal is rejected per request with a 500. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * feat(auth): owner identity seam, phase 2 — runtime and assets keyed by the owner * feat(auth): owner identity seam, phase 2 — runtime and assets keyed by the owner Runtime sessions and assets on /api/persistence now take their identity from the same memoized owner resolution as documents, instead of a client-chosen x-learner-key behind a development bearer token that shipped in the public bundle. - Runtime: the storage handler's learner key is principal.ownerId. A path or body naming another learner answers 403 FORBIDDEN_LEARNER and another learner's session answers 404, whatever x-learner-key says; the header is no longer read. The browser learns its key from the new GET /api/persistence/learner-key and sends no credential of its own. The Pi whiteboard routes derive the same key from the owner. PERSISTENCE_DEV_TOKEN, NEXT_PUBLIC_PERSISTENCE_TOKEN and PERSISTENCE_ALLOW_INSECURE_DEV_AUTH are gone from the server path and the client, and server-auth.ts is deleted. Learner merge stays refused. - Assets: allocations land in a per-owner partition (owner:<ownerId>), so quota is per owner and replace/delete reach only the owner's entries. Reads stay capability-by-id where a course viewer needs them: another owner's committed entry is readable while a live course references it. Legacy entries in the old shared partition stay readable by id, and may be replaced or deleted only by an owner who owns every course referencing them. Server-generated media is stored under the run owner's partition; asset-id extraction and vision image resolution use the same rule. - Tombstones: runtime of a deleted course reads as absent (404, empty lists) and takes no new sessions or records, through a guard in the app's runtime composition; no package schema change. The identity boundary scan now also fails on any source that reads x-learner-key or the retired development token variables. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(persistence): describe owner-keyed runtime and assets, drop the dev token Remove the development persistence token from the server-persistence recipe, .env.example, the Docker build arguments and the deployment docs; describe runtime learner keys, per-owner asset partitions and quota, the legacy shared-partition rule and the tombstone behavior; and record the breaking change for existing server-persistence runtime data under Unreleased. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * feat(storage): scope asset references to principals, typed stage refusal, uniform create collision @openmaic/storage 0.32.0. - PgDocumentStore takes assetReferencePrincipals: with reference tracking on, a write references and commits only entries held by the listed principals. An id naming another principal's entry records no row and changes no lifecycle column, like an unknown id, and the write is never refused. Without the option any held entry is referenced, as before. AssetCollector takes a matching per-document-owner function so the one-time backfill scopes each document the same way. This keeps a document naming a leaked id from committing, exposing or pinning another owner's allocation. - RuntimeStageNotFoundError: a store may refuse createSession for a stage its host considers absent; the runtime handler answers 404 STAGE_NOT_FOUND, recognizing the error by class or by code. - A session create over a taken id answers 409 SESSION_ALREADY_EXISTS whoever holds it. It used to answer 403 for another learner's session and 409 for one's own, which told a caller whose session an id was. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(persistence): close owner-seam boundary gaps in references, tombstones and legacy assets - Document writes reference and commit only the writer's own asset entries and legacy shared ones (owner-bound document store and the collector backfill), so another owner's course naming a pending id can no longer commit, expose or pin it. - The foreign-read rule additionally requires the referencing live course to belong to the entry's owner, as defense in depth for reference rows that did not come from a scoped write. - The tombstone refusal for new runtime sessions moved from a raw path comparison in the route into the guarded store's createSession (RuntimeStageNotFoundError, 404 STAGE_NOT_FOUND), so no encoded spelling of the path routes around it. - Replacing or deleting a legacy shared entry checks reference ownership and mutates in one transaction under the entry row lock, which a concurrent reference insert must wait for. - Tests build the uncommitted-but-referenced, tombstoned-with-rows and foreign-reference states directly so each half of the read rule is observable, and a PostgreSQL suite holds a competing reference open across a legacy delete. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(persistence): upgrade note for dev-token-gated deployments, owner-scoped references Tell operators whose only access gate was the development token to put the deployment behind an access code or gateway, register an owner authenticator, or turn server persistence off before upgrading, and describe that a course references only its owner's media. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(storage): per-owner reference principals and a typed taken-id conflict - PgDocumentStore's assetReferencePrincipals is now a function of the store's bound owner, evaluated per write, instead of a fixed list. A store re-bound with forOwner therefore scopes to the new owner rather than carrying the previous owner's principals onto its writes. It has the same shape as AssetCollector's backfill option, so one function serves both. - PgRuntimeStore and BrowserRuntimeStore raise RuntimeSessionExistsError for a taken session id, and the runtime handler classifies it as 409 SESSION_ALREADY_EXISTS even when its re-read cannot see the holder (for example a session a host-side wrapper hides). Recognized by class or by code. Still the unreleased 0.32.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(persistence): guard the Pi whiteboard runtime and answer hidden collisions with 409 - Every server-side runtime writer now uses the tombstone-guarded store: the Pi native whiteboard service gets it through the same helper as /api/persistence/runtime/*, so a deleted course takes no new whiteboard runtime either. - Creating a session whose id is held by a session a tombstone hides answers the uniform 409 SESSION_ALREADY_EXISTS instead of a 500, covered on PGlite and on real PostgreSQL. - The owner-bound document store passes its reference-principal function, so the scoping follows the bound owner. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * feat(auth): owner identity seam, phase 3 — accounts through an identity gateway (trustedProxyHeader) * feat(auth): owner identity seam, phase 3 — trusted-proxy-header authenticator Add the trustedProxyHeader built-in: real accounts through an identity gateway (oauth2-proxy, Authelia, a Keycloak-based proxy, an institutional reverse proxy) that signs the user in and forwards the verified user in a request header. OpenMAIC never handles passwords or tokens. - Selected with OWNER_AUTHENTICATOR=trusted-proxy and validated in instrumentation register(). TRUSTED_PROXY_SECRET (32-1024 printable ASCII characters) is required; header names default to x-openmaic-proxy-secret and x-forwarded-user, and an optional groups header with TRUSTED_PROXY_ADMIN_GROUPS grants admin. An unknown selector, a TRUSTED_PROXY_* variable without the selector, a shared owner id or a host-registered authenticator alongside it, and malformed, reserved or repeated header names fail the boot. - Trust boundary: Next.js exposes no TCP peer address to route handlers, middleware or Server Actions, and fills x-forwarded-for from the socket only when the client sent none, so no address allowlist is offered. The gateway secret is compared in constant time (hashed, timingSafeEqual). - Per request: a missing or wrong secret, a missing or blank user, a user header with a comma (duplicate lines arrive comma-joined), or a user whose proxy:<user> id fails the owner id guard is 401 INVALID_CREDENTIAL, never an anonymous owner. The guard failure is a 401 rather than a 500 because the value comes with the request. The user is trimmed and keeps its case. Every gateway user holds course:publish; kind user, assurance verified, channel proxy; no cookie. Route handlers and Server Actions share one code path. - The unset-ACCESS_CODE boot warning is skipped in this mode; the gateway is the access gate and ACCESS_CODE stays independent. - The identity boundary scan now also fails on gateway identity headers (x-forwarded-user/-groups/-email, x-auth-request-*, remote-user, the secret header) and TRUSTED_PROXY_* read outside lib/server/identity. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(auth): document accounts through an identity gateway Describe the trustedProxyHeader built-in in the README owner identity section (and its Chinese counterpart): configuration, request semantics, the trust boundary and why it is a shared secret, the interaction with ACCESS_CODE, boot-time validation, and an oauth2-proxy example that injects the user, groups and secret headers. Add the .env.example block, a SECURITY.md note and an Unreleased changelog entry. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(auth): harden the trusted-proxy authenticator after review - Reserve the header names HTTP, Next.js and forwarding proxies set themselves: configuring the user, groups or secret header to rsc, next-action, forwarded, x-forwarded-for/-host/-proto/-port, x-real-ip, or anything starting with x-middleware-, x-invoke-, x-nextjs- or next-router- now fails the boot. - Log a one-time boot warning when TRUSTED_PROXY_ADMIN_GROUPS is set: the admin role is granted from the groups header, which is trusted on the strength of the shared secret alone, so the gateway must overwrite or strip it. - POST /api/chat/pi resolves the owner up front and answers 401 when the authenticator rejects the credential, like every other owner-resolving route, instead of continuing without an owner. The anonymous default always resolves, so it is unaffected. - The identity boundary scan also covers the Authentik, Azure App Service authentication, WebAuth, Cloudflare Access, Google IAP and AWS ALB OIDC header families. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(auth): admin-groups warning and a corrected oauth2-proxy example - Warn next to TRUSTED_PROXY_ADMIN_GROUPS (README, README-zh, .env.example) that the groups header is trusted on the strength of the shared secret alone, and list the reserved header names. - The oauth2-proxy example now states it targets v7.14+ (nested claimSource/secretSource), uses the canonical bindAddress, sets preserveRequestValue: false on all three headers and insecureSkipNonce: false, forwards the subject with `claim: user`, and notes that the secret variable holds the literal secret. It adds the legacy-option migration caveat, a warning not to exempt app routes via skip-auth or trusted-ip options, and notes that the IdP must release the groups claim and group names must not contain commas. - Changelog: the new boot checks and the /api/chat/pi 401. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * feat(persistence): owner identity seam, phase 4 — host extension hooks * feat(persistence): owner identity seam, phase 4 — host extension hooks Let a host add product behavior at four points without forking a route, registered once from instrumentation.ts register() like the owner authenticator and sealed on first use. Nothing changes when no hook is registered. - configurePersistenceHooks({ name, authorizeCreate, onCreate, library, beforeAssetAllocate }): - authorizeCreate / onCreate run once per created course, inside the create transaction, in the transaction that inserts the course's ownership row. Saves of a course the owner already holds, and a create that loses a race to a concurrent create of the same id, are updates and run no create hook. A refusal answers 403 CREATE_REFUSED; a throw rolls the course, its ownership row and the host's writes back together. The hooks receive the request principal, or only the owner id for a background agent run. - library chooses which stage ids GET /api/stages lists; the route builds the usual summaries in the provider's order and drops every id the read path would refuse (deleted or unclaimed). folderId is shown only on the principal's own courses. - beforeAssetAllocate runs inside the storage handler's asset authorization step for POST /assets, after the owner is resolved and before the body is read; a returned Response is sent instead, with nothing stored and no quota counted. - configureAssetByteStore({ name, create, signsReadUrls }) replaces the ASSET_S3_BUCKET switch for both the persistence provider and the asset collector. A host store must keep bytes outside the registry database. Under ASSET_BYTE_EGRESS=redirect a store that does not declare signsReadUrls stops the server at boot; the built-in layers keep their behavior. - @openmaic/storage 0.33.0: DocumentWriteRefusedError lets a store refuse a write as policy; the document HTTP handler answers 403 with its code. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(persistence): harden the host extension hooks after review Correctness: - Registration reads every hook once and stores it bound to the object the host passed, so hooks defined on a class prototype or as non-enumerable properties are kept. A spread copy dropped them silently, including the authorizeCreate and beforeAssetAllocate gates. Same for configureAssetByteStore. The unknown-key check now applies to plain objects only, since class instances carry their own state fields. - The owner-bound document store carries each call's operation in its own async context (AsyncLocalStorage) instead of a field on the instance. One store is shared by every tool of an agent run; a concurrent call could overwrite the field before the transaction read it, so a create was gated as a read (no ownership row, no create hooks) or claimed another stage. create_stage also runs sequentially within a tool batch. Hardening: - isDocumentWriteRefusedError recognizes a refusal from another copy of the storage package by name and shape (not by code alone). The document handler and POST /api/stages use it. - beforeAssetAllocate also gates PUT /assets/{id}/content. The request carries operation ('create' | 'replace') and the decoded assetId from the handler's own routing. - Agent runs: a refusal on a background write carries a fixed message, and create_stage answers it with a stable tool result. The host's message never reaches the model. - A byte store declaring signsReadUrls without a signer degrades to direct bytes with a warning instead of failing reads, and the collector no longer requires signing. - DocumentActor is discriminated by source ('request' with the principal, 'background' without one). - Library ids the read path cannot address are dropped, and a provider answer is capped at 5000 ids. - The boot-time ownership backfill logs how many courses it adopted without hooks. - The server persistence provider no longer exposes an unscoped document store. - The writesOutsideRegistryDatabase trust boundary and the scope of upload admission (HTTP uploads, not server-generated media) are documented. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(persistence): refuse misspelled hooks on host classes too A class instance skipped the unknown-key check, so a misspelled hook such as authorizeCreat registered cleanly and never ran, leaving creation ungated. Both configurePersistenceHooks and configureAssetByteStore now reject any function-valued property of a class instance (own or on its prototype chain up to Object.prototype, constructor excluded) that is not a known key, and any unknown key of a plain object. The error names the key and suggests the known key within edit distance 2. Host classes keep their helpers private (#helper) or register a plain object; the README says so. Also: - isDocumentWriteRefusedError requires a string message from a cross-copy candidate, and documents that the name is the effective discriminator. - CHANGELOG: ServerPersistenceProvider no longer exposes an unscoped documentStore; use the owner-bound store. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * feat(persistence): owner identity seam, phase 5 — tenancy lives in stage_meta only * feat(persistence): owner identity seam, phase 5 — tenancy lives in stage_meta only Course ownership was recorded twice: in stage_meta, which already answers every access decision, and in document_stages.owner_id, which the storage package scoped by. Two tenancy records double what a later claim has to re-key, and a host that keeps ownership in its own table had to rewrite the package's SQL to strip the column. @openmaic/storage 0.34.0: - PgDocumentStore never reads or writes document_stages.owner_id. An owner-bound store scopes listings, writes, deletes, the freshness manifest and folder membership through the host's ownership relation, named with the new documentOwnership option ({ table, stageIdColumn, ownerIdColumn, tombstoneColumn, claimOnCreate }, or false for no document scoping). Identifiers are validated, never quoted into SQL from arbitrary input. - forOwner / ownerId without documentOwnership throws at construction, so a direct consumer cannot upgrade into a store that silently scopes nothing. An unbound store is tenant-agnostic. - claimOnCreate inserts the ownership row in the create transaction; a concurrent create of the same id by another owner rolls back. - folders: false lets a host whose document_stages has no folder_id use the store; folder ids are unique per owner, so membership goes through the ownership relation too. - AssetCollector reads each document's owner from documentOwnership for assetReferencePrincipals, and refuses the function without it. - Schema: fresh installs get no owner_id column and none of its indexes; an existing column is kept for one release, made nullable with its default dropped (each ALTER guarded by a catalog check, so a replay takes no lock), and its two indexes are dropped. document_stages_folder_idx replaces the owner/folder index. Application: - The owner-bound store binds the package to stage_meta (STAGE_META_OWNERSHIP) and lists through it in one query; the asset collector schedule passes the same relation. - The boot backfill copies column-only owners into stage_meta before any store is built, only when the legacy column exists, idempotently, and logs how many it adopted and how many disagree (stage_meta stands). Tests cover a fresh install and an upgrade from the previous schema on PGlite and PostgreSQL 16, a host table with neither ownership nor folder columns, folder isolation across owners sharing a folder id, and the concurrent-create race. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(persistence): serialize schema bootstrap; guard unscoped owner-bound stores Review follow-ups for the tenancy change. - Concurrent starts: two instances starting against one database raced on the schema DDL (a duplicate pg_class / pg_type entry, or "tuple concurrently updated"), failing one instance's first request. Every schema bootstrap the application runs -- the persistence provider's sequence (runtime, documents, stage_meta and its ownership backfill, owner materials, assets), the agent-session, session-material and user-skill stores, and the asset collector's -- now runs under one PostgreSQL advisory lock held on a dedicated connection and released in finally. It lives in the application because what needs serializing is the whole sequence, including tables the package does not own. A PostgreSQL test boots eight instances at once, four rounds each, on a fresh and on an upgraded database; without the lock it fails every run. - documentOwnership: false on an owner-bound PgDocumentStore now also requires allowCrossOwnerDocumentAccess: true, so binding an owner for folders or asset principals cannot silently expose every owner's documents. - Documented that an ownership relation must cascade with the document rows (a leftover row keeps the id reserved for its owner, which is also how a host keeps retired ids from being reused), with tests for both. Leftover rows are deliberately not made claimable: a host cannot be told apart from one that keeps them as retirement markers. - Upgrade notes: the one-time table locks on the first start, and the out-of-band CREATE INDEX CONCURRENTLY / DROP INDEX CONCURRENTLY path that leaves the start with nothing to build or drop. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(persistence): leave the schema bootstrap lock out of the held-lock check The create-hooks suite asserts that its host lock is released with the create transaction by counting granted advisory locks database-wide. A suite booting a provider against the same database at that moment now holds the schema bootstrap lock, which is not the lock under test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * feat(auth): owner identity seam, phase 6 — claiming anonymous work on sign-in * feat(storage): owner merge primitives for claiming anonymous work (0.35.0) Add the per-store pieces a host needs to move one owner's data to another inside a single transaction of its own: - reassignDocumentFolders(tx, { fromOwnerId, toOwnerId, documentOwnership }) moves folders and filing: a same-named folder merges into the target's, a colliding id is renumbered, and filing is rewritten in one statement from the old ids. - PgAssetStore.reassignPrincipal(fromKey, toKey) moves a principal's entries under both principals' write locks, in key order; quota is not re-checked. - PgUserSkillStore.mergeOwner(from, to) moves skills, renaming a live handle the target already uses with the first free numeric suffix. - PgUserSkillStore takes a resolveFinalOwner hook, run as the create transaction's first statement, like the agent-session store's. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * feat(auth): owner identity seam, phase 6 — claiming anonymous work on sign-in A visitor who works anonymously and then signs in can move that work to their account in one transaction, and the anonymous id is retired afterwards. - Principal: pendingClaim { fromOwnerId, assurance }. The trusted-proxy built-in sets it when a gateway request also carries a valid anonymous cookie; the anonymous and shared-team built-ins never do. Authenticators may implement describeStoredOwner, canonicalize and clearPendingClaim; principalFromStoredOwner describes a stored id for work without a request. - Claims: claimOwner / claimPendingOwner and registerClaimParticipant (sealed on first claim). One transaction, both owners' identity locks taken exclusively in key order, participants in a fixed order (folders, courses, materials, agent sessions, skills, runtime, assets), recorded in the new owner_merges table. Idempotent per pair; refuses a non-anonymous source, an anonymous target, a source already claimed elsewhere, and chains. Same-named folders merge, colliding folder ids are renumbered, colliding skill handles get a suffix, and quotas are not applied to what moves. - Identity lock: every owner write (documents, folders, asset allocations, material registration, agent sessions, skills) takes the owner's advisory lock in shared mode first, so a write racing a claim is moved or refused, never orphaned or deadlocked. - Retired ids: request writes are refused with 403 OWNER_RETIRED; agent runs and media generation that started before the claim follow the id to the account (forwarding document store, canonicalized stage probes, forwarded generated assets and skills). - Trigger: POST /api/identity/claim (same-origin JSON only; clears the anonymous cookie), or OWNER_CLAIM_TRIGGER=auto on the first request carrying a pending claim. The runtime contract's learner merge now performs the same claim, allowed only for the request's own pending claim. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(persistence): count only the suite's own advisory locks after concurrent creates The check that a host's transaction-scoped lock is released counted every granted advisory lock in the database. Suites that run against the same database at the same time hold advisory locks of their own (a schema bootstrap, the owner identity locks a claim takes), which made it fail depending on timing. Count only locks held by this suite's connections. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(auth): use a neutral example table for host claim participants Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(storage): owner merge fixes and store policy errors over HTTP (review round 1) - PgUserSkillStore.mergeOwner reserves every handle either owner holds before renaming: a claimed skill whose handle the target uses could be renamed into a handle another claimed skill still held, which violated the per-owner unique index and made that merge fail every time. - PgUserSkillStore.list orders ties by id. - PgRuntimeStore takes resolveFinalLearner(tx, learnerKey), run as the create transaction's first statement, so a host can fence session creates against its owner merges; reassignLearner(from, to) re-keys sessions without re-validating them, so one session a newer version wrote cannot block a merge. - Every HTTP handler (runtime, documents, assets) answers a DocumentWriteRefusedError as 403 with its code, and the new StorageBusyError (code, message, retryAfterSeconds) as 503 with Retry-After. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(auth): claims review round 1 — fenced runtime creates, bounded locks, retired-cookie recovery - Runtime session creates take the owner's identity lock as the create transaction's first statement and refuse a retired owner, closing the window in which a create racing a claim was left under the retired id. - Lock waits are bounded: a claim waits OWNER_CLAIM_LOCK_WAIT_MS (default 5 s) for its identity locks, a write OWNER_WRITE_LOCK_WAIT_MS (default 30 s); running out, or losing a deadlock or serialization race, answers 503 OWNER_BUSY with Retry-After on the claim routes and on every fenced write. - Every 403 OWNER_RETIRED carries the Set-Cookie values that drop the retired anonymous credential (the anonymous built-in now implements clearPendingClaim), so a browser whose claim response was lost recovers. Writes by id to rows that moved (skill delete, session messages) answer OWNER_RETIRED instead of not-found or a bare 403. - OWNER_CLAIM_TRIGGER=auto no longer claims ahead of the explicit claim routes, which now report their own claim instead of a false refusal. - The owner-events stream tells a retired owner only that it moved, never the claiming account's id. - Creates of one course id take turns (a per-id advisory lock before the ownership probe), so a concurrent second create saves as an update instead of failing as reserved-document. - A claim's source must be described as anonymous by the authenticator; the write fences skip the retirement lookup for every other owner. The host canonicalize hook is removed: forwarding is core's owner_merges alone. - The folders participant locks the source's stage_meta rows first; runtime sessions are re-keyed without re-validation; the owner asset store fences every allocation and refuses to allocate without transactions; background skill reads and patches follow a mid-run claim; the forwarding document store forwards methods only. - Docs: when a pending claim can arise with the shipped authenticators, the anonymous cookie as a bearer credential, bounded waits, the exact scope of OWNER_RETIRED, and claims narrowed to what the tests show. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(auth): claims review round 2 — merge-record guard, boot-checked lock waits, stream credential drop - owner_merges records claims of anonymous owners only, since the write fences enforce retirement only for ids the authenticator describes as anonymous. Reading a row that retires any other owner now fails loudly instead of being followed but not enforced. The comment that pointed hosts at claimOwner for their own account merges is corrected: a host merging two signed-in accounts moves the rows itself and refuses the merged-away account in its authenticator. describeStoredOwner must classify ids stably. - OWNER_WRITE_LOCK_WAIT_MS and OWNER_CLAIM_LOCK_WAIT_MS are validated at boot with the same parser the lock paths use, so a malformed value stops the server instead of failing every write. - The owner-events stream answers a connect by an already retired identity with one owner_moved event and the Set-Cookie values that drop the retired credential, so a stale tab's reconnect loop ends after one round trip. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * chore(auth): final polish before landing the owner identity seam * chore(auth): final polish before landing the owner identity seam - Pi routes refuse a rejected credential with the seam's INVALID_CREDENTIAL body. - Drop the unused LegacyAssetMutations alias and resolveLockWaitMs re-export. - Scope the document_stages.owner_id deprecation wording: the store no longer reads or writes it; the boot backfill reads it and a claim mirrors ownership into it for rollback. - Document OWNER_CLAIM_TRIGGER and the two lock-wait variables in .env.example. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(storage): 0.35.1 for the README wording fix Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * feat(identity): one identity entry point with composable auth methods * feat(identity): compose owner auth methods behind one entry point Owner resolution now asks an ordered list of owner auth methods instead of one configured authenticator. Each method answers `authenticated`, `not-applicable` (no credential of its kind) or `invalid` (its credential is present but bad). Core keeps the first `authenticated` answer, refuses any `invalid` answer with 401 INVALID_CREDENTIAL without asking later methods, and when no method applies falls back to the anonymous cookie owner, or answers 401 when the host turned the fallback off. Route handlers and Server Actions share the same order and per-request memoization. - configureOwnerAuthentication({ methods, anonymousFallback? }) replaces configureOwnerAuthenticator: single-shot, sealed on first use, and validated at registration and at boot. - anonymousCookie becomes the built-in fallback method; sharedTeam becomes a method, selected by PERSISTENCE_SHARED_OWNER_ID as before when nothing is registered, and kept beside host methods only when the host lists sharedTeamAuthMethod() last. The variable set beside a registration that leaves it out fails the boot. - Core attaches pendingClaim itself: a host method's non-anonymous principal on a request that also carries a valid anonymous cookie. A method may not set one. Claim cookie clearing and OWNER_RETIRED recovery go through the anonymous method's clearCredential. - principalFromStoredOwner consults the anonymous method first, then the configured methods' describeStoredOwner in order. - Remove the built-in trusted-proxy header authenticator with OWNER_AUTHENTICATOR and every TRUSTED_PROXY_* variable. The boundary test now also keeps the resolution internals inside lib/server/identity/ and asserts no source reads the removed variables. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(identity): document owner auth methods and a gateway JWT recipe Rewrite the owner identity section around the ordered auth methods: the three answers and what resolution does with each, the anonymous fallback, registration and its boot checks, and the sharedTeam rules. Replace the removed built-in gateway authenticator's documentation with a short host-owned recipe that verifies a gateway-forwarded signed JWT (oauth2-proxy, Cloudflare Access, IAP) against the identity provider's keys with the jose library. Update the claim section for the core-owned claim candidate, and the Chinese README, SECURITY.md, CHANGELOG and the deployment docs in every locale to match. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(identity): tighten retired-owner cookies, retired config and the boundary - On 403 OWNER_RETIRED, core now calls clearCredential only on the anonymous fallback and on methods that declare `issuesAnonymousOwners: true`, so an account method's session cookie is never cleared there. A clearCredential that throws is logged and skipped instead of turning the refusal into a 500. - Setting any retired OWNER_AUTHENTICATOR / TRUSTED_PROXY_* variable fails the boot with a pointer to the auth-methods docs, instead of silently serving every request anonymously. Only the names are matched, in one module the boundary test checks never reads a value. - Add lib/server/identity/host/ for host auth methods. The boundary test now scans core identity files for gateway identity headers too, polices reads of an incoming Authorization header everywhere but the host directory, and keeps resolution internals out of host code. - Document on OwnerAuthMethodResult that a present but unusable credential must answer `invalid`, never `not-applicable`, and that a method that cannot decide throws. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(identity): fix the gateway JWT recipe's error split and add notes - The recipe now answers `invalid` only for token failures (expired, claim validation, malformed JWS/JWT, bad signature, no or several matching keys, disallowed or unsupported algorithm) and rethrows everything else: jose reports a key endpoint that is down, answers non-200 or returns unparsable data as a generic JOSEError, which the previous version turned into a 401 for every user. - The recipe file goes in lib/server/identity/host/, with an accurate description of what the boundary test enforces. - Document invalid versus not-applicable for malformed credentials, issuesAnonymousOwners, the boot failure on retired variables, and that the claim candidate is an unsigned bearer cookie a sibling subdomain can shadow (serve on a registrable domain of its own; cookie hardening is deferred). Mirror the notes in the Chinese README, SECURITY.md and the changelog. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
56322a5e06 |
fix(generation): reject unusable interactive scripts and surface runtime errors (#1649)
Reject classic inline interactive scripts that fail to parse at generation time (extracted with parse5, checked with node:vm Script without executing), and surface iframe runtime errors on the active interactive scene. Addresses #1622 (partial: no recovery / regeneration UI). Co-authored-by: Frank-zhu0404 <Frank-zhu0404@users.noreply.github.com> |
||
|
|
d04a75cbc6 |
feat(ai): add Xiaomi MiMo V2.6 models [AI-assisted] (#1655)
* feat(ai): add Xiaomi MiMo V2.6 models * docs(ai): preserve Xiaomi provider references --------- Co-authored-by: wyuc <wang-yc24@mails.tsinghua.edu.cn> |
||
|
|
fbc51fcbd6 |
fix(generation): reject invalid quiz option shapes and constrain values at the source (Closes #1375) (#1651)
* fix(generation): enforce quiz option value/label contract When a model puts choice content in value and a bare A-Z letter in label, swap those fields so persisted quiz options keep a letter as the selection identity and the content as the label. Correct objects, plain strings, and answer-key normalization stay as they were. Closes #1375 * fix(generation): rewrite swapped quiz letter keys to option values When a bare label is moved onto the option value, a raw answer token that exactly equals that original label is rewritten to the uppercased letter before exact alignment. The stored key is then the letter QuizView submits, so that submission grades correct. A stored "a" on an already-correct value "A" is left unresolved. Closes #1375 * fix(generation): reject invalid quiz option shapes instead of swapping Stop rewriting quiz options when a model puts content in value and a letter in label. The quiz prompt now requires value to be one ASCII letter A-Z and label to be the option content. A choice question that still breaks that contract, or whose answer does not name an option value, is invalid model output and regenerates. Closes #1375 --------- Co-authored-by: wyuc <wang-yc24@mails.tsinghua.edu.cn> |
||
|
|
283a3096aa |
fix(editor): share line bounds for alignment and dragging (#1631)
Co-authored-by: wyuc <wang-yc24@mails.tsinghua.edu.cn> |
||
|
|
7be21f2d89 |
fix(chat): pin Pi routing and preserve provider errors (#1637)
Co-authored-by: wyuc <wang-yc24@mails.tsinghua.edu.cn> |